Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp365896yba; Mon, 1 Apr 2019 07:58:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqwUYVYl57W4CWjF80NkK/jDSdyvwmN+mn15PCs9Nq6N/602HKNXKV8zMk1qDAirLeassOd6 X-Received: by 2002:a63:1d5b:: with SMTP id d27mr5844228pgm.386.1554130684160; Mon, 01 Apr 2019 07:58:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554130684; cv=none; d=google.com; s=arc-20160816; b=roMhtmCLzv3bnFTGyNVNx5/bHchhsIcG0H2c6D7GyXFmdyrGCGYWI/yZbdNmKqOAZF U8OmiEtT4NKJcGIdGHWaynDWy0IT8C2kalbQgdobWepP1bXtFXAwx0MKkyV88GGr2HGH IBvPixAoWdoDZ+275NhQgun7c0TwIoPHKTOXFW5UFzvv//mNATYieH3N8/TOzsbaWYOo 7K0R579lJ5p2yZJv0lQh9+a9T5SiAPTF4ALCc10T9UEa7arJ/6Z/j8sTae1tFPhlyqV9 NySjrHQbfsUw0MBrU0Htn0UBvCMhNNHxEm/zmKOdHBe9lOXAvEn5ARxPzFrlKk+sQuKF d1DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=8K3zZ2w/pW9lpFgX0cFEnReDS//XdLDARItW4XAnJM8=; b=Uaf1ooMxJSWMK20jqY8pjpuI+e4QhLAsOlBq5lDBPzCoQrZcBSjS7XWfzLXlfZXCXG GReAMGSJZh4lgtWgiA7f2j5BxZckBV0RZ4qf90LWriyVAmXK69FgFg3kED87g7mNUPI2 2KZhvOqqJEPa+iatJbPScOe0unPgPz2O8CLZSisZoxdyd6/Lt4Yt8lOhGLtN1x59Dzqt DZUmZbyR+eQ/z+sa/gxyd3cd7PL92Lmf0M2/X5UXcDPvvRsyvaeuItmvYJHcEcDilmky 2uj848AbbkNfh+WIMuOd9Wph7GE0BRBZJoa4oP9AWepbpn0vYBJImqNuA6vPkRb1tyMW mzbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a15si8958770pgd.166.2019.04.01.07.57.48; Mon, 01 Apr 2019 07:58:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728641AbfDAO5J (ORCPT + 99 others); Mon, 1 Apr 2019 10:57:09 -0400 Received: from foss.arm.com ([217.140.101.70]:36136 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726514AbfDAO5I (ORCPT ); Mon, 1 Apr 2019 10:57:08 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3B7D4A78; Mon, 1 Apr 2019 07:57:08 -0700 (PDT) Received: from [10.1.194.37] (e113632-lin.cambridge.arm.com [10.1.194.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 61F993F690; Mon, 1 Apr 2019 07:57:05 -0700 (PDT) Subject: Re: [PATCH v5 00/13] Add support for usb on Hikey960 To: Yu Chen , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: john.stultz@linaro.org, suzhuangluan@hisilicon.com, kongfei@hisilicon.com, liuyu712@hisilicon.com, wanghu17@hisilicon.com, butao@hisilicon.com, chenyao11@huawei.com, fangshengzhou@hisilicon.com, lipengcheng8@huawei.com, songxiaowei@hisilicon.com, xuyiping@hisilicon.com, xuyoujun4@huawei.com, yudongbin@hisilicon.com, zangleigang@hisilicon.com References: <20190329041409.70138-1-chenyu56@huawei.com> From: Valentin Schneider Message-ID: <867b3cd6-85d5-e87c-0973-ac48d13fb18b@arm.com> Date: Mon, 1 Apr 2019 15:57:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190329041409.70138-1-chenyu56@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 29/03/2019 04:13, Yu Chen wrote: > The patchset adds support for usb functionality of Hikey960, includes: > - usb phy driver for Hisilicon Kirin Soc hi3660 > - usb driver for HiKey960 board > - some adjustment in dwc3 and usb role driver > - dts for support usb of HiKey960 > > --- > v5: > * Split modification of usb role into two patches, the first one introduces > stubs for the exiting functions, and the second adds notifier functions. > --- > Ran the usual tests, still works fine for me. Tested-by: Valentin Schneider Thanks, Valentin > Yu Chen (13): > dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY > dt-bindings: misc: Add bindings for HiSilicon usb hub and data role > switch functionality on HiKey960 > usb: dwc3: dwc3-of-simple: Add support for dwc3 of Hisilicon Soc > Platform > usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc > usb: dwc3: Execute GCTL Core Soft Reset while switch mdoe for > Hisilicon Kirin Soc > usb: dwc3: Increase timeout for CmdAct cleared by device controller > phy: Add usb phy support for hi3660 Soc of Hisilicon > usb: roles: Introduce stubs for the exiting functions in role.h. > usb: roles: Add usb role switch notifier. > usb: dwc3: Registering a role switch in the DRD code. > hikey960: Support usb functionality of Hikey960 > usb: gadget: Add configfs attribuite for controling > match_existing_only > dts: hi3660: Add support for usb on Hikey960 > > .../bindings/misc/hisilicon-hikey-usb.txt | 52 +++++ > .../devicetree/bindings/phy/phy-hi3660-usb3.txt | 26 +++ > MAINTAINERS | 8 + > arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 53 +++++ > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 73 +++++++ > drivers/misc/Kconfig | 6 + > drivers/misc/Makefile | 1 + > drivers/misc/hisi_hikey_usb.c | 162 ++++++++++++++ > drivers/phy/hisilicon/Kconfig | 10 + > drivers/phy/hisilicon/Makefile | 1 + > drivers/phy/hisilicon/phy-hi3660-usb3.c | 233 +++++++++++++++++++++ > drivers/usb/dwc3/Kconfig | 1 + > drivers/usb/dwc3/core.c | 45 ++++ > drivers/usb/dwc3/core.h | 15 ++ > drivers/usb/dwc3/drd.c | 63 +++++- > drivers/usb/dwc3/dwc3-of-simple.c | 4 +- > drivers/usb/dwc3/gadget.c | 2 +- > drivers/usb/gadget/configfs.c | 32 +++ > drivers/usb/roles/class.c | 20 +- > include/linux/usb/role.h | 46 ++++ > 20 files changed, 849 insertions(+), 4 deletions(-) > create mode 100644 Documentation/devicetree/bindings/misc/hisilicon-hikey-usb.txt > create mode 100644 Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt > create mode 100644 drivers/misc/hisi_hikey_usb.c > create mode 100644 drivers/phy/hisilicon/phy-hi3660-usb3.c >