Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 1 Apr 2019 17:26:51 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Aditya Pakki <pakki001@umn.edu>
Cc:     kjlu@umn.edu, Stefan Agner <stefan@agner.ch>,
        Boris Brezillon <bbrezillon@kernel.org>,
        Richard Weinberger <richard@nod.at>,
        David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Marek Vasut <marek.vasut@gmail.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: vf610: Fix to check for NULL pointer
 dereference
Message-ID: <20190401172651.158c05fe@xps13>
In-Reply-To: <20190318232434.9246-1-pakki001@umn.edu>
References: <20190318232434.9246-1-pakki001@umn.edu>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Aditya,

Aditya Pakki <pakki001@umn.edu> wrote on Mon, 18 Mar 2019 18:24:34
-0500:

> of_match_device can return NULL if there is no matching device is found.
> The patch avoids a potential NULL pointer dereference by checking for the
> return value and passing the error upstream.
> 
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
>  drivers/mtd/nand/raw/vf610_nfc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/nand/raw/vf610_nfc.c b/drivers/mtd/nand/raw/vf610_nfc.c
> index a662ca1970e5..946abbb275c3 100644
> --- a/drivers/mtd/nand/raw/vf610_nfc.c
> +++ b/drivers/mtd/nand/raw/vf610_nfc.c
> @@ -850,6 +850,8 @@ static int vf610_nfc_probe(struct platform_device *pdev)
>  	}
>  
>  	of_id = of_match_device(vf610_nfc_dt_ids, &pdev->dev);
> +	if (!of_id)
> +		return -ENODEV;
>  	nfc->variant = (enum vf610_nfc_variant)of_id->data;
>  
>  	for_each_available_child_of_node(nfc->dev->of_node, child) {


Applied to git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
on nand/next with the title changed to

        mtd: rawnand: vf610: Avoid a potential NULL pointer dereference

and a space after the return statement.

Thanks,
Miquèl