Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp397838yba; Mon, 1 Apr 2019 08:31:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqx6ibPebh5V5XcroyKI2TSwwNOpiHiHakJ8rG++xc+oWhNl0svipJMXClsm8bK1GJe2ZS3s X-Received: by 2002:a63:7e10:: with SMTP id z16mr8097888pgc.40.1554132702158; Mon, 01 Apr 2019 08:31:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554132702; cv=none; d=google.com; s=arc-20160816; b=AzOTDbKjzYmEyoZpmovdXaOOqtK/LiYmbwonzUUxKMCOoLHbtM8lXeCJWNL5luAE7L sj0KG8sCwY6+pvmXRL+ZutA0BzGRsSuFcrln1K/uVmJZNrYKED/5/lMnIsv2D/vLP0HL 1gtsclfp7vmn//b0PerjolZZUBfy4OKGNGKFR4EanIGyt/tZJjV7Ruzn2owzLedXk0Bt ipvL1Usebl9n0WQtOnM39xnQIgu579fzsKePXLOi6MY8L4SdSuKkppkW6P/pYrTwpCZl eKnT0tmLvfn1mGN6UoZax8A3B+Oh/NfcHeOYKQt6NyrpR/Jatc746M1KizxYhyieDGWz FH/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=8cgzF+4YBEXpA7BL1HWXIY1lyzRR3LZIQDn9MNznNi4=; b=h9ueqX4q9Ag0k5mYzbp9Te8PT6u4H+zvhLO5pi12RPJotx3wI1MHHX0aSOMn1UoHMt UzJfFzzVW+V1v5pf9QP94HScBgHORbwqrP1dzUNNG0lKn/kMXJadOja1tXGS/dUx8dm8 ygWGrMYHzzIEt8hqyEL5Dw4+LsZvLkNRC/X2rtXhH657IAKVPf+qqqbjbd3PjXPcwu0e eEF/RRwu7npY0rKl9yPUlvQY9eEGyq3Un1Q73qw743VqpuohOkLP6TTXi4Yx2eudhAKy YJGviQnyoC9ixIVfH3tfT3LeRxbd+XcyqYoux83qhvnNd9UJA//PFDq34I/SCTNqUzue Uf2Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v21si8974987pff.44.2019.04.01.08.31.26; Mon, 01 Apr 2019 08:31:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728551AbfDAPaq convert rfc822-to-8bit (ORCPT + 99 others); Mon, 1 Apr 2019 11:30:46 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:54187 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726775AbfDAPap (ORCPT ); Mon, 1 Apr 2019 11:30:45 -0400 X-Originating-IP: 90.88.32.136 Received: from xps13 (aaubervilliers-681-1-91-136.w90-88.abo.wanadoo.fr [90.88.32.136]) (Authenticated sender: miquel.raynal@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id ED9F3C0014; Mon, 1 Apr 2019 15:30:40 +0000 (UTC) Date: Mon, 1 Apr 2019 17:30:39 +0200 From: Miquel Raynal To: Liang Yang Cc: Boris Brezillon , , David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Carlo Caione , Kevin Hilman , Rob Herring , Jian Hu , Jianxin Pan , Hanjie Lin , Victor Wan , , , , Subject: Re: [PATCH 1/1] mtd: rawnand: meson: set oob layout ops Message-ID: <20190401173039.723dc3ea@xps13> In-Reply-To: <1553170441-23448-1-git-send-email-liang.yang@amlogic.com> References: <1553170441-23448-1-git-send-email-liang.yang@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Liang, Liang Yang wrote on Thu, 21 Mar 2019 20:14:01 +0800: > Specify the oob layout operation to avoid no oob scheme defined for > some nand flash. > > Fixes: 8fae856c5350 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller") > Signed-off-by: Liang Yang > --- > drivers/mtd/nand/raw/meson_nand.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c > index 3e8aa71..a2154a2 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -1183,6 +1183,8 @@ static int meson_nand_attach_chip(struct nand_chip *nand) > return -EINVAL; > } > > + mtd_set_ooblayout(mtd, &meson_ooblayout_ops); > + > ret = meson_nand_bch_mode(nand); > if (ret) > return -EINVAL; Applied to git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git on nand/next. Thanks, Miquèl