Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 1 Apr 2019 09:54:01 -0700
From:   Andi Kleen <andi@firstfloor.org>
To:     Hugues FRUCHET <hugues.fruchet@st.com>
Cc:     Andi Kleen <andi@firstfloor.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andi Kleen <ak@linux.intel.com>,
        "mchehab@s-opensource.com" <mchehab@s-opensource.com>
Subject: Re: [PATCH 10/17] delta: Fix buffer overrun in delta_ipc_open
Message-ID: <20190401165400.pdp547zqwdojz67r@two.firstfloor.org>
References: <20190321220009.29334-1-andi@firstfloor.org>
 <20190321220009.29334-11-andi@firstfloor.org>
 <bb7d9aeb-9cde-92c6-cbd1-c0ba3d283f07@st.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bb7d9aeb-9cde-92c6-cbd1-c0ba3d283f07@st.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 01, 2019 at 01:37:56PM +0000, Hugues FRUCHET wrote:
> Hi Andi,
> 
> We have already discussed about that here:
> https://lore.kernel.org/patchwork/patch/866406/
> 
> Now that strscpy is largely deployed within kernel, could you retest 
> with the change I suggested ?

strscpy is not the correct fix because it leaks uninitialized memory
to the receiver.  You need the memset.

-Andi