Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp479426yba; Mon, 1 Apr 2019 10:07:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqxMhMLHizLJmlZf0NII14CuW7uDMOoczZQ5l9qnA0K5OnQ34wftle5rUOVegChYKIwjvQw8 X-Received: by 2002:a62:5f84:: with SMTP id t126mr33772368pfb.185.1554138454054; Mon, 01 Apr 2019 10:07:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554138454; cv=none; d=google.com; s=arc-20160816; b=RymCytbXkPPFhiYzpRN/dhhhDz7nIqd7Xp5jJpF6tgGYFjojgMfzFK5HynDLTQWiLl 1ihcpB8AADX4zUR8e8dP29bmhyzaqCQLrQbzTBnwryehn/iU1xq0ggOVeW5XsDfNLRMo +gNR+qctDKezSFrb1sFqpR0p/nvTOJIarYQ5uki9XSVqy2kaFb6poceTud6qobnmTX5Z UnPLCL6orVmbotVJvLKYdGmLuixVj4dpeA7Jftz43um2Vmf4m+8zHoQRWq6HiYxQ4Z2o iqNOANlUkNK7zCgw0mPhrSZj4R9gtYM5tsNhAzZmSnbwKmhbZyZp800jOGKZSX61UYMF jcug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZnE1ZXgUtOPLRzNx7xhNOc4d7LDSfGqXxOv5GqWUP20=; b=bzKBZ5w2+BUN/HmPz3WBuJkfvNwVw4813GEKA0h26f2he/aRy5Q4AK/XD+HusrVjta hhw7uaJbvmsRsnCh3jbBW+32MLL+iDXf5jo92/IQxSx8cHvvAGp7qHYjnDgYwAEnHqPD +VLzCHYhs9P5OhvkuqtPwBg3jG2CnsCVBozOS7AzXPVJEkVNk5UoQwcbywSzcq72yl64 0i8RMG7Zq1a8+i1we784oCuEPZPESrCuSMqagly2fLOjDHilEwesS5uNGyV2SsIuV8ov e/cxnZiHX/HQFhp41+SD4bLYTEF03EiLJI3LAxCBvRe6UHwHkp0jwgsEBuoVFfEVSKdT uu8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nRuIwKct; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z4si9101567plo.166.2019.04.01.10.07.18; Mon, 01 Apr 2019 10:07:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nRuIwKct; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729159AbfDARGI (ORCPT + 99 others); Mon, 1 Apr 2019 13:06:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:51548 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729068AbfDARGH (ORCPT ); Mon, 1 Apr 2019 13:06:07 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3DB3B21925; Mon, 1 Apr 2019 17:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554138366; bh=GRRBHM7wfPZeNyQS1sUyaUM+bSWW64L009aIfds/6iI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nRuIwKctl4O3xg2ZxbgSMlrhkgwQypUrk2Y8qjXPti1Dt27lGSRuCYXzXvzTTgfQS /PD9vRA67SQHynY3sGq0jCwzxoFSwxSk+jBLxeQJ/Mou+RYxpgdp0gn8gYtgwqTl8r R4RHM2jToKi64dMOppFBvX3TyT6kox1YRfi7vZyg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Igor Russkikh , Nikita Danilov , Dmitry Bogdanov , "David S. Miller" Subject: [PATCH 5.0 010/146] net: aquantia: fix rx checksum offload for UDP/TCP over IPv6 Date: Mon, 1 Apr 2019 19:00:22 +0200 Message-Id: <20190401170049.307853928@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190401170048.449559024@linuxfoundation.org> References: <20190401170048.449559024@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 5.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dmitry Bogdanov [ Upstream commit a7faaa0c5dc7d091cc9f72b870d7edcdd6f43f12 ] TCP/UDP checksum validity was propagated to skb only if IP checksum is valid. But for IPv6 there is no validity as there is no checksum in IPv6. This patch propagates TCP/UDP checksum validity regardless of IP checksum. Fixes: 018423e90bee ("net: ethernet: aquantia: Add ring support code") Signed-off-by: Igor Russkikh Signed-off-by: Nikita Danilov Signed-off-by: Dmitry Bogdanov Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c @@ -186,11 +186,12 @@ static void aq_rx_checksum(struct aq_rin } if (buff->is_ip_cso) { __skb_incr_checksum_unnecessary(skb); - if (buff->is_udp_cso || buff->is_tcp_cso) - __skb_incr_checksum_unnecessary(skb); } else { skb->ip_summed = CHECKSUM_NONE; } + + if (buff->is_udp_cso || buff->is_tcp_cso) + __skb_incr_checksum_unnecessary(skb); } #define AQ_SKB_ALIGN SKB_DATA_ALIGN(sizeof(struct skb_shared_info))