Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp492700yba; Mon, 1 Apr 2019 10:23:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqxPWNuC+VlFGreWgeM/ty0K8IzY9hzHx+cBeZR5IqttZ5BBVJrEeM8b0bPafE7+OtPSz503 X-Received: by 2002:a62:e80f:: with SMTP id c15mr63041318pfi.93.1554139392377; Mon, 01 Apr 2019 10:23:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554139392; cv=none; d=google.com; s=arc-20160816; b=CmyF/sIACUYu1hMl6tXdHzX67alvw0DcinY7NCk+eX//tVN6oPEPVpv1oIuDSPuWL3 tpZcMwz01FuvD5jdH/oV5eLzxq6zwtA3aK9cYhQjtw9rid1phr3DYB322RSE0v83FcLw EOdkfSHV6lP1Tdjb0DtYfAXV7preQ68Y124CDMKN1PhpPgZjCaB7jErsCMzraM1VSh/I 2vVnzy2Xr51Wz8J9kOq7p/MNuS5dkEWufZyPWKvw6Mqu2FNGos9FZ5kN5IYQFRX4T9qB TsS0yAK6dX66GtuzHQNkp2jKX4aR3jaKqF/JLzpz5EytKObvdbEpG8mT2GKgyrpR9p/0 gWYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Oy+Ogza2ghciwxG2LJ+QKHgDq/LP4oV+eClFWocEcbU=; b=Xi1SFSToVO09W1pTWovUQr4C6GKwWsCOseyQfEOHBuoIUW84XQk8MYsXFnb8fY2BC1 RO0Yh6yCC63IqbKBBUgubsgBEiwAbqkPtLt0uK6XnVTYtTuGQPssB2+FNJICEx1BS6Zx RAYMkpSyD72n9381kjFnIff3Rts2kMkEA7GkaGk4enTnIVUojRsex2fmptpujffxk8BI XA5+8XPtlJ3qZzsjJWOedNXbzLemeo2nlxZFjZxERH4drDs+wezyITl/rYwH7kW5ImMU jburXtHfJ0s+/6KX6AyUEBOVa2v/uLgp5LewfH+HH1UpVbIQzG68Xjiqd9dw+QMBC/a0 Y6pA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bi40GqH2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q1si4947066pgh.396.2019.04.01.10.22.57; Mon, 01 Apr 2019 10:23:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bi40GqH2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731712AbfDARU4 (ORCPT + 99 others); Mon, 1 Apr 2019 13:20:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:49174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731476AbfDARUt (ORCPT ); Mon, 1 Apr 2019 13:20:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B236206C0; Mon, 1 Apr 2019 17:20:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554139248; bh=qh9dSC56sTBbu3I7G7fC3iNgW0WaZfMsaVebcT9ZKZg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bi40GqH26t2n2WKmK35jaW07xTBL8NCOvttp81LQEs3q5XtnFHVCBx4fj2EmFt/p8 xO03fu/O8LkfGwaVviHFBCRkUyXCHIPXKWCNWlcQSWE9l2GQkXGmi9vKQxz91xtTeF is8O1/k+xTmGIWNPSZ3yWOQ75f/IKV/PA8bZbo1Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Igor Russkikh , Nikita Danilov , Dmitry Bogdanov , "David S. Miller" Subject: [PATCH 4.14 020/107] net: aquantia: fix rx checksum offload for UDP/TCP over IPv6 Date: Mon, 1 Apr 2019 19:01:35 +0200 Message-Id: <20190401170047.388409841@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190401170045.246405031@linuxfoundation.org> References: <20190401170045.246405031@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dmitry Bogdanov [ Upstream commit a7faaa0c5dc7d091cc9f72b870d7edcdd6f43f12 ] TCP/UDP checksum validity was propagated to skb only if IP checksum is valid. But for IPv6 there is no validity as there is no checksum in IPv6. This patch propagates TCP/UDP checksum validity regardless of IP checksum. Fixes: 018423e90bee ("net: ethernet: aquantia: Add ring support code") Signed-off-by: Igor Russkikh Signed-off-by: Nikita Danilov Signed-off-by: Dmitry Bogdanov Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c @@ -270,11 +270,12 @@ int aq_ring_rx_clean(struct aq_ring_s *s } else { if (buff->is_ip_cso) { __skb_incr_checksum_unnecessary(skb); - if (buff->is_udp_cso || buff->is_tcp_cso) - __skb_incr_checksum_unnecessary(skb); } else { skb->ip_summed = CHECKSUM_NONE; } + + if (buff->is_udp_cso || buff->is_tcp_cso) + __skb_incr_checksum_unnecessary(skb); } skb_set_hash(skb, buff->rss_hash,