Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp504213yba; Mon, 1 Apr 2019 10:37:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqzeeKKwzUd/ahuPicYl5wv7EdReYLQublDkU5C/LEd2RQdkWB2CuB55ST9uqAh4dGPHoR61 X-Received: by 2002:a63:6903:: with SMTP id e3mr62298974pgc.147.1554140226096; Mon, 01 Apr 2019 10:37:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554140226; cv=none; d=google.com; s=arc-20160816; b=ORMn5V9j1rsvkeo5xTShMSXX+KtBnXPG8TR+PdmeW7FundZfp3pulW/Z34PKo0W5NB L05aDO2fINvtpL0C83j0aMcu0WCO9X6YtyQPfOdy1yteEYO8vN2UgcP8d/oCYRa77eVH 2YWUS6OZvQBp1Ioaof71THKKOjULVssQX1gB/5O/kBwuZ63Usx84iiXy2IKMkaWUpRc7 cIdQ0/ZXivAIdM65/toMjqJ7t5xm7imj9mwq0f1HOebF+9moPHNTAQqwSawsUh9nA+DJ yglfWwuhiHiHyDFogp87P6JX9Fcs8A849M++WMg3fcMVyBq58Mhg5uaes3TBp80kxQ52 208Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=AORDfwEse65/Dxrs3UywPXiEP4Uh82Lkr0DHUi1vMS8=; b=u2tkur7Qz3Xpp9WbcP4XzcIu3g5U5Z7pak4cnmgKjx51XniA++eX/LboHyfcLEnrcH k4wchFgF4cCrGkiYCjZ2vWg4FcX6tiQRuiUQeESz77Pyrwu+YYXVzSqSe/1ry9RNJZvV 4vE3cOielilHHp1QG+wC0DxVUapxYcItNDs6HNVz3nEHp3CQt7jXemoJmynmbHoGqQQB CkXnV0zstV1yVpq0d1psQIzmjifaYciLSi3PjYwzln3yQKsO/QZABvSzazbTla7xFPk4 gnfPZEjn5cHBo17j5/5Qo0WbYesefI5m67tZm8W5JSrhUeRSMULI4RXgNQeh+Lzdppro xRHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mUxJ0zs4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q12si9646851pgh.594.2019.04.01.10.36.51; Mon, 01 Apr 2019 10:37:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mUxJ0zs4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388011AbfDARgL (ORCPT + 99 others); Mon, 1 Apr 2019 13:36:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:47602 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387990AbfDARgK (ORCPT ); Mon, 1 Apr 2019 13:36:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7EA682146E; Mon, 1 Apr 2019 17:36:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554140170; bh=1TAPsBCWrbQVTp+NlMn6q5zWWJRqzuSCWMW+RhwAvpo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mUxJ0zs4eLsuVEJgrcDBoep/p7oTXkSP45xkSSAuWOu1ULi8q+szZf92IjG85rvAs LBhEdYKS+12jIGz2QaOln5lkKswMpON1hIWGE++O3AlZ3Vg6irWEe0Eahrp9Xv8MLc pKh9WwP35FmgcHOKDaI/dSLQfvpF+GSFVTJ9z78U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chaotian Jing , Ulf Hansson , Sasha Levin Subject: [PATCH 4.4 087/131] mmc: mmc: fix switch timeout issue caused by jiffies precision Date: Mon, 1 Apr 2019 19:02:37 +0200 Message-Id: <20190401170059.312627080@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190401170051.645954551@linuxfoundation.org> References: <20190401170051.645954551@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 987aa5f8059613bf85cbb6f64ffbd34f5cb7a9d1 ] with CONFIG_HZ=100, the precision of jiffies is 10ms, and the generic_cmd6_time of some card is also 10ms. then, may be current time is only 5ms, but already timed out caused by jiffies precision. Signed-off-by: Chaotian Jing Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/core/mmc_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c index 1f444269ebbe..76b49b9772d0 100644 --- a/drivers/mmc/core/mmc_ops.c +++ b/drivers/mmc/core/mmc_ops.c @@ -542,7 +542,7 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value, timeout_ms = MMC_OPS_TIMEOUT_MS; /* Must check status to be sure of no errors. */ - timeout = jiffies + msecs_to_jiffies(timeout_ms); + timeout = jiffies + msecs_to_jiffies(timeout_ms) + 1; do { if (send_status) { err = __mmc_send_status(card, &status, ignore_crc); -- 2.19.1