Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp516624yba; Mon, 1 Apr 2019 10:52:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqxGweCvUvNuU6IIPLOoaUOPYa6qJVTwK8lgxjsaVU5HZ27Khk0S4bb6QmY8jpFqGMKaWVUw X-Received: by 2002:a63:fb16:: with SMTP id o22mr60533003pgh.209.1554141171870; Mon, 01 Apr 2019 10:52:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554141171; cv=none; d=google.com; s=arc-20160816; b=ikjg6cQuCn774bCqzDk+CL1j8RiTIQDJPfdZrPqc45iqtWWFgHPd1j2XQeojhB00AA Y8QI74AdntQX31K5vqWWxAYmkstXKUAIpohbKviCdZadhz2G71PAql0Bt2ZyPL499wd2 bIsdRVUEVpeLltc89U9LpS7De+ofcQE4eRVkT+yXMY20jHgH8Nmu2WIGx2Gf6D24lWYa nH7DwsZGqYbbWu6q8ahAgLjrnffWHZ3wM2K8nfc6/V1fTgxeUScYHO28lzIjkq5Wi96X YcnaVsw+vGiOiHYnlYH7jZsCoqbOlt3hRnlHgnEfnfuzoD7HoT6IO2qOCXVjqPRUBi8Z ujiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=PHMeePNk5+WqIP9bn6Ly7V2tLpJ0ch+LgEkGb4MdyLk=; b=MvEkYU3yIsA0biN5nql/jQBwA91E1124mv34LXm/GYlW00v1rQoeToXs0SZpl+e/aD /O4NOfwsET+ad/2MzdKsOpA87+KZnKJpZRCQRxRUcUehEzK7+hoVugRbEuDCKyxJrGaH N063WN82tejL9BBfncYOHwd88lIwcvnJlszWsrNXWcBZiNq3kVHPCAvdXmH8AI0R2arg yUaFbrCQWqqi2Sz2zSetTtly13EJPwGWCKakT81Rf5tlkuiYxs/SyrHJkPpeMBEQafW7 hZxsU9caq8A8Z/njezjKuk+qKb/SG4gQO2mnbGTW+tupJd4DqQChMilteUE7wGERWeYm 8snQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=BTqw7lO5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i195si9342661pgd.521.2019.04.01.10.52.36; Mon, 01 Apr 2019 10:52:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=BTqw7lO5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731351AbfDARwB (ORCPT + 99 others); Mon, 1 Apr 2019 13:52:01 -0400 Received: from mail-lf1-f46.google.com ([209.85.167.46]:43212 "EHLO mail-lf1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729565AbfDARv7 (ORCPT ); Mon, 1 Apr 2019 13:51:59 -0400 Received: by mail-lf1-f46.google.com with SMTP id g7so6931274lfh.10 for ; Mon, 01 Apr 2019 10:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=PHMeePNk5+WqIP9bn6Ly7V2tLpJ0ch+LgEkGb4MdyLk=; b=BTqw7lO5Xbdw7L1gGrjWfzTyh1Ekkfz4Gc6wDzzinjrCDP1+luYqbVnMNflJqqnDtA xcdigwvpgyhnqYJ/Klzenr7m04aoLdciK90EWH6zC8c4knB44hTOmuVt/cr0vAtCqJwh BMYqYQa0HJwmXd0frGFAdPacmKjV2q+LYfSck= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=PHMeePNk5+WqIP9bn6Ly7V2tLpJ0ch+LgEkGb4MdyLk=; b=pBsusxLpWlxFbmUuXbN5q2kQhAqmZFUsiTeX1MWUtR4h8++3VMwkGFjsGRFmF1Nr/E a4gzEsihkqk+ChCFbK3FmJlzehuz3/Z0kirwNaFHDGhB5HjyVRCZ2YuXJRpmxpwSsQ5W p6dFyj7wKvdQVwI3HGjimFXOYa+nm/AStvQf5OB2wu6h45uBoWCZyBDcgB6woU1qSOgR 7Sg6DkqqsOuURkilaI58YFUy2PYjNcylHG8b9fpHUfANRzl1U3u9ScVrz4zag6yDd0ek hm1Hc4AoJQdI0+y37YdYLaphxG10wdM53MsniimKY2amsJ3a75+5osN9igCKsMZD644U G8gA== X-Gm-Message-State: APjAAAXItNdO9k41ZQ157l1nbm6W3goWzoNB6pnNjgEhyX9Z1TgKvHPS Ki87Kg0vQRTiQyoBTczaUfE2aBgvENg= X-Received: by 2002:a19:ab1a:: with SMTP id u26mr34926138lfe.65.1554141116342; Mon, 01 Apr 2019 10:51:56 -0700 (PDT) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com. [209.85.167.49]) by smtp.gmail.com with ESMTPSA id f1sm2239261ljf.40.2019.04.01.10.51.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Apr 2019 10:51:55 -0700 (PDT) Received: by mail-lf1-f49.google.com with SMTP id v14so6961813lfi.0 for ; Mon, 01 Apr 2019 10:51:55 -0700 (PDT) X-Received: by 2002:a19:9145:: with SMTP id y5mr35643508lfj.35.1554141115065; Mon, 01 Apr 2019 10:51:55 -0700 (PDT) MIME-Version: 1.0 References: <20190331230940.GA30957@mit.edu> In-Reply-To: <20190331230940.GA30957@mit.edu> From: Linus Torvalds Date: Mon, 1 Apr 2019 10:51:39 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: How to add Unicode character tables to the kernel? To: "Theodore Ts'o" , Linus Torvalds , Linux List Kernel Mailing , Gabriel Krisman Bertazi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 31, 2019 at 4:09 PM Theodore Ts'o wrote: > > The question is how to do this, with different tradeoffs. One is to > simply include a utf8data.h file, which will be 320k. That might > sound large, but in fs/nls there are 3544k worth of similar files. > Some are relatively small --- only 16k. But others are quite large > --- 480k to 856k. The table for Chinese character set is such an > example. So in comparison, the 320k size of utf8data.h is quite > compact. > > The problem with this solution is that the files in fs/nls, and the > proposed utf8data.h, are generated files. Oh, we definitely don't want to copy the original huge tables, and we don't even *want* people to edit those things in the first place. So generated files are fine. It's not like the source data isn't public, and yes, the commit message should have a pointer to it and how to get the source and the generated files. But no, we shouldn't feel like we should encourage people to be able to generate their own modified unicode tables. Linus