Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp517131yba; Mon, 1 Apr 2019 10:53:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqxOgB08VNQSbCgPOQruDjoxCv19N16UAkVpESrEzrsaQwNIJ5/Y00P/Ci7iGJXi2QTis983 X-Received: by 2002:a62:e816:: with SMTP id c22mr21334087pfi.54.1554141204945; Mon, 01 Apr 2019 10:53:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554141204; cv=none; d=google.com; s=arc-20160816; b=NR+LmuaJ16WHFa7kWEdaZbHfsJ05U6gn7mhq6jGr04sZxSHptRK5AmvEA452bb6D6a rC8ff6tg4W7JmY3y15eIc5ydma+/QePyb81r3mYGNfi1fYyZ/PlbFo70Q+JxebowLTJo JzMlF28QFGGDG2/9Onq+HFDJCbTqBOi37mQtfiL6O84O96xRS0JSIBxZSQUb6dvr9Afh bm++lqDxsV8rAJFrpfqc02CCbmKrI5o8XD2R8GnMwMugwg9RSQrnGW14EnjnG2NcDWkO 0IYg9RVjrSMv+TQd1X/NU+SG5T17pe6wi8SuuUUd+ufmh3nwEKz4tE0UqGyGfKwh0laS oOFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from; bh=wCycQG8ZyJkJydcO0rfqZrRzazkgidJ4bSR4yrkaNlQ=; b=hbRooXqxMD1x6p2XvlbUhJ12blPkdbK3bQMUFO6whxf6zngB/ahB0Aj4IKQ7Bmy+g+ dTiz/3d2wjXdnx4sJKuRhq16IiqjhXRMa6hipDfC9hpnv2ZeKixsPi2cIBMQC56Q2hiD y5I54NN0VfI1LUquVXvwts8Tc+lLlh6uGGLmR2Mbi83crc0F8gQ2V0q91T865cLR2P5Q R+wTysWQXIsoVQq1Fnl9xrfjnhFmDGdYZfkUhqctfrOVbfRMFhYJNaDpnByrBuk2W/wd zGQvxqNj4RilZJXTBbw9o9eXNGu/37wpXEoLvLFzJhyaK5wA/qMJLE91XSlbopgS+Y+K uh6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j7si5206382pfb.75.2019.04.01.10.53.09; Mon, 01 Apr 2019 10:53:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732775AbfDARwg (ORCPT + 99 others); Mon, 1 Apr 2019 13:52:36 -0400 Received: from anholt.net ([50.246.234.109]:46758 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732284AbfDARwe (ORCPT ); Mon, 1 Apr 2019 13:52:34 -0400 Received: from localhost (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 2AE4E10A0220; Mon, 1 Apr 2019 10:52:34 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at anholt.net Received: from anholt.net ([127.0.0.1]) by localhost (kingsolver.anholt.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id al1mPtCC0dIY; Mon, 1 Apr 2019 10:52:32 -0700 (PDT) Received: from eliezer.anholt.net (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id CC6D010A280C; Mon, 1 Apr 2019 10:52:32 -0700 (PDT) Received: by eliezer.anholt.net (Postfix, from userid 1000) id 5DE9E2FE33BA; Mon, 1 Apr 2019 10:52:32 -0700 (PDT) From: Eric Anholt To: Paul Kocialkowski , dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Maxime Ripard Subject: Re: [PATCH 1/7] drm: Add a helper function for printing a debugfs_regset32. In-Reply-To: <14f34f5ce32ca4943aec42e32878d6dcc7ea5524.camel@bootlin.com> References: <20190220210343.28157-1-eric@anholt.net> <14f34f5ce32ca4943aec42e32878d6dcc7ea5524.camel@bootlin.com> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Mon, 01 Apr 2019 10:52:31 -0700 Message-ID: <8736n11ulc.fsf@anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Paul Kocialkowski writes: > Hi, > > Le mercredi 20 f=C3=A9vrier 2019 =C3=A0 13:03 -0800, Eric Anholt a =C3=A9= crit : >> The debugfs_regset32 is nice to use for reducing boilerplate in >> dumping a bunch of regs in debugfs, but we also want to be able to >> print to dmesg them at runtime for driver debugging. drm_printer lets >> us format debugfs and the printk the same way. > > Looks good to me! > > Reviewed-by: Paul Kocialkowski Thanks! Merged all but patch 3 (unreviewed) and patch 5 (needs patch 3 to avoid oopsing). Sending out a rebased version shortly. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlyiT+AACgkQtdYpNtH8 nuh5mA//WrE5t0tlFG7qvNZARAuvvMlGUADM7MES8TIJlopJ7P91N4sCbMXTi2yX 746ICu6HCmCALJ0ggdvJmqBWelh1EAoTvCbU8eZMi2447ZjXtJpULCOtpQF2EunC svt0sFZZRJOg8yVQ7HLNIdyinlSIJIFLG6tIetX/1A3qJU6SeeZLWhu+nlmZ2Gu2 vO3Rljcn0B/O1DhxNX2IjH2W+6jCQ2aV3r/VCZyuafc6uVhr9bOQwoSVW/nPiKpf dufTMPcjQ6VGQ47/f047bC9/G5pMkqhaV93LkDC2nzrQ3JHUkhN4S8Q9xmkaK5/n 3dr7lcfqdzZ6niQVnBdZXVzfpqYZqnbZf42+TaBs9/WiaYtQLnOHqTaANIhCzqlz teYhMXEiTINz1rXeqjLJji0QP/d3MFmOG/2wC3SIcyL19a7qmPKbfChlOKWtYdLW SNGDt1iEjkpXmwFKovHnBevuKOzpCOuDaEZlMH0piobLutAS5EuGKuz9OeihuuFP JPtrqVH0agnlifApkkIhwossdErtNAVdO2YCl24sE8BG/NHACm7CuwB6Kv7995kr yctuFsrXI54SNXQQGSlSSZJ++BS+fUXRBXRcs4V4OqlwoNjbumJPyRnTNHA7Wuhm RTcqSPOuEBczw45gG8ayJ5ruNPSEbKjdrWhengpOGXBuWPBkrpQ= =Z28W -----END PGP SIGNATURE----- --=-=-=--