Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp523528yba; Mon, 1 Apr 2019 11:02:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqwvYTuwOt6pYOelYmTZxBhO+IYGK6deHWLFrDBowr5dBRHsBViBitFUcKkXCisHP147O8Rn X-Received: by 2002:a17:902:7c8a:: with SMTP id y10mr24715690pll.232.1554141725711; Mon, 01 Apr 2019 11:02:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554141725; cv=none; d=google.com; s=arc-20160816; b=LrypgODtFLi/H7S71aw7ipgwbqMd8jo/87LshxzQ2tpq9K8rBmwtbxbvqRGgxT4FFu YMdSCxQBrnikkiMSwlaDKSU1wVJ6CUzdouStGlau8rZ3HaD+Z52xUKoOn+ae9LMDEuN0 bvNwsyrBT9T93+jJOhTQgUC1MZV0PhdimCVsDZ28uhg4nA8tLOPPQcSLh0DuPAat5cDR WDGqdHzFFrQSH4eC5qx9J8L8JcT88994cj+iH3Iq6qFvwq8wpXUPoOQXUoLyf8WCioUB KmZ7ztHzIFA02bpfxM9/ARuRXfjfqZg0g3VoPiYx4K5xpQf7/eWwbcaKXrNybynxCEq7 hUmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=vrfaVAR77+psi9w7tcxderhXdwSrDPUE9VE1kKzy26E=; b=1FUpqhXhJtkgYlrAtLMe5oUnSYqy7yZoslutQB9B/veXuHcpGZUvNapGGnlWdcMmsj kRPjGdilNFAMsLXFw5Vvkcv2PEcdjwH8Fvx/vP27LB4YOx75wLDvZJWPy7Wi34lcsiGV pvILgXoS4I41hs3ZVXccSR6DrlAnJJu7L61R7U19B5TK55QrcP27tbX3prs89j4ny12k 6lndIF8CpzR8ZWfcvvLVtfU5nGUIqIhuHgjf4Mkxc+ilHc28taJO9VED27pJhswNXPgk FXN9pA0u4X8MXLsDuk7e/ofWZhUS47VbOf/HZRv1+cKe30Do05GDu4omUk8EtSNb/brw R4KQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LLuJr46N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 12si1483741pgn.67.2019.04.01.11.01.49; Mon, 01 Apr 2019 11:02:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LLuJr46N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731084AbfDARQx (ORCPT + 99 others); Mon, 1 Apr 2019 13:16:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:42368 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730894AbfDARQv (ORCPT ); Mon, 1 Apr 2019 13:16:51 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EBF6120856; Mon, 1 Apr 2019 17:16:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554139010; bh=7NqkNI4AcQpNFXY3aakXB5bpLZ6h6NJGrmyBj3btLB0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LLuJr46NLoaVlNqAgrgM4xGIghhn2jGu1yk6n/GLOlBW52P222tdFmFiLNJ+8DdJ2 73amY36qAlRQjoe+6oygYQixSrVIlFgOdGFJXatH+YlK7W6L7JVtvny1xS8ra+e/fp x/jVtgeW37hWVg8AOwq0dWYcA8gaUUiVvIHEgLAo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aditya Pakki Subject: [PATCH 4.19 087/134] serial: mvebu-uart: Fix to avoid a potential NULL pointer dereference Date: Mon, 1 Apr 2019 19:02:03 +0200 Message-Id: <20190401170052.427588347@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190401170044.243719205@linuxfoundation.org> References: <20190401170044.243719205@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Aditya Pakki commit 32f47179833b63de72427131169809065db6745e upstream. of_match_device on failure to find a matching device can return a NULL pointer. The patch checks for such a scenrio and passes the error upstream. Signed-off-by: Aditya Pakki Cc: stable Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/mvebu-uart.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/tty/serial/mvebu-uart.c +++ b/drivers/tty/serial/mvebu-uart.c @@ -799,6 +799,9 @@ static int mvebu_uart_probe(struct platf return -EINVAL; } + if (!match) + return -ENODEV; + /* Assume that all UART ports have a DT alias or none has */ id = of_alias_get_id(pdev->dev.of_node, "serial"); if (!pdev->dev.of_node || id < 0)