Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp523762yba; Mon, 1 Apr 2019 11:02:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqzFurN67nAwb3sZzRd4O3Eh253XZCwkryNDemhTCvBgizL4Z4s7i2qOgaQZBi44JFJpiHKw X-Received: by 2002:a63:2f44:: with SMTP id v65mr61438748pgv.141.1554141741757; Mon, 01 Apr 2019 11:02:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554141741; cv=none; d=google.com; s=arc-20160816; b=WC9ipAzg2FAayl5OV+2vXzWATH2qFG41naXNoOiGK+qL7KccGjOzNZyXy4s6zTRcEV XKa2N0ReuKaivMOC7oZrbRDIqijruOtQ+wG7LjF7J793lM5DMfyTED5JmThzW/P86mgP 4qc+uUp8o3pxZzWx+rgXOlLdD4M2qiBkedpPbG/RZoRZmhk2y2/SwEKG5/HYjXjdVm8B EBpEPm0ozTcTuIPGsXjXOduudsWyp/VwXoZT8Zpk6CzDMAuxCW2u7T7mlyth0uecGhaa Nxa0DZWCb+Btr+mPcmWjK8GvEZu5dgzNUDrhbv8KpuGI39/w1VfUQX9kukwuCxWQqUkt +D6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=P23hv1QiMIB8Uz29l6IfIixVWu+l6NsiC6Sct8W2XpI=; b=LSkCLy/yqM6mDV7Eq0sXURJoLy5l//JbQDG6VmxFYnGZlSWwQMhJ03StNdKL9PV75d RY/hl84u/ipkglfbxdgxHZIGXG73jPTcc0mYKlYd9mCSZUGtDuG7Qj8a1QHG/ZY9QCWl 0YGHmrl0BOWW2tNIb6xVKoyvPFCtssApjIojMnMK3ujvmEBOOFGjJQ07y3TsRDZkpk6y sMmVYJYvATBj28JXDH6oQ6eQG6gFTrH+oX3cOoNADSf4SD2redPsFuuHgoNXBsf0yj6a oLPLjEx+fgfNVT3QPf43Cx4+9AnR28ZUO+uJREdvopyBSBzzHL0568/qxs+OMvYiJPTQ S82w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rDrfdJjv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g8si9120881pgq.159.2019.04.01.11.02.05; Mon, 01 Apr 2019 11:02:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rDrfdJjv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730536AbfDARQG (ORCPT + 99 others); Mon, 1 Apr 2019 13:16:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:40776 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730962AbfDARQA (ORCPT ); Mon, 1 Apr 2019 13:16:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 662EE206C0; Mon, 1 Apr 2019 17:15:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554138959; bh=sl3yInsOSfGs0C6ydbuAmL/T5RO5dhFVwkIH51u0EiI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rDrfdJjvHHBmwvX31SWZeGWIV9Y4bwkDZnGHLctOi7ZNSw/UZjpfLeqCVHolPUsuC liYKz0McerTwE/ew+MiGT0ybFpCjx/2qnTEpnuClS0wUIkk1xCb4dk6d2/piWpYR/1 FGTqUJHe6N7cueFIpO8RuZITC9Goki/3Re+tpHM8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bernhard Rosenkraenzer , Takashi Iwai Subject: [PATCH 4.19 069/134] ALSA: hda/realtek - Fix speakers on Acer Predator Helios 500 Ryzen laptops Date: Mon, 1 Apr 2019 19:01:45 +0200 Message-Id: <20190401170050.912818366@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190401170044.243719205@linuxfoundation.org> References: <20190401170044.243719205@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bernhard Rosenkraenzer commit e2a829b3da01b9b32c4d0291d042b8a6e2a98ca3 upstream. On an Acer Predator Helios 500 (Ryzen version), the laptop's speakers don't work out of the box. The problem can be worked around with hdajackretask, remapping the "Black Headphone, Right side" pin (0x21) to the Internal speaker. This patch adds a quirk to change this mapping by default. [ corrected ALC299_FIXUP_PREDATOR_SPK definition and adapted for the latest tree by tiwai ] Signed-off-by: Bernhard Rosenkraenzer Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_realtek.c | 10 ++++++++++ 1 file changed, 10 insertions(+) --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5618,6 +5618,7 @@ enum { ALC225_FIXUP_WYSE_DISABLE_MIC_VREF, ALC286_FIXUP_ACER_AIO_HEADSET_MIC, ALC256_FIXUP_ASUS_MIC_NO_PRESENCE, + ALC299_FIXUP_PREDATOR_SPK, }; static const struct hda_fixup alc269_fixups[] = { @@ -6613,6 +6614,13 @@ static const struct hda_fixup alc269_fix .chained = true, .chain_id = ALC256_FIXUP_ASUS_HEADSET_MODE }, + [ALC299_FIXUP_PREDATOR_SPK] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x21, 0x90170150 }, /* use as headset mic, without its own jack detect */ + { } + } + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -6631,6 +6639,7 @@ static const struct snd_pci_quirk alc269 SND_PCI_QUIRK(0x1025, 0x106d, "Acer Cloudbook 14", ALC283_FIXUP_CHROME_BOOK), SND_PCI_QUIRK(0x1025, 0x1099, "Acer Aspire E5-523G", ALC255_FIXUP_ACER_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1025, 0x110e, "Acer Aspire ES1-432", ALC255_FIXUP_ACER_MIC_NO_PRESENCE), + SND_PCI_QUIRK(0x1025, 0x1246, "Acer Predator Helios 500", ALC299_FIXUP_PREDATOR_SPK), SND_PCI_QUIRK(0x1025, 0x128f, "Acer Veriton Z6860G", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), SND_PCI_QUIRK(0x1025, 0x1290, "Acer Veriton Z4860G", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), SND_PCI_QUIRK(0x1025, 0x1291, "Acer Veriton Z4660G", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), @@ -7027,6 +7036,7 @@ static const struct hda_model_fixup alc2 {.id = ALC255_FIXUP_DUMMY_LINEOUT_VERB, .name = "alc255-dummy-lineout"}, {.id = ALC255_FIXUP_DELL_HEADSET_MIC, .name = "alc255-dell-headset"}, {.id = ALC295_FIXUP_HP_X360, .name = "alc295-hp-x360"}, + {.id = ALC299_FIXUP_PREDATOR_SPK, .name = "predator-spk"}, {} }; #define ALC225_STANDARD_PINS \