Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Vineet Gupta <vineet.gupta1@synopsys.com>
To:     David Laight <David.Laight@ACULAB.COM>,
        "'gregkh@linuxfoundation.org'" <gregkh@linuxfoundation.org>,
        Andrey Abramov <st5pub@yandex.ru>
CC:     George Spelvin <lkml@sdf.org>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
        "benh@kernel.crashing.org" <benh@kernel.crashing.org>,
        "bp@alien8.de" <bp@alien8.de>,
        "darrick.wong@oracle.com" <darrick.wong@oracle.com>,
        "dchinner@redhat.com" <dchinner@redhat.com>,
        "dedekind1@gmail.com" <dedekind1@gmail.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "jlbec@evilplan.org" <jlbec@evilplan.org>,
        "jpoimboe@redhat.com" <jpoimboe@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-snps-arc@lists.infradead.org" 
        <linux-snps-arc@lists.infradead.org>,
        "mark@fasheh.com" <mark@fasheh.com>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "mpe@ellerman.id.au" <mpe@ellerman.id.au>,
        "naveen.n.rao@linux.vnet.ibm.com" <naveen.n.rao@linux.vnet.ibm.com>,
        "paulus@samba.org" <paulus@samba.org>,
        "richard@nod.at" <richard@nod.at>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "vgupta@synopsys.com" <vineet.gupta1@synopsys.com>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH 5/5] Lib: sort.h: replace int size with size_t size in
 the swap function
Thread-Topic: [PATCH 5/5] Lib: sort.h: replace int size with size_t size in
 the swap function
Thread-Index: AQHU6JnBsi9jfaw2oEibJh5UEx7dnA==
Date:   Mon, 1 Apr 2019 18:01:51 +0000
Message-ID: <C2D7FE5348E1B147BCA15975FBA23075014643F9DF@US01WEMBX2.internal.synopsys.com>
References: <18626931553963861@sas1-b3ec53dbc12b.qloud-c.yandex.net>
 <20467491553964233@myt4-c0b480c282c8.qloud-c.yandex.net>
 <20190330183826.GB21828@kroah.com> <201903302015.x2UKFnSL003850@sdf.org>
 <20434561554015618@myt1-cd60b8ae9bb9.qloud-c.yandex.net>
 <20190331105412.GA9393@kroah.com>
 <cd57af9a2c1e494cbc8631a0347831dc@AcuMS.aculab.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 4/1/19 7:46 AM, David Laight wrote:=0A=
> From: gregkh@linuxfoundation.org=0A=
>> Sent: 31 March 2019 11:54=0A=
> ...=0A=
>> Yes, "int" is a very nice variable for "size", you need to explain why=
=0A=
>> it is better to use size_t here please.=0A=
> Actually, on x86_64 you probably want 'unsigned int' to avoid the=0A=
> compiler having to generate a sign-extending register move if the=0A=
> value is ever used in a 64bit expression (eg an address calculation).=0A=
=0A=
Thats likely true for non x86 arches too (for certain on ARC). That is also=
 the=0A=
reason I dislike "bool", despite its "software engineering" benefits. Per A=
RC ABI=0A=
(and likely others too) it is signed 8 bits and any use thereof, requires t=
he=0A=
compiler to generate an additional EXTB instruction to promote to 32-bit in=
t with=0A=
sign extension before using the value.=0A=
=0A=
-Vineet=0A=