Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 01 Apr 2019 10:12:34 -0700 (PDT)
Message-Id: <20190401.101234.1259757550586433319.davem@davemloft.net>
To:     edumazet@google.com
Cc:     dust.li@linux.alibaba.com, kuznet@ms2.inr.ac.ru,
        yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, caspar@linux.alibaba.com
Subject: Re: [PATCH] tcp: fix a potential NULL pointer dereference in
 tcp_sk_exit
From:   David Miller <davem@davemloft.net>
In-Reply-To: <CANn89iLAHD1Jkk4xeKUk89s7FPVaBdE5AHu3zNdBZNMn8w8mBw@mail.gmail.com>
References: <20190401080453.87465-1-dust.li@linux.alibaba.com>
        <CANn89iLAHD1Jkk4xeKUk89s7FPVaBdE5AHu3zNdBZNMn8w8mBw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Eric Dumazet <edumazet@google.com>
Date: Mon, 1 Apr 2019 02:23:39 -0700

> On Mon, Apr 1, 2019 at 1:05 AM dust.li <dust.li@linux.alibaba.com> wrote:
>>
>> From: Dust Li <dust.li@linux.alibaba.com>
>>
>>  When tcp_sk_init() failed in inet_ctl_sock_create(),
>>  'net->ipv4.tcp_congestion_control' will be left
>>  uninitialized, but tcp_sk_exit() hasn't check for
>>  that.
>>
>>  This patch add checking on 'net->ipv4.tcp_congestion_control'
>>  in tcp_sk_exit() to prevent NULL-ptr dereference.
>>
>> Signed-off-by: Dust Li <dust.li@linux.alibaba.com>
> 
> Fixes: 6670e1524477 ("tcp: Namespace-ify sysctl_tcp_default_congestion_control")
> Signed-off-by: Eric Dumazet <edumazet@google.com>

This patch didn't make it to the list for whatever reason, but I applied it and
have it queued up for -stable.

Thanks.