Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
To:     Mark Brown <broonie@kernel.org>
CC:     "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Timo Alho <talho@nvidia.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "Krishna Yarlagadda" <kyarlagadda@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH V1 24/26] spi: tegra114: de-assert CS before SPI mode is
 reset to its default
Thread-Topic: [PATCH V1 24/26] spi: tegra114: de-assert CS before SPI mode is
 reset to its default
Thread-Index: AQHU5GIMZGFJTMMz0U+IEn8v+fuhv6Ym9icAgACrszA=
Date:   Mon, 1 Apr 2019 18:07:45 +0000
Message-ID: <BYAPR12MB33984E9D0FA76FCC77FD72BFC2550@BYAPR12MB3398.namprd12.prod.outlook.com>
References: <1553666207-11414-1-git-send-email-skomatineni@nvidia.com>
 <1553666207-11414-24-git-send-email-skomatineni@nvidia.com>
 <20190401074940.GL2059@sirena.org.uk>
In-Reply-To: <20190401074940.GL2059@sirena.org.uk>
Accept-Language: en-US
received-spf: None (protection.outlook.com: nvidia.com does not designate
 permitted sender hosts)
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 61b5bcd0-c3a1-4ae8-efaa-08d6b6ccf100
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2019 18:07:45.1076
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2936
X-OriginatorOrg: Nvidia.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1554142069; bh=Pq0D7fWixUPci1w8wkc0qr2viJIX9yQXNtw6DTZaSKE=;
        h=X-PGP-Universal:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:
         Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:
         X-MS-TNEF-Correlator:authentication-results:x-originating-ip:
         x-ms-publictraffictype:x-ms-office365-filtering-correlation-id:
         x-microsoft-antispam:x-ms-traffictypediagnostic:
         x-microsoft-antispam-prvs:x-forefront-prvs:
         x-forefront-antispam-report:received-spf:
         x-ms-exchange-senderadcheck:x-microsoft-antispam-message-info:
         MIME-Version:X-MS-Exchange-CrossTenant-Network-Message-Id:
         X-MS-Exchange-CrossTenant-originalarrivaltime:
         X-MS-Exchange-CrossTenant-fromentityheader:
         X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:
         X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg:
         Content-Language:Content-Type:Content-Transfer-Encoding;
        b=cx3p+Otv9CbYB8uGMlcUZ189/7NHCQdU2JGY6rBCKL0N3cPB57YdwYtrALczV23sp
         rrGM039uHYocJtLOnjdHTw4PQd4bv642v9UmSfU7iJC26wccFrSlING9hilbIXd+pQ
         pcTTMlpSHAXqU7q4n9csqyEsmKek0oIff2Ugv4IRfO0mAzFbwdo4UPzo/+pqDPGSUV
         hvs0s89T3Xx1/I0zTQwROfiWdMeyg7gjAQIZcbihTftik4bWNM1LTpXWy/39lc/XL+
         U5FFQGKfq+4XrxcmkfDyfs2ZCjqFVLOF0T4fs4wrcSfM81by29U4sO6K1XilG9GEbR
         GXbDpcQbfEyEg==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Tue, Mar 26, 2019 at 10:56:45PM -0700, Sowjanya Komatineni wrote:
> > With SW CS, during transfer completion CS is de-asserted by writing=20
> > the default command1 register value to SPI_COMMAND1 register. With=20
> > this both mode and CS state are set at the same time and if current=20
> > transfer mode is different to default SPI mode and if mode change=20
> > happens prior to CS de-assert, clock polarity can change while CS is=20
> > active before transfer finishes.
>
> This is a bug fix so I'd expect it to be much earlier in the series befor=
e any of the new features.

Thanks Mark. Will change order as per your feedback in next version of patc=
h series.

I see you have applied some patches in V1 series so should I re-send again =
those as well along with feedback changes in next version or just only the =
patches that are not applied.