Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp541209yba; Mon, 1 Apr 2019 11:24:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqwBvcoMa0GH5QF/Ko9K9v2IbHblIQUaJN/H2WF2Vw4le5fESVRzv+suMUZjJ8Gu6nLeBSam X-Received: by 2002:a63:3185:: with SMTP id x127mr61911404pgx.299.1554143045688; Mon, 01 Apr 2019 11:24:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554143045; cv=none; d=google.com; s=arc-20160816; b=ZUzCVr7UpnDDUZvqu8MYcM809E0niKHp0oaFln7K4KYWeOLvRT4TAuVK0h1IhL4TmW 9YoktsDa1yWyYeiAcl8Stvi1iqPEVXXylFv9s9LbUOMbt8KPZONYQt1IL0bD5gbKLkmJ qbOqolgm6/VFaPSxE2ylJe159PusVouvk2jFnvvNpIab+CAiFaGVnTmjdFujr5qby04h fgVBDYhI++HgCgu4nxUkBqiHj2IdmShg+Jzgftivn70FIdohQuLQLmJReAH6R7nbnPbI mbIjQg0FhkxNjtY2flqQOL8B/ThFlt0lWQzOA7LiUOPlLA6UT5d64RaMCc/5k2NGywp5 6LAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=jrTVSfFUTaSkdCEtitxBp3U8hSAuryvisq47B3A3FWE=; b=j7lK76RU2eYFlLSgNjj+E3D7BlMvc+s5bBSfiLMgcVCCsLWAkRSIvY0HL+uiFT3daT sr9jErjss4OAMmKNEOI6EmHIxmNXxLjzTjyNcTl5UDr1PAC9gaJHkm8+uATYSyk0zka/ rxECerNkLdoHEkWSQqUlqOmTkrtHU4Qa0Oshm3j9vtzAin+QTsLKihis60yfjcGSV5lU RfN0a0ZXC+FO9i97mZVTgoEU2kHuu5jJxudd9HtkM6p5MRK1CHgyhokUHamrgz4aJm/J XIw9TE1jK0cp0sCCTc36zWHEV4lSDRoDhRAp/4Q3TYRG3uIcgGw8MntQIEp2TZVTtVFg ssKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=OwFbV8jG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h185si8612038pfc.241.2019.04.01.11.23.50; Mon, 01 Apr 2019 11:24:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=OwFbV8jG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728918AbfDASV7 (ORCPT + 99 others); Mon, 1 Apr 2019 14:21:59 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:42127 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728697AbfDASV7 (ORCPT ); Mon, 1 Apr 2019 14:21:59 -0400 Received: by mail-qt1-f195.google.com with SMTP id p20so11796399qtc.9 for ; Mon, 01 Apr 2019 11:21:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=jrTVSfFUTaSkdCEtitxBp3U8hSAuryvisq47B3A3FWE=; b=OwFbV8jGsmAOhHnI2T/rGNhkQrKTYN47VEHXk5aWTgAywRFBb0Unvxp6l4Jd2p7T5g 2E1Rfcnw6dYw1p3FKBnYHGhwWiRnF6K7j6ayprh0bljr0Q+QFA8Lpggc27SMf4NKBug1 uDRNKaTs06G/FnUct8HDP2Dhr81kZSQXupzZWeOr/2FCIUwGwbR8D6KWys3FcZxCqCVW 8hv783bU1YHIVyr+0mnPLGft8VARetfHuDGZQIobUAecKyTCm+r8myebDTHMHpCvDfZf /gLPcvtsyxUo4tgGgEXQ1q2AMEr40Du+4FHzB8M7k1xq5vqUVbMrtiQiYkB4MIUedH+O iCWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=jrTVSfFUTaSkdCEtitxBp3U8hSAuryvisq47B3A3FWE=; b=XZ9vgUNUbJY3JpRyvYQ1+9iDRIz9PDIRjkukep0wouiU2Zq4EANU/5oEVp6Dm+FSEZ YBJ7l6q663O+/d+skfUShieVnXeLB8m/hbMiICQfTrTO0qVtKqCOgxhQZf+FSktSocWo NodwlvEuT7frwxlbzZevxV0zENazMT0fuz8T3r4lxkkj+CATNEprJfSGp/xoYKsb/h28 MkzM3xJeM+Pm52HTONWOnql8O1KK5OQgksALQDbLrRAx8c+bU6in7aC6gHvCrZAFZaWx rgmEhYpBXmwG+LP5Hljs7P8Rjfndr0qChhwZm9tdvNzendfV/xeeBBGtokjz8TV6qFwQ 6Hqw== X-Gm-Message-State: APjAAAXwGeiZgoBLkTNJeeAga4QTerenhRdzUvjF8+wJ9wBzGOP3x0Cl iM1XHL5yJqI5os5BHLALjoRNng== X-Received: by 2002:ac8:3517:: with SMTP id y23mr56403563qtb.57.1554142918663; Mon, 01 Apr 2019 11:21:58 -0700 (PDT) Received: from cakuba.hsd1.ca.comcast.net ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id a19sm6198289qtk.35.2019.04.01.11.21.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Apr 2019 11:21:58 -0700 (PDT) Date: Mon, 1 Apr 2019 11:21:53 -0700 From: Jakub Kicinski To: peterz@infradead.org, tglx@linutronix.de, David Miller Cc: ard.biesheuvel@linaro.org, yamada.masahiro@socionext.com, mingo@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com, alexei.starovoitov@gmail.com Subject: Re: [PATCH 0/3] locking/static_key: improve rate limited labels Message-ID: <20190401112153.2f9e87ba@cakuba.hsd1.ca.comcast.net> In-Reply-To: <20190330000854.30142-1-jakub.kicinski@netronome.com> References: <20190330000854.30142-1-jakub.kicinski@netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Mar 2019 17:08:51 -0700, Jakub Kicinski wrote: > Hi! > > This will be used to fix the static branch disabling in the TLS > code. The net/tls/ code should be using the deferred static > branch type, because unprivileged users can flip the branch > on and off quite easily with CONFIG_TLS_DEVICE=y. > > Second of all we shouldn't take the jump label locks from > the RX path, when the socket is destroyed. This can be avoided > with some slight code refactoring in deferred static_key as > it already runs from a workqueue. > > This the series (and a simple tls patch which makes use of it) > applied opening 0.5M TLS connections to localhost (just calling > setsockopt, no data exchange) goes down from 37.9s to 12.4s. Once/if we get positive feedback from locking folks, would it be possible to merge these via net-next tree alongside the patch converting TLS to rate limited branches?