Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp580577yba; Mon, 1 Apr 2019 12:15:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqx/ZyB2vRq2l2CYKNXM1gq7OV6rUCuLrVady0PTChTLer4l1y06craGRYvHgXd2XvKGpmjD X-Received: by 2002:a62:2a97:: with SMTP id q145mr65460085pfq.22.1554146141629; Mon, 01 Apr 2019 12:15:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554146141; cv=none; d=google.com; s=arc-20160816; b=WSYp4UY0wmkSZd7Ks70o24wuapMOW6jkWNzL0K5LvTOBrDnQ72fwdXsrujVioLuFk/ cWgDRU9iXnk4wXl25USGOPbwTclpc7CquNYQm76wVjsIJRdbqHr80S7erijbM9szOCt9 stCce5+9BYz+oABvnkbPiKX5SUi7vLNeM7dZn/VReEvHn2gMkBaV2vWrQ+LhxGoBgjWb cf0x1+VuXcB0YTipI6DSFwGgrk+DAR8WGNe9MsV9XeodMuGYX4iugPtfbwXu9ZXeshQC zfCr/W2b3lV2zB0dkef9//Wl3a4HLvDEUDATctrO5hPyc0MpU8dFGmP7a0kfLFkHokOC x3FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=D7X0bSvolJDJPpVoArTx/EkG3ciEuleLeYJKoAOM3vs=; b=Pdxp756NzcoqRzJe+tF6kF2uaG05F1ud5t90+NuAmFP6cmFFLwF0EAsuROSQDlDIob VAyAkIYu7LXbOz6LdmX3WrKHGx25GhB+kwsanZ4nQOGgIUqJ6nJkGAWwiuhNvpzXGgbX U3slzDt6mfQPRSZyX3MkpFZe1y3V7HHqW4B/TCxRiIcnv9rqKYIAAIdSLmXo6+19dZzE AWITmCSfHwcPJcEbU2+/LsoWWRl33BU3bKIkrQ8Uk6Ff6fbSfJCiLyT0KZMAOJlTgIA5 dEWTByULL1U1RrAURXr96C8ItCnihU8bH410i994ZWnK3jDASj04namOYef790zTkqxC eA9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="MUcury/Z"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ay8si3370473plb.202.2019.04.01.12.15.25; Mon, 01 Apr 2019 12:15:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="MUcury/Z"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728863AbfDATOc (ORCPT + 99 others); Mon, 1 Apr 2019 15:14:32 -0400 Received: from mail-yb1-f195.google.com ([209.85.219.195]:41013 "EHLO mail-yb1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728733AbfDATOc (ORCPT ); Mon, 1 Apr 2019 15:14:32 -0400 Received: by mail-yb1-f195.google.com with SMTP id c15so1819401ybk.8 for ; Mon, 01 Apr 2019 12:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=D7X0bSvolJDJPpVoArTx/EkG3ciEuleLeYJKoAOM3vs=; b=MUcury/ZCmfLMJh1eYktYvrs/5QcYN044HhtaQXALVopSNd+/Zviezfcm7pu4n+YN2 L3GnmvPzRqLYdcCCFBbMvOWSbR4XW85owZaFYUvSwRHU/OU8Z2q+OiYmqx75acuMpGnz P0QTlbdCWbAe0WXGrTLJlqNXf/QoT0m8XjSf8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D7X0bSvolJDJPpVoArTx/EkG3ciEuleLeYJKoAOM3vs=; b=uCrMRLAjv89mhblIW/MUgz4dv2n5t5MphmyVHNIl9DX0cef7Hdy5i4ToDrYCeYNHx+ 0vzDkU0ZO0sleGTFynraxAdmW6zgmKPIk3RqwZJtnrDtaICUMUls89Ocy4/MvnnEZboV KJDmk1DG23GZpTOubvn1pxAkXgBTjLpA1C7pmmUlAeWTCaIS65aXpqHh1Jzcig2JO2hd jHFubeQKKAakeMZfdr5fzO5PjvG9smhL4gsAqRXVqzr4xeHbBizrkFWY4fx7QXAebU7W 7+tvFoC1y0QgcgiMG+FSms2RoGcU6K8pyV7AbbryunFNhUUaY8JqZMtYFBYSepaxdrYo KcCA== X-Gm-Message-State: APjAAAVmf5ijlY6hWuKrstdWWPhDi5AgUTagDVW0nKrDcIWQn9HFl8cJ iZC+uZeWw/2R/feEzZDJ/mrz26e5oQo= X-Received: by 2002:a25:2f55:: with SMTP id v82mr6599183ybv.458.1554146070925; Mon, 01 Apr 2019 12:14:30 -0700 (PDT) Received: from mail-yw1-f52.google.com (mail-yw1-f52.google.com. [209.85.161.52]) by smtp.gmail.com with ESMTPSA id x13sm6463712ywx.63.2019.04.01.12.14.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Apr 2019 12:14:28 -0700 (PDT) Received: by mail-yw1-f52.google.com with SMTP id e76so3672106ywa.9 for ; Mon, 01 Apr 2019 12:14:27 -0700 (PDT) X-Received: by 2002:a81:4c13:: with SMTP id z19mr55177133ywa.57.1554146067104; Mon, 01 Apr 2019 12:14:27 -0700 (PDT) MIME-Version: 1.0 References: <20190401190607.GA23795@beast> <20190401190955.GJ6209@ziepe.ca> In-Reply-To: <20190401190955.GJ6209@ziepe.ca> From: Kees Cook Date: Mon, 1 Apr 2019 12:14:14 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] tpm: Actually fail on TPM errors during "get random" To: Jason Gunthorpe Cc: Jarkko Sakkinen , James Bottomley , Phil Baker , Craig Robson , Laura Abbott , Tomas Winkler , LKML , Peter Huewe , Arnd Bergmann , linux-integrity Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 1, 2019 at 12:09 PM Jason Gunthorpe wrote: > > + * -errno otherwise ((positive TPM return codes are masked to -EIO) > > Extra bracket, but otherwise looks fine to me Thanks! (And I guess it's time for lunch so I can take a break and learn how to type again...) -- Kees Cook