Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp587577yba; Mon, 1 Apr 2019 12:24:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqzZHtLNlc32LvMoA6ZkPTywOyGhWAyr/zPjsiEhXGUUndRfiFRTfdiddLMzxu8zhQzA0yaj X-Received: by 2002:a17:902:22f:: with SMTP id 44mr66745283plc.138.1554146699758; Mon, 01 Apr 2019 12:24:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554146699; cv=none; d=google.com; s=arc-20160816; b=YbzzoWtTB/GyAR/+Dv6/Fh3viW4j4BlLijXazvPWAJPCAQBSXSdG/aisuAb5bQ1YDZ KRAXBawh88A3wPRsyzFM8PSjkkGn86fd7nsrYJ/UMrR/Jz3VZu8F4ndQmAszVywbDzP0 FAMmGNzoy1NhHkywflVcTAUFZ1fQz9MURwGwar04sFG5vlsuWIeUVvf2CZkeFqwO7KrI j0EPsQRJo+969MErcP8MGp37US3NZajDOWuLtWlrUemN5SmXXgiX79VbvXDlX6ORGvjA RwNxSV0W+lEhUnJht+bYJwl9GxBkDv4WBzUYM+4QAnYOCDfQLvXdSCl6lhLkmBbJcft7 c/Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:user-agent :references:organization:in-reply-to:subject:cc:to:from; bh=GtO6z3o05QwU3+rS3Brm1aAuQ5y8zvZx49pjlqsWmtw=; b=VVES5WlnbGMwbuZlOZNLyue2rRqonaLnWfval8BF7IJCv8hA2m6Xkcy5+Fa4+3/PAi X95cgfSlASa9h64vNzG7gX7YbZTASwteVIc7hTTRfXEb4e7bQs6wh2kC+jLxRifsq97X u5QXNZLqu/3cdFbU1WDfpq74aBESAbQ1KoYYPbvWzVnofWcpihQQdb6LutMsJv7GsByI lInskgkVxwMKQVmYUlHgRNrzlGhSWsXF2yUdaaeTwoiBXCPNl+iOsxNKamDh+GjtOajM bKGvX8hhoAXNiRDrJ0rPIOgUStKMf9Ou2vKqR8SEmW/j5aAylDrgtq4knVtSDsoqLkFZ EZ1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f1si9732517plb.396.2019.04.01.12.24.44; Mon, 01 Apr 2019 12:24:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726142AbfDATYC (ORCPT + 99 others); Mon, 1 Apr 2019 15:24:02 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:41880 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725839AbfDATYC (ORCPT ); Mon, 1 Apr 2019 15:24:02 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 9F4942822A0 From: Gabriel Krisman Bertazi To: Linus Torvalds Cc: "Theodore Ts'o" , Linux List Kernel Mailing Subject: Re: How to add Unicode character tables to the kernel? In-Reply-To: (Linus Torvalds's message of "Mon, 1 Apr 2019 10:51:39 -0700") Organization: Collabora References: <20190331230940.GA30957@mit.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Mon, 01 Apr 2019 15:23:57 -0400 Message-ID: <857ecd5y2a.fsf@collabora.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds writes: > On Sun, Mar 31, 2019 at 4:09 PM Theodore Ts'o wrote: >> >> The question is how to do this, with different tradeoffs. One is to >> simply include a utf8data.h file, which will be 320k. That might >> sound large, but in fs/nls there are 3544k worth of similar files. >> Some are relatively small --- only 16k. But others are quite large >> --- 480k to 856k. The table for Chinese character set is such an >> example. So in comparison, the 320k size of utf8data.h is quite >> compact. >> >> The problem with this solution is that the files in fs/nls, and the >> proposed utf8data.h, are generated files. > > Oh, we definitely don't want to copy the original huge tables, and we > don't even *want* people to edit those things in the first place. > > So generated files are fine. It's not like the source data isn't > public, and yes, the commit message should have a pointer to it and > how to get the source and the generated files. But no, we shouldn't > feel like we should encourage people to be able to generate their own > modified unicode tables. Thanks! Ted, as you know, the current patchset depends on the original tables, so I will adapt it to only include the generated files and submit a new version to the mailing list. -- Gabriel Krisman Bertazi