Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp597372yba; Mon, 1 Apr 2019 12:37:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqwvbI7gIE9WTJ93Lsfvto6AJZstimqPJSIEJmS+gg4TGCrDDbZE13a8RRKN89yRlJ4LL49s X-Received: by 2002:a17:902:6bc5:: with SMTP id m5mr9157422plt.180.1554147462325; Mon, 01 Apr 2019 12:37:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554147462; cv=none; d=google.com; s=arc-20160816; b=XljAnUCfewNf/HoamUHjvtY9qBZo5/vXwkZpAzh80uo0oER/SSl8Mh5gOHV6cK2rXs lxu07IMF03skxxqDJY5q4tiCEFpaOEb+xU7tKHpDMCu9p1vmOND0yz4If442HJFWfy2h YDGRQ+90XSnwJ+x0+UmlOQB0ZrAm1T62nfQZhSUKwYCbYRVe+BI3wpHw57y6LWZwom0M za+tlL6BIBmwYeweCQgUI52WE7BXEA1JfD4C3NwDhEA62Gx/ggPd1p8c3aY589Yqka3Q mC6hPhZoItWp0KE4+ebPyMwktppqWNBDkTGoL1B1ynXadOgdBwf9ZafOVZn0NZNpppYs qXKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :subject:cc:to:from:date; bh=3jx8vWCduKI8VlrOhOrOv9R5NYUg5n6LtbbUQEFSCd8=; b=jiOp/m6hO8Qlih4rCjpiU1CFyQG6EGomACd9q8ASy6ObCJ9V5gKIHutuXJBCyYOM+v vqLA3wCKlmeD9JMlFpxGYcYHCImtiOS5uTikxjgl1rJbTzeAQpvvQJr4ph5DSX+abBw+ reVVZ1LMFZ2UQzOZh3mkAEC+R4l/ijmtQjOkUR9NV2iEMIS3oC5vg1rQeWGsh3Uphbmk 16Z9ihw5d/vG0v3+EcmfZ663amv8USPHo9EI1yT4HCOHPTs5lGhgGRI+MxmmNi+dDaCy 8MuKz8JwOm6ToQVn51A+s5016mUWhVY9Q4/4uGODqefIcrS1xPY71ozxp6O9UBl1a/Q7 ESZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 36si9255704pgx.547.2019.04.01.12.37.26; Mon, 01 Apr 2019 12:37:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726352AbfDATgQ (ORCPT + 99 others); Mon, 1 Apr 2019 15:36:16 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:26817 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725895AbfDATgP (ORCPT ); Mon, 1 Apr 2019 15:36:15 -0400 X-IronPort-AV: E=Sophos;i="5.60,297,1549926000"; d="scan'208";a="301440628" Received: from abo-75-106-68.mrs.modulonet.fr (HELO hadrien) ([85.68.106.75]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 21:36:12 +0200 Date: Mon, 1 Apr 2019 21:36:12 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Neil Armstrong cc: Rob Herring , David Airlie , Daniel Vetter , "Marty E. Plummer" , Tomeu Vizoso , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kbuild-all@01.org Subject: [PATCH] drm/panfrost: fix odd_ptr_err.cocci warnings Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kbuild test robot PTR_ERR should access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci Fixes: 10f21de123ac ("drm/panfrost: add support for reset lines") CC: Neil Armstrong Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git panfrost-rebase-v2 head: 10f21de123ac13b8c257528b0b1222ebb5650510 commit: 10f21de123ac13b8c257528b0b1222ebb5650510 [7/7] drm/panfrost: add support for reset lines :::::: branch date: 10 hours ago :::::: commit date: 10 hours ago Please take the patch only if it's a positive warning. Thanks! panfrost_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -21,7 +21,8 @@ static int panfrost_reset_init(struct pa pfdev->rstc = devm_reset_control_array_get(pfdev->dev, false, true); if (IS_ERR(pfdev->rstc)) { - dev_err(pfdev->dev, "get reset failed %ld\n", PTR_ERR(pfdev->clock)); + dev_err(pfdev->dev, "get reset failed %ld\n", + PTR_ERR(pfdev->rstc)); return PTR_ERR(pfdev->rstc); }