Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0976D60736
Subject: Re: [PATCH 2/4] staging: iio: ad9832: add SPDX identifier
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Marcelo Schmitt <marcelo.schmitt1@gmail.com>, lars@metafoo.de,
        Michael.Hennerich@analog.com, stefan.popa@analog.com,
        jic23@kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net,
        linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com
References: <20190401143724.mcn73jhdtq3zp3nk@smtp.gmail.com>
 <ac167cc8-4236-2e15-d5f2-fa222d95da49@codeaurora.org>
 <20190401171355.GA19716@kroah.com>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <0e1a0be4-e2f3-fb09-3d2b-e8a52b87f7e5@codeaurora.org>
Date:   Tue, 2 Apr 2019 01:24:50 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190401171355.GA19716@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 4/1/2019 10:43 PM, Greg KH wrote:
> On Mon, Apr 01, 2019 at 08:36:50PM +0530, Mukesh Ojha wrote:
>> On 4/1/2019 8:07 PM, Marcelo Schmitt wrote:
>>> Add SPDX identifier of GPL-2.0 for the ad9832 driver.
>>>
>>> Signed-off-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
>>> ---
>>>    drivers/staging/iio/frequency/ad9832.c | 3 +--
>>>    1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
>>> index 50a583020072..d8d4a7936275 100644
>>> --- a/drivers/staging/iio/frequency/ad9832.c
>>> +++ b/drivers/staging/iio/frequency/ad9832.c
>>> @@ -1,9 +1,8 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>> FYI
>>
>> Use C notations here as per https://lkml.org/lkml/2019/2/13/570.
>>
>> <https://lkml.org/lkml/2019/2/13/570>
>>
>> Once you fix it then you can take mine
>> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
> Did you read the documentation about how to put a proper SPDX line in
> the kernel documentation?  For .c files, you have to use "//", not "/* */"
>
> Please read:
> 	Documentation/process/license-rules.rst
> and see the section "Style" for all of the details.
Thanks for the detail Greg.

Missed the fact.

Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>

Cheers,
-Mukesh

>
> thanks,
>
> greg k-h