Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp824507yba; Mon, 1 Apr 2019 18:17:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqzAJiDCp6hbmk/HG4UFn7/YOFQKwGJJCtbgJclZu3C/9GUqCt+fpd/kMAi33NKxSqgrCu32 X-Received: by 2002:a63:751d:: with SMTP id q29mr28041108pgc.215.1554167854807; Mon, 01 Apr 2019 18:17:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554167854; cv=none; d=google.com; s=arc-20160816; b=kgFSf4yBBdFtsp44x71BziS4OTWfOrHxCblmCDE6POpdES8ufZQFXgAnD/C9Knu4/5 Emdh6AWZhQV9jn/lc1i2+ApJc47EWKdvCQlhtEocQAlTma+tN8xrV00f+DhTu6SiLwfc pMoQq/EMqsDxqYjFC/jCmfpIZ0SYRq1TcJufVPFQ5Dl0C8SpcU85ycfoC/6ec1D2UtkY TEAS2UOuSDc735k2sGeoOmiLi04vL/H9EyeDX3nJXG7xnUEmYY5/7S4z5bZV0l5UrQBd 7ACX6HbKXBLCrgor56LKBB/G0dHueXHLSFJnTPBxDIlXInBLvr41e9FPjr0JWXKc1eeo hRKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=hPauufx/4El17V207DeO2PpOwUDIQz8OWuIngV3DfsQ=; b=dbF3wusc9WYUIxjidL0EaT5jQ1NwC70I7bW/R0V1CdSly9lwHfaVN0hWw64qyzRMwN ppHHlsziiSLhAO52olQqfEgwK8TGp9Dmks1K1/zDOCno4W1qFgNiqVUEnpKW1K80SACm FuWptL1X4o3Nqr5MbuX3RCuA71aiqAimZdqaNcX6smUuDwI9ZBkMN0SdTIXjhyOYpXnD BNA90M/hkm3x3ltwbQqdVpGVTtViLQmVPgVLBucxCoPz8cB2sjaTtYjzgADNv/tiYUBn j4qskowqRkCvPFoUstve/gqeCWVX4GjtSk5FQ0wAnVKxT/I+MmyVAuu+5JRziCEAgpOw Iztg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c20si10010489pls.53.2019.04.01.18.17.18; Mon, 01 Apr 2019 18:17:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728712AbfDBBQn (ORCPT + 99 others); Mon, 1 Apr 2019 21:16:43 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:41262 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725992AbfDBBQn (ORCPT ); Mon, 1 Apr 2019 21:16:43 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 37E81133E9760; Mon, 1 Apr 2019 18:16:42 -0700 (PDT) Date: Mon, 01 Apr 2019 18:16:41 -0700 (PDT) Message-Id: <20190401.181641.1589135999760609672.davem@davemloft.net> To: yuehaibing@huawei.com Cc: gerrit@erg.abdn.ac.uk, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, dccp@vger.kernel.org, mojha@codeaurora.org Subject: Re: [PATCH] dccp: Fix memleak in __feat_register_sp From: David Miller In-Reply-To: <20190401013554.17488-1-yuehaibing@huawei.com> References: <20190401013554.17488-1-yuehaibing@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Apr 2019 18:16:42 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yue Haibing Date: Mon, 1 Apr 2019 09:35:54 +0800 > From: YueHaibing > > If dccp_feat_push_change fails, we forget free the mem > which is alloced by kmemdup in dccp_feat_clone_sp_val. > > Reported-by: Hulk Robot > Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values") > Reviewed-by: Mukesh Ojha > Signed-off-by: YueHaibing Applied.