Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp856675yba; Mon, 1 Apr 2019 19:13:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqyaCAXdoL4/qqvNfkeRP/gmA2t0Jtql+OCIYqjhkcqU64Aj9mHsFoovzsHoDqWNMyREM7Du X-Received: by 2002:a17:902:bf07:: with SMTP id bi7mr45586065plb.87.1554171210199; Mon, 01 Apr 2019 19:13:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554171210; cv=none; d=google.com; s=arc-20160816; b=DTCkllKvr4ytZqF10Wn7U40PnQulZEnG5h3HnzNDUZ4E0Hef1NdXvteWySK26T5c0z w1OPkylG30F3RCbsNdbeoq0UUd4YMAmbbJdkbm43UylKRIPBGpURIPHzaGFICudJKVM2 qZFeVpZ3Jk3pbm59cDLyrLuXPu8WcrdJZKuSqbdKaUWtmX0lpoxoFca5AOgMtEt/gOAQ CbXi8yqETCWBTWus5dH3DgIHf2JsL7XNBX7jYTTHo/wookCp/RpOI9F4gx9fO8vKil8i OC1Jxc5KWprW58dtNKHl4L4HeK150c1SYQqbyJuNvsYgY2TnAoExOiSwunnaI/uGI9rk Gyfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=WTeyW4ja8NAWpD/FTpdp5agpTs6TAgFPWlTvrp/jC8E=; b=IgZ1qaEB/wACjVv/uUfxSRh9PsudQ+H1D0e1x8dHPpWyd00gG7rpSFnHrEvBTOyc06 DRHoqkBXRljuBmLnYw1zbm+v9QXtRZURJ/0Z95LdYj0g2pUzhY8KTSbf3VfuMAB2K7nu xJVGhAmtTrB9aIkBC4sxcwufcTQV/fRZ/attPWhfSiRs7i4TxeIZn/7c4+5FlhRzcyZQ ZIrLOdGGbkzWfhXv+KFmZ5ezz1O8J5uFqTvoFv1UQc4dLFZqlewSlllBnmnPe96qwdM3 5GlXSJVtBr3weJaN1kxdaDEfl4m2+aaC/AvIEM1ZH5Gz14EY8F765hKu+HlcphZ7w9Th ViQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 195si10217206pga.312.2019.04.01.19.13.13; Mon, 01 Apr 2019 19:13:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728690AbfDBCMg (ORCPT + 99 others); Mon, 1 Apr 2019 22:12:36 -0400 Received: from mx.socionext.com ([202.248.49.38]:36376 "EHLO mx.socionext.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726269AbfDBCMg (ORCPT ); Mon, 1 Apr 2019 22:12:36 -0400 Received: from unknown (HELO iyokan-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 02 Apr 2019 11:12:34 +0900 Received: from mail.mfilter.local (m-filter-2 [10.213.24.62]) by iyokan-ex.css.socionext.com (Postfix) with ESMTP id 3E4CD6117D; Tue, 2 Apr 2019 11:12:34 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Tue, 2 Apr 2019 11:12:34 +0900 Received: from yuzu.css.socionext.com (yuzu [172.31.8.45]) by kinkan.css.socionext.com (Postfix) with ESMTP id E4C341A04E0; Tue, 2 Apr 2019 11:12:33 +0900 (JST) Received: from [127.0.0.1] (unknown [10.213.234.213]) by yuzu.css.socionext.com (Postfix) with ESMTP id B50FC120499; Tue, 2 Apr 2019 11:12:33 +0900 (JST) Subject: Re: [PATCH 0/2] Add Updown Counter support for Milbeaut M10V SoC To: Jonathan Cameron Cc: robh+dt@kernel.org, mark.rutland@arm.com, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, masami.hiramatsu@linaro.org, jaswinder.singh@linaro.org, orito.takao@socionext.com, sugaya.taichi@socionext.com, kasai.kazuhiro@socionext.com, William Breathitt Gray References: <1553581954-13487-1-git-send-email-kanematsu.shinji@socionext.com> <20190330183603.55886d4f@archlinux> From: =?UTF-8?B?S2FuZW1hdHN1LCBTaGluamkv5YW85p2+IOS8uOasoQ==?= Message-ID: <9522af01-1017-08d5-73c7-8b81b749c29a@socionext.com> Date: Tue, 2 Apr 2019 11:12:32 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.2 MIME-Version: 1.0 In-Reply-To: <20190330183603.55886d4f@archlinux> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jonathan, On 2019/03/31 3:36, Jonathan Cameron wrote: > On Tue, 26 Mar 2019 15:32:34 +0900 > Shinji Kanematsu wrote: > >> This is a series of patch which adds Updown Counter support on >> Milbeaut M10V SoC. >> >> The Updown Counter counts input pulse signal from external quadrature encoder. >> It also has input pulse signal counter function. > Hi Shinji, > > Are you aware of the counter subsystem that has been proposed (and > as far as I am concerned is ready to be merged)? > > https://patchwork.kernel.org/project/linux-iio/list/?series=147 > (I think that's the latest version posted).. > William, perhaps you could give an update? > > (bad luck, you are getting popular ;) > > I'll take a quick review as it stands, as some issues may carry over. > I appreciate that it's always unfortunate to try to upstream stuff at the > same time as a new framework is being developed / upstreamed, but I don't > intend to take any additional counter drivers into IIO. We just > end up having to maintain old interfaces in more and more drivers. > Thank you for your reply. I just learned that upstream requires the counter subsystem. Detailed information was given by William. Thank you, Kanematsu > Thanks, > > Jonathan > >> >> Shinji Kanematsu (2): >> dt-bindings: iio: counter: Add Milbeaut Updown Counter >> iio: counter: Add support for Milbeaut Updown Counter >> >> .../bindings/iio/counter/milbeaut-updown_cnt.txt | 22 ++ >> drivers/iio/counter/Kconfig | 12 + >> drivers/iio/counter/Makefile | 1 + >> drivers/iio/counter/milbeaut-updown.h | 38 ++ >> drivers/iio/counter/milbeaut-updown_cnt.c | 385 +++++++++++++++++++++ >> 5 files changed, 458 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/counter/milbeaut-updown_cnt.txt >> create mode 100644 drivers/iio/counter/milbeaut-updown.h >> create mode 100644 drivers/iio/counter/milbeaut-updown_cnt.c >> >