Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 2 Apr 2019 07:26:01 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Morris Ku <saumah@gmail.com>
Cc:     linux-kernel@vger.kernel.org, morris_ku@sunix.com
Subject: Re: [PATCH 4/4] Add support for SUNIX Multi-I/O board
Message-ID: <20190402062601.GX4187@dell>
References: <20190319120835.3840-1-saumah@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190319120835.3840-1-saumah@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 19 Mar 2019, Morris Ku wrote:

> Driver for SUNIX Multi-I/O card.Based on parport_pc.c, ppdev.c
> and lp.c by Linus Torvalds, Theodore Ts'o.

Parallel port drivers should live in 'drivers/parport' and
'drivers/char'.  LP drivers should live in 'drivers/char'.

Please them there.

> Signed-off-by: Morris Ku <saumah@gmail.com>
> ---
>  mfd/sunix/snx_ieee1284.c     | 144 +++++++
>  mfd/sunix/snx_ieee1284_ops.c | 258 +++++++++++++
>  mfd/sunix/snx_lp.c           | 717 +++++++++++++++++++++++++++++++++++
>  mfd/sunix/snx_lp.h           | 119 ++++++
>  mfd/sunix/snx_parallel.c     | 397 +++++++++++++++++++
>  mfd/sunix/snx_ppdev.c        | 454 ++++++++++++++++++++++
>  mfd/sunix/snx_ppdev.h        |  15 +
>  mfd/sunix/snx_share.c        | 629 ++++++++++++++++++++++++++++++
>  8 files changed, 2733 insertions(+)
>  create mode 100644 mfd/sunix/snx_ieee1284.c
>  create mode 100644 mfd/sunix/snx_ieee1284_ops.c
>  create mode 100644 mfd/sunix/snx_lp.c
>  create mode 100644 mfd/sunix/snx_lp.h
>  create mode 100644 mfd/sunix/snx_parallel.c
>  create mode 100644 mfd/sunix/snx_ppdev.c
>  create mode 100644 mfd/sunix/snx_ppdev.h
>  create mode 100644 mfd/sunix/snx_share.c

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog