Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1007150yba; Mon, 1 Apr 2019 23:47:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqx71FbzUegAPmFa9qovJqoOhofmrayXI++Cy/Fhatl+Fc3xHsNQpVIqkrevYul3P3Xft2as X-Received: by 2002:a62:ab14:: with SMTP id p20mr68777328pff.23.1554187631560; Mon, 01 Apr 2019 23:47:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554187631; cv=none; d=google.com; s=arc-20160816; b=aQKzjiKSgSDFrTFxdortAx9FzEyHiZiGXg/SgPPGfoa302T2+2AO06AuSBEoBthrJc 8FOtiW7+QM8DSgiSaYEX9nkQhC+1NkBoiJLMW+/AHue9kANlWx0Jly+AFarGqXs9DCT2 q0mFbLFhumWW5grB3qjC93S6BKNI8tpromry/L7iQf6i4U1mLZu/tgd/IEi5FZ/Q8MMh 8XrKqeDwoXEwAebc1mVCzE/ulrpPwjgrC7auSPxjXuvdSwT6X9qrfZh+jsWJxCuspH9k NG+LcUJfr2waJd0MCY11FQp/EA7Xy1FZPZP9lXzHu+qvwHakbAEYS5+nTOg/+f0neVJD hRJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:authenticated-by; bh=EDDmV9RCMLonbHLniBSge0I8APHz1ZTIgqrADN+TQBU=; b=SO8+WyElo4LKZFGFiddj55TRH5fsxeDaeIQasLvPoajH9DJlpMTtW1bl8fgAkw7at1 a/WOEOOTaeDCXfUd3FcZpUEtODAnP/zP82AUahisVZks/FfFZx6Kt9UPPHzy2p6icczp iOW2IzZMP3ZNfTdev9mYTKDSPy9gM+VcjJUpXn6QOo1VoLq7jipWLiPEdAfzu5DAguzc /7rdcAddxzkfB6iRyUC0V5iZyJAcVD6Dr1J7nyPNvC9xT4GN9TiHQ76zbHjnNTEBxI3Z NksugyFx7BsDQTD86W0MPuqlYY9TB+ipRT2Gb4vslZOzTVUwSGJM7yi+ulcSklb5CUgI 5Pxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p10si10265613plk.413.2019.04.01.23.46.56; Mon, 01 Apr 2019 23:47:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728413AbfDBGpo convert rfc822-to-8bit (ORCPT + 99 others); Tue, 2 Apr 2019 02:45:44 -0400 Received: from rtits2.realtek.com ([211.75.126.72]:57509 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726436AbfDBGpo (ORCPT ); Tue, 2 Apr 2019 02:45:44 -0400 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.62 with qID x326jX6L008682, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtitcasv02.realtek.com.tw[172.21.6.19]) by rtits2.realtek.com.tw (8.15.2/2.57/5.78) with ESMTPS id x326jX6L008682 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 2 Apr 2019 14:45:33 +0800 Received: from RTITEXH01.realtek.com.tw (172.21.6.62) by RTITCASV02.realtek.com.tw (172.21.6.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 2 Apr 2019 14:45:33 +0800 Received: from RTITMBSVM07.realtek.com.tw ([fe80::a512:a803:bf1e:b23]) by RTITEXH01.realtek.com.tw ([::1]) with mapi id 14.03.0439.000; Tue, 2 Apr 2019 14:45:32 +0800 From: Kailang To: Takashi Iwai CC: Jian-Hong Pan , "alsa-devel@alsa-project.org" , Daniel Drake , "linux@endlessm.com" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] ALSA: hda/realtek: Enable headset MIC of Acer TravelMate B114-21 with ALC233 Thread-Topic: [PATCH] ALSA: hda/realtek: Enable headset MIC of Acer TravelMate B114-21 with ALC233 Thread-Index: AQHU6Dqw5knd0/Ath0C1mp5SHHcFl6YnBJOAgAFn61D//3uTAIAAhmXA Date: Tue, 2 Apr 2019 06:45:32 +0000 Message-ID: <6FAB7C47BCF00940BB0999A99BE3547A18DBAFCA@RTITMBSVM07.realtek.com.tw> References: <20190401032503.2821-1-jian-hong@endlessm.com> <6FAB7C47BCF00940BB0999A99BE3547A18DBAFAD@RTITMBSVM07.realtek.com.tw> In-Reply-To: Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.22.105.152] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Kailang Yang -----Original Message----- From: Takashi Iwai Sent: Tuesday, April 2, 2019 2:43 PM To: Kailang Cc: Jian-Hong Pan ; alsa-devel@alsa-project.org; Daniel Drake ; linux@endlessm.com; linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/realtek: Enable headset MIC of Acer TravelMate B114-21 with ALC233 On Tue, 02 Apr 2019 08:38:32 +0200, Kailang wrote: > > Hi Takashi, > > This COEF value was modified by me. OK, then could you give your Acked-by or Reviewed-by tag? thanks, Takashi > > BR, > Kailang > > -----Original Message----- > From: Takashi Iwai > Sent: Tuesday, April 2, 2019 1:09 AM > To: Jian-Hong Pan > Cc: alsa-devel@alsa-project.org; Daniel Drake ; > linux@endlessm.com; Kailang ; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH] ALSA: hda/realtek: Enable headset MIC of Acer > TravelMate B114-21 with ALC233 > > On Mon, 01 Apr 2019 05:25:05 +0200, > Jian-Hong Pan wrote: > > > > The Acer TravelMate B114-21 laptop cannot detect and record sound > > from headset MIC. This patch adds the ALC233_FIXUP_ACER_HEADSET_MIC > > HDA verb quirk chained with ALC233_FIXUP_ASUS_MIC_NO_PRESENCE pin > > quirk to fix this issue. > > > > Signed-off-by: Jian-Hong Pan > > Signed-off-by: Daniel Drake > > --- > > sound/pci/hda/patch_realtek.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/sound/pci/hda/patch_realtek.c > > b/sound/pci/hda/patch_realtek.c index a3fb3d4c5730..bdb2227be4eb > > 100644 > > --- a/sound/pci/hda/patch_realtek.c > > +++ b/sound/pci/hda/patch_realtek.c > > @@ -5690,6 +5690,7 @@ enum { > > ALC286_FIXUP_ACER_AIO_HEADSET_MIC, > > ALC256_FIXUP_ASUS_MIC_NO_PRESENCE, > > ALC299_FIXUP_PREDATOR_SPK, > > + ALC233_FIXUP_ACER_HEADSET_MIC, > > }; > > > > static const struct hda_fixup alc269_fixups[] = { @@ -6713,6 > > +6714,15 @@ static const struct hda_fixup alc269_fixups[] = { > > { 0x21, 0x90170150 }, /* use as headset mic, without its own jack detect */ > > { } > > } > > + [ALC233_FIXUP_ACER_HEADSET_MIC] = { > > + .type = HDA_FIXUP_VERBS, > > + .v.verbs = (const struct hda_verb[]) { > > + { 0x20, AC_VERB_SET_COEF_INDEX, 0x45 }, > > + { 0x20, AC_VERB_SET_PROC_COEF, 0x5089 }, > > + { } > > For the additional COEF application, I'd like to hear ack from Kailang. It's still a black magic from Realtek, so need some confirmation. > > > thanks, > > Takashi > > > + }, > > + .chained = true, > > + .chain_id = ALC233_FIXUP_ASUS_MIC_NO_PRESENCE > > }, > > }; > > > > @@ -6737,6 +6747,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > > SND_PCI_QUIRK(0x1025, 0x1290, "Acer Veriton Z4860G", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > > SND_PCI_QUIRK(0x1025, 0x1291, "Acer Veriton Z4660G", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > > SND_PCI_QUIRK(0x1025, 0x1308, "Acer Aspire Z24-890", > > ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > > + SND_PCI_QUIRK(0x1025, 0x132a, "Acer TravelMate B114-21", > > +ALC233_FIXUP_ACER_HEADSET_MIC), > > SND_PCI_QUIRK(0x1025, 0x1330, "Acer TravelMate X514-51T", ALC255_FIXUP_ACER_HEADSET_MIC), > > SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z), > > SND_PCI_QUIRK(0x1028, 0x054b, "Dell XPS one 2710", > > ALC275_FIXUP_DELL_XPS), > > -- > > 2.20.1 > > > > > > ------Please consider the environment before printing this e-mail. >