Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1008508yba; Mon, 1 Apr 2019 23:49:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqwb/OSWehP7csHDhNL1qo+dgbEZdnQlPCyWlTRwYsAE9AoQUxihS6jt2ZkKGzggi0b7xYnh X-Received: by 2002:a17:902:bb98:: with SMTP id m24mr47363470pls.17.1554187788497; Mon, 01 Apr 2019 23:49:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554187788; cv=none; d=google.com; s=arc-20160816; b=m7UcQDkPRTk9X1BZJImyaQIWMHY9mdbAPeWY69dllEDUzhZ+brSuXJA9iLNiQopu3p cMfb3q/nIymv6K4z0jgwNVsnKGlGJh+NheDQuJtxH1hJdG/lpC+vzsslzXmqpZZY/eK2 wtuCt3A48q8/KBJbHdvr3y2bZsE7IvIdylP/Cjlc0FnhN/Ra7msniYxe3xUiiIc7QG1J Ki4wfBtt8OF3s8VqH7/umWE+3NKdIT6SXqtl6zIMleY8VSzXzGlX+TBys3oXVvrMPTvz PtkS9vLnPVoJVwWoftROZahrfi7JUHabKvZBFwvwBJKF1GgehrUVs6DEXAOLFsazheg7 Bkgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=wqqhpOshfOodSZDcIGAPglJ+O3e5ZBYgiqEoT7BdCo4=; b=t3bIFHwD58ihnChpSZ+E11OWLPmfTTneQ0RBl86UcBpS9NV2t0tC4VFSSO6M4CJzZV MY5HACSNB1UEXUGTg2YSp4lMxe1k7o04uCEn/9EHg3BdXp6xluF2uAd9mAoRr7n885d+ LxDRTbCoePRGT/kYI9VOUQYmigndwKht1W2tC1aoDZL7D7GNSoR3Bj70hB35tZZaHn9K onPeWTQMDbEmNeWvxJ4IblLcU0c8ORbr7dGIhhGorzKIYBEIlcWhXgxIrWBcaDTSAuhM 3eebgrWtqy0+JiOyzJMCeaDvw7HVHHsuNIdnFcYMu8YOM+O2/2bqEH8OlOSU5nYYkPzL Ru7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=C3Mju4yy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o123si10884875pfb.116.2019.04.01.23.49.32; Mon, 01 Apr 2019 23:49:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=C3Mju4yy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729197AbfDBGsw (ORCPT + 99 others); Tue, 2 Apr 2019 02:48:52 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:44140 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726964AbfDBGsw (ORCPT ); Tue, 2 Apr 2019 02:48:52 -0400 Received: by mail-pg1-f195.google.com with SMTP id i2so6036335pgj.11 for ; Mon, 01 Apr 2019 23:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=wqqhpOshfOodSZDcIGAPglJ+O3e5ZBYgiqEoT7BdCo4=; b=C3Mju4yyYYV/s231iRmErUBgy7w3R+44E6tTiFacEPZFTA9EupNspRRfnWXsgiReT0 K+yhbRT7HaNHI0vrekyPCIqX9oqZENJfFAt1XIVbEouuEb3tF1rTrlSgBkwdk82lhZdM p6GBtGGm62JqMvZvlh/NkADOtm68YVR3S9uBGPIO/z0DxlWP9UeOls6POaR69eCoO3up 6WdtnuOnfyjQmil2SYqh6RWUKjfgraB2iySzU13QNR/5OVdttmg4A2t34/L7OXadyDi2 KiNoLQQ4vgvmrhgXpaLzodOPF1vdcW8CqPaMu0z5i9Mu4mYKGJd73NWnm2Xblpwy9eRc hCkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=wqqhpOshfOodSZDcIGAPglJ+O3e5ZBYgiqEoT7BdCo4=; b=IQrqp5TgU7pA31dnYQIE3VjQWDI7SvJpBYFp7/U/99V1ry2BL39fnP3wOWBBl8jK0B kOu3u+Qg9q16bNXz5EGUMUXsP0Rk0TG3aS6Zwdr1lytJiMpPJxoZ0WvLYCKnqgYfjmdU IhVyHDydpd2o5xkixdbTdbbPiGQuMDsB+Qlo9gI4iNff49NAG+x6Cad3DbCjLSxtmjKg Z2jFR7ISw9EJbHXxhMpyp2HN+nq899PPGv2QBBdUzVDf44wHTe7P3/sq0ggm3CaPzgdJ ErW85eREGVdzYkTr0blApgTcpYLjfj9qKaE0Qpk7fE7LQwA4cB0Yaro07rjN469Abn39 1P0A== X-Gm-Message-State: APjAAAVueK03miprXccR+OTS6irlm91GWw7Euafvb9ArvZ1R+Jvah/+g CLKBzoigDO8UINlDvi+xKDwYgA== X-Received: by 2002:a63:711d:: with SMTP id m29mr19511042pgc.109.1554187731349; Mon, 01 Apr 2019 23:48:51 -0700 (PDT) Received: from dell ([147.50.13.10]) by smtp.gmail.com with ESMTPSA id u4sm38874820pgn.12.2019.04.01.23.48.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Apr 2019 23:48:49 -0700 (PDT) Date: Tue, 2 Apr 2019 07:48:42 +0100 From: Lee Jones To: Hsin-Hsiung Wang Cc: Rob Herring , Matthias Brugger , Mark Brown , Eddie Huang , Marc Zyngier , srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Liam Girdwood , Mark Rutland , Sean Wang , Alessandro Zummo , Alexandre Belloni Subject: Re: [PATCH v2 1/9] mfd: mt6397: clean up code Message-ID: <20190402064842.GB4187@dell> References: <1552275991-34648-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1552275991-34648-2-git-send-email-hsin-hsiung.wang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1552275991-34648-2-git-send-email-hsin-hsiung.wang@mediatek.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Mar 2019, Hsin-Hsiung Wang wrote: > clean up code Please explain what it is that you're cleaning up. > Signed-off-by: Hsin-Hsiung Wang > --- > drivers/mfd/mt6397-core.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) The patch is fine though. When you resubmit, please add my: For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog