Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1103219yba; Tue, 2 Apr 2019 02:17:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqwfdZFvcqGGXijT5gKl7WUub4+vTwamCpcOVFYi+ctcFqi+I69aPpcf6wYOCfcSbQmlp0Ty X-Received: by 2002:a17:902:8349:: with SMTP id z9mr48496286pln.144.1554196675708; Tue, 02 Apr 2019 02:17:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554196675; cv=none; d=google.com; s=arc-20160816; b=us7RBz0Q2vb0VT2iMegsB2VLiShwnUFBJ1mkCkkq6GznVXCbvACAAyvGqWUnsHknX0 lAJw/SxxZto51RyQcLIRgEkX58R4x2mVtb3M1r5GRYdxr3pynlygam1rTLvfYiwnVW6Q x25aMipsNRSF89lmgLXUFYzzWhAQqbvL6dIqqG/3/TMdtiZU+Pj5BjohO3f5bVC0tY5z jFRoT3fQuBrji3/4xDQckC1psyWJ8qEYL0MSf5eEfEG+aLlKvE2Iw5hYPn4eH0GkCQo2 N69aN9RORRvg4tQG/6+0L8GWorMMxMh16AOxMz1Cu4OymarzsIkivZIVfMlFmo5tL3U0 3NBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date; bh=982tJo3hKt//XJrOl6Qd4Qe6AbaUU1qQs14BtkJdN/g=; b=ch2w/vE+US5okYLZ/3jxEE46utlJW2YMPFMQA3+VihuZILJst5c97e/S7yhp42j6Tb hypEuktDOSARjmyps7X6qdGlUHqyghXnty/fGKhlKt9gqOeYi+/dunWRRKnnoAbjchK6 n4lmgRMXbrco7d8V0maFMmDi0SYPc3XOTD5SJIbKdg8t26L1zICosaKO3c3CEBlS6H+I 4BQu8Q3DDPSA1+te9usuN7IVeaUmDbUiVuuF+ayztt606ABKf1E1AYBaC4za6kayR2BH xOLt4KmxVDtk7TJ3tZZkQOvQfUpCQlSHj73aDydSYbEY1GlLmshj6X628+vyBSrbKfIV oIWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v21si10753095plo.34.2019.04.02.02.17.40; Tue, 02 Apr 2019 02:17:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728739AbfDBHSj (ORCPT + 99 others); Tue, 2 Apr 2019 03:18:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:44806 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725889AbfDBHSj (ORCPT ); Tue, 2 Apr 2019 03:18:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6FF3FAFB4; Tue, 2 Apr 2019 07:18:37 +0000 (UTC) Date: Tue, 02 Apr 2019 09:18:37 +0200 Message-ID: From: Takashi Iwai To: Kailang Cc: Jian-Hong Pan , "alsa-devel@alsa-project.org" , Daniel Drake , "linux@endlessm.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ALSA: hda/realtek: Enable headset MIC of Acer TravelMate B114-21 with ALC233 In-Reply-To: <6FAB7C47BCF00940BB0999A99BE3547A18DBAFCA@RTITMBSVM07.realtek.com.tw> References: <20190401032503.2821-1-jian-hong@endlessm.com> <6FAB7C47BCF00940BB0999A99BE3547A18DBAFAD@RTITMBSVM07.realtek.com.tw> <6FAB7C47BCF00940BB0999A99BE3547A18DBAFCA@RTITMBSVM07.realtek.com.tw> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 02 Apr 2019 08:45:32 +0200, Kailang wrote: > > > Reviewed-by: Kailang Yang Thanks, applied the patch now. Takashi > > -----Original Message----- > From: Takashi Iwai > Sent: Tuesday, April 2, 2019 2:43 PM > To: Kailang > Cc: Jian-Hong Pan ; alsa-devel@alsa-project.org; Daniel Drake ; linux@endlessm.com; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] ALSA: hda/realtek: Enable headset MIC of Acer TravelMate B114-21 with ALC233 > > On Tue, 02 Apr 2019 08:38:32 +0200, > Kailang wrote: > > > > Hi Takashi, > > > > This COEF value was modified by me. > > OK, then could you give your Acked-by or Reviewed-by tag? > > > thanks, > > Takashi > > > > > BR, > > Kailang > > > > -----Original Message----- > > From: Takashi Iwai > > Sent: Tuesday, April 2, 2019 1:09 AM > > To: Jian-Hong Pan > > Cc: alsa-devel@alsa-project.org; Daniel Drake ; > > linux@endlessm.com; Kailang ; > > linux-kernel@vger.kernel.org > > Subject: Re: [PATCH] ALSA: hda/realtek: Enable headset MIC of Acer > > TravelMate B114-21 with ALC233 > > > > On Mon, 01 Apr 2019 05:25:05 +0200, > > Jian-Hong Pan wrote: > > > > > > The Acer TravelMate B114-21 laptop cannot detect and record sound > > > from headset MIC. This patch adds the ALC233_FIXUP_ACER_HEADSET_MIC > > > HDA verb quirk chained with ALC233_FIXUP_ASUS_MIC_NO_PRESENCE pin > > > quirk to fix this issue. > > > > > > Signed-off-by: Jian-Hong Pan > > > Signed-off-by: Daniel Drake > > > --- > > > sound/pci/hda/patch_realtek.c | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/sound/pci/hda/patch_realtek.c > > > b/sound/pci/hda/patch_realtek.c index a3fb3d4c5730..bdb2227be4eb > > > 100644 > > > --- a/sound/pci/hda/patch_realtek.c > > > +++ b/sound/pci/hda/patch_realtek.c > > > @@ -5690,6 +5690,7 @@ enum { > > > ALC286_FIXUP_ACER_AIO_HEADSET_MIC, > > > ALC256_FIXUP_ASUS_MIC_NO_PRESENCE, > > > ALC299_FIXUP_PREDATOR_SPK, > > > + ALC233_FIXUP_ACER_HEADSET_MIC, > > > }; > > > > > > static const struct hda_fixup alc269_fixups[] = { @@ -6713,6 > > > +6714,15 @@ static const struct hda_fixup alc269_fixups[] = { > > > { 0x21, 0x90170150 }, /* use as headset mic, without its own jack detect */ > > > { } > > > } > > > + [ALC233_FIXUP_ACER_HEADSET_MIC] = { > > > + .type = HDA_FIXUP_VERBS, > > > + .v.verbs = (const struct hda_verb[]) { > > > + { 0x20, AC_VERB_SET_COEF_INDEX, 0x45 }, > > > + { 0x20, AC_VERB_SET_PROC_COEF, 0x5089 }, > > > + { } > > > > For the additional COEF application, I'd like to hear ack from Kailang. It's still a black magic from Realtek, so need some confirmation. > > > > > > thanks, > > > > Takashi > > > > > + }, > > > + .chained = true, > > > + .chain_id = ALC233_FIXUP_ASUS_MIC_NO_PRESENCE > > > }, > > > }; > > > > > > @@ -6737,6 +6747,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > > > SND_PCI_QUIRK(0x1025, 0x1290, "Acer Veriton Z4860G", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > > > SND_PCI_QUIRK(0x1025, 0x1291, "Acer Veriton Z4660G", ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > > > SND_PCI_QUIRK(0x1025, 0x1308, "Acer Aspire Z24-890", > > > ALC286_FIXUP_ACER_AIO_HEADSET_MIC), > > > + SND_PCI_QUIRK(0x1025, 0x132a, "Acer TravelMate B114-21", > > > +ALC233_FIXUP_ACER_HEADSET_MIC), > > > SND_PCI_QUIRK(0x1025, 0x1330, "Acer TravelMate X514-51T", ALC255_FIXUP_ACER_HEADSET_MIC), > > > SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z), > > > SND_PCI_QUIRK(0x1028, 0x054b, "Dell XPS one 2710", > > > ALC275_FIXUP_DELL_XPS), > > > -- > > > 2.20.1 > > > > > > > > > > ------Please consider the environment before printing this e-mail. > > >