Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <a3d975a7a8e378c5a831d7ae6a98da1af9557c05.camel@perches.com>
Subject: Re: [PATCH 4.4 034/131] lib/int_sqrt: optimize small argument
From:   Joe Perches <joe@perches.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Anshul Garg <aksgarg1989@gmail.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>,
        Will Deacon <will.deacon@arm.com>,
        David Miller <davem@davemloft.net>,
        Matthew Wilcox <mawilcox@microsoft.com>,
        Kees Cook <keescook@chromium.org>,
        Michael Davidson <md@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Arnd Bergmann <arnd@arndb.de>
Date:   Tue, 02 Apr 2019 02:00:06 -0700
In-Reply-To: <20190402065958.GA21380@kroah.com>
References: <20190401170051.645954551@linuxfoundation.org>
         <20190401170055.035782875@linuxfoundation.org>
         <d153fa8079c3e49e1ad35a54c400298ba51184e3.camel@perches.com>
         <20190402065958.GA21380@kroah.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.1-1build1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2019-04-02 at 08:59 +0200, Greg Kroah-Hartman wrote:
> On Mon, Apr 01, 2019 at 10:42:52AM -0700, Joe Perches wrote:
> > On Mon, 2019-04-01 at 19:01 +0200, Greg Kroah-Hartman wrote:
> > > 4.4-stable review patch.  If anyone has any objections, please let me know.
> > 
> > If this is to be ported just for an optimization
> > (which I think is dubious as it's not a bug fix),
> 
> Yes, it was requested to be backported because of that.
> 
> > why not port the __fls optimization too?
> > 
> > __fls has a bigger effect on performance.
> 
> What commit are you referring to?

f8ae107eef209bff29a5816bc1aad40d5cd69a80

> thanks,
> 
> greg k-h