Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 2 Apr 2019 10:50:34 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Kimberly Brown <kimbrownkd@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 7/8] cpufreq: schedutil: Replace default_attrs field
 with groups
Message-ID: <20190402085034.GK12232@hirez.programming.kicks-ass.net>
References: <20190322201440.GA30814@ubu-Virtual-Machine>
 <cover.1554151487.git.kimbrownkd@gmail.com>
 <18a50bab72e6bd326250b2bd5b5a4b414351815d.1554151487.git.kimbrownkd@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <18a50bab72e6bd326250b2bd5b5a4b414351815d.1554151487.git.kimbrownkd@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 01, 2019 at 10:51:53PM -0400, Kimberly Brown wrote:
> The kobj_type default_attrs field is being replaced by the
> default_groups field. Replace sugov_tunables_ktype's default_attrs field
> with default groups. Change "sugov_attributes" to "sugov_attrs" and use
> the ATTRIBUTE_GROUPS macro to create sugov_groups.
> 
> This patch was tested by setting the scaling governor to schedutil and
> verifying that the sysfs files for the attributes in the default groups
> were created.
> 
> Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com>

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

Please route the patch as is most convenient.

> ---
>  kernel/sched/cpufreq_schedutil.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
> index 5c41ea367422..148b60c8993d 100644
> --- a/kernel/sched/cpufreq_schedutil.c
> +++ b/kernel/sched/cpufreq_schedutil.c
> @@ -598,13 +598,14 @@ rate_limit_us_store(struct gov_attr_set *attr_set, const char *buf, size_t count
>  
>  static struct governor_attr rate_limit_us = __ATTR_RW(rate_limit_us);
>  
> -static struct attribute *sugov_attributes[] = {
> +static struct attribute *sugov_attrs[] = {
>  	&rate_limit_us.attr,
>  	NULL
>  };
> +ATTRIBUTE_GROUPS(sugov);
>  
>  static struct kobj_type sugov_tunables_ktype = {
> -	.default_attrs = sugov_attributes,
> +	.default_groups = sugov_groups,
>  	.sysfs_ops = &governor_sysfs_ops,
>  };
>  
> -- 
> 2.17.1
>