Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1165456yba; Tue, 2 Apr 2019 03:46:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqwDPmBczryG6PK0kgk1wuRSxTYYeRuQ4ZXtrmihILzDDJORpYTHsb4KedXBHFOSLThcZyzO X-Received: by 2002:a65:6201:: with SMTP id d1mr9328027pgv.28.1554201966229; Tue, 02 Apr 2019 03:46:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554201966; cv=none; d=google.com; s=arc-20160816; b=Ougu4c+SvouTwtSf5U974MaqdUyzXRedFid1b/sk6cAxcRs8Ci0gdDsKVSvHSOhASI A8vz+a6gjAUa5O3GuC065zPjl5JFP/qxK+BtBDqww1XnCNHrApzlG8hPYRTeykk148cK /fSa8X8d4eFIOcU4fekPY1Q6CV5HtOV/v85CE+rAvtoPOaz7tcseu16R9TqDX40Hgdbl 7ZaB5qotl1YBBDH1Z5JPeAvDcNiMzvEdxjecz0QxG/umZML6Hszg9g/vEk1+xzmbPil4 QQfRZhW9i3tRwBwKknBSQ71hqF+gdm9l2jFcP1dmCh5uLRQEhH5rcgGElXSXZen0uH+3 /fUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:to:subject:references:cc :dkim-signature; bh=9d0nkpmRGLSpeJJsJ+uX7iO9/y3MIduP3D9eLHYMQJo=; b=RJwzdmTSEZspTpUFmYcWAThrkY0fh6CGCf02tKopcI5sN4Hs8vHbbSz5giY81zm8ir UNMrWPtA36zCLVF2UHYbY6+H3BzjYnGCO+h5XWk8mH3Tts+1ReYGMm/ftjDW/oCJ+8bO bQGUDD95KpvFeZBWirOMEDEM/KEsI2Mu5A4jiLiD4kTY1/a1RTAOcWsC1xctgt9vpaZX 1y+VBBZK1oNZQeMur7iQ5B7ujBOhY37QeLECpL0FLHQzEvh+FxsLeYlvAlzulr6n89iF QAIIIXDU6B821fTvbvaIeTO2CS9pLJVL/a3AAysrbtKKZ6Nh6+9hKHFMqK+Q3qgYUzHQ 1nGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=eD4L+znU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 12si3191845pgn.67.2019.04.02.03.45.50; Tue, 02 Apr 2019 03:46:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=eD4L+znU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730460AbfDBKnh (ORCPT + 99 others); Tue, 2 Apr 2019 06:43:37 -0400 Received: from mout.web.de ([212.227.15.3]:34629 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726468AbfDBKng (ORCPT ); Tue, 2 Apr 2019 06:43:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1554201802; bh=9d0nkpmRGLSpeJJsJ+uX7iO9/y3MIduP3D9eLHYMQJo=; h=X-UI-Sender-Class:Cc:References:Subject:To:From:Date:In-Reply-To; b=eD4L+znUE5rD/c9IXIXms5jQTLTUc8Aj6DqJUTLHGBg1nMi1ZbYaemaNov6Hg0EMe kJdgltUg6KUCKdOXeXWZt3WEpLV/4XMnky/Dpuxu53FfU9DriaWO3Un8urEWet5T02 2WhNXacHuBSIgmcreQga3HlUrE59D139I7Trdpok= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([2.243.142.30]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LaTdP-1gVqGj0fOx-00mOSf; Tue, 02 Apr 2019 12:43:22 +0200 Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Viresh Kumar , Yi Wang References: <1554082674-2049-8-git-send-email-wen.yang99@zte.com.cn> Subject: Re: [PATCH 7/7] cpufreq: ppc_cbe: fix possible object reference leak To: Wen Yang , kernel-janitors@vger.kernel.org From: Markus Elfring Openpgp: preference=signencrypt Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: Date: Tue, 2 Apr 2019 12:43:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1554082674-2049-8-git-send-email-wen.yang99@zte.com.cn> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:QlsyeE7x7tvb69QA/oAst6mAWT0jvBbAIn6Z6Z0AEi4QJ3ozr5O +AapMN1/a+R9i3zIoOhj/Q+2KzYmcMmildT0kHOLKHD5Fx3wYig7p/YNDfedQUwbdJ0lCEq DKtgmMzb0b0Hm20stW8A0pfxavrvyFOxREzoHFYEMX0Dc64+v2w0fiyoXnwt3gafwxJW4LI TZUMCs5Rbmac2saEYDUqg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:3vJYlkikdPI=:4K0Wd4KPMGxD1ZDy899LVG dprH5WkqBYuz/JCvZBf1/19W2ezvAEHglCArxXqRc5S8MDfyLotUgRbp+x6nK3WbYF/Dk7uS7 hygeS4YKV48BzErT3G49XEfIPD0P7Jw/poP6dzlJjVE3EpGVxulu2XbHRD2WROEPpD6wHPagR Z6kovNOOG86BnVqfc/s4aVlnaWrEQZU1oa1fGQsBO3upbWDZNJhHBQArAEPZx9yE8+y6j8aXq Qs6RuJAdfs35QB/wQ5bj3VHTeOnHOEne0yLKtoDPhKRABULIEB0H0qsn9woscyz21DAeLfIsu E0vIeLGy9QSc0fhxametVe0dpcy6XAVoHKAdxWnJneWj3iAPV1sz0uKoaZbswzu8jKvT2JDrt u+r7X5B+c60F0+2j23b0NUOfCfMaeR2t2hnq4k+KzFVKwYXmEw8BPrt+bZMXOGmQP6/njBRVx +onC6E0YhdhNYd2h2X2Tvqnu1UGGJZ2RTXChy/oYwhysJyoceNFDOMI/1E70b00nFZKkNZH/4 zQRYsf+oUdxAZWquoovtzKwvhcoQ0CfRZ7/Rkz+GI9emdHSZ/EGSnt+NUgv6hIZFkXcl9WP/v wbTEjtkJEA5LiRq+0Xb0ImBGviuwDVvFYGup1dKj61L5wie3dMT6yX81DgFxlVpVSkdy7mAz9 UzXyr7KRreBDfMRl+kbY2qmP2Nsq/HILmb19bnzPouHcVYzdl/0TJHViWTSlCvwb7o5FY9SiT KGFjRJqE1WEgsVilmo68W1Ef4+0m5+BzyQksfAXrvw2RzsJkNSiJMFbIfyHLU/2E7dYZhFHao UDvdZpGXuXl/AeUepn+2Fj/jXNNeBh3JcSUAx4w9aV7mNaIPHBTA7QEB4cQw4FKM0A9336ucI lNUlviN7nRO6QtH3vmgKeRjfklt+m38Oy2azhSoPUR7mQnEuBPLXDML6VY0oZ8oOog6f7biuJ 8F2cpHa+UOA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The call to of_get_cpu_node returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. I would prefer a wording like the following. A reference counter was incremented for a CPU node by a call of the function =E2=80=9Cof_get_cpu_node=E2=80=9D. Thus decrement it after the last usage. > Detected by coccinelle with the following warnings: I wonder about the shown duplicate notification. Can a single message be sufficient for the code search result in this source file? Regards, Markus