Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1325667yba; Tue, 2 Apr 2019 06:55:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqwKGUu2kXjqUu2tifbMjlPqTqdAtqXB8RkM+FEtYcomzcissc9ChIjiJtSuGxc38YiymcsL X-Received: by 2002:a17:902:403:: with SMTP id 3mr70231371ple.48.1554213343660; Tue, 02 Apr 2019 06:55:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554213343; cv=none; d=google.com; s=arc-20160816; b=ZM2zMyN3XPuu4jHKe3+LgeoRx1zBcIyf+g/5W3+J5/UQvwx0/9H4GKBolUJ115OnTF AowLiYMY1bATiUmhc9c3DroOmpLNDr0/UPftnCS1B0TYodrVTzQWEtakATHCX2OD69uc PR/3jtGQ1WSTJSAG6N7OiHJ1sZEclYk9tSkrel7QjwfKuQ8nHAyg03tI07620RH4relP bZyiZIMA0ZWM64Y5U1zW4HBVEi7IUgUxFPgKTojstxb3uKBsy7V1yzk5TV71AL/2O1am 766OrsTgE1Pgy8jFAWTQyTHZ8OWuX7u22aorjQEsjcgRqToRV9LP0cU5Gok+1pZ6X3wq 5vTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:to:subject:references:cc :dkim-signature; bh=ypYw/tb7IndR/wjQTBQGgAYhVPGd9muXypTRen5gDCs=; b=dgQvW6Yq00/sMxmyCLbKvCPn+rSLYUEuafcru8f7i/Atvm3X9MaXtIVfOY35EK3Ck3 eYuy2M2+8UWCMhQNMfcrWeyj1KW3nnC6LFH3Ioir1H/ra5ZmnkliwaC1ZsWaOEVWzwTs NSU+xlLAD3sgiLI/1jip1oK6J3xDIzXnXLBsPdr5rClaxy9Jjy8V7QFktfyEkcHbMO1M FRDa4lGnslIg1SgIspqQ+D1GlTnNWIaON0dMVgUoyNq7718y60+PGWsLedFPk/umiovk XxwJTLF+Wz+scpxwKzoSXNMTqCgrTlboR2jX2RVj38IXE/iyb/tbgYQJoG1tEKKto5Ci NzAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=BhULigD5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g5si11113153pfi.60.2019.04.02.06.55.27; Tue, 02 Apr 2019 06:55:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=BhULigD5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731948AbfDBNyw (ORCPT + 99 others); Tue, 2 Apr 2019 09:54:52 -0400 Received: from mout.web.de ([212.227.15.3]:54213 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732147AbfDBNyu (ORCPT ); Tue, 2 Apr 2019 09:54:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1554213272; bh=k91NcjSyQqyCkKw4wGSO1ezkxgl3DCEboDfJN3NWxqw=; h=X-UI-Sender-Class:Cc:References:Subject:To:From:Date:In-Reply-To; b=BhULigD5lqki28kQyIxNevnYSl/4rZKOonvkKzzm3FRktPoiBnWpChGurT2cU2esN 5qtCL3irnqvms8mQ5LhDgHikdmZ4jhIjDK9hzWBwGCOLIdxBhA57Bd1M5uCaNNeFdg 0/lA9riOgBU+ZQjzXdDr34y8J2MdlXSoWlScueC4= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([2.243.142.30]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LuLxv-1glEgJ1Ycp-011iGa; Tue, 02 Apr 2019 15:54:32 +0200 Cc: Andrew Lunn , Jason Cooper , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Sebastian Hesselbarth , Yi Wang References: <1554082674-2049-2-git-send-email-wen.yang99@zte.com.cn> Subject: Re: [1/7] cpufreq: ap806: Checking implementation of armada_8k_cpufreq_init() To: Wen Yang , Gregory Clement , Viresh Kumar , kernel-janitors@vger.kernel.org From: Markus Elfring Openpgp: preference=signencrypt Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <7298cc5c-27e8-c71d-ddc9-553534e502ef@web.de> Date: Tue, 2 Apr 2019 15:54:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1554082674-2049-2-git-send-email-wen.yang99@zte.com.cn> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:xo3Y9vHcKzl/daI9nr/lK+RDOhEo5w10hpA0LWK65xOy+O5MqGE dmHfcp45AT+AcBt+XdLeTFJPvMUde0Xb7OWOybs4WuPkLiiaF9UQBD5Qu+BDqrbOc7Op30e qBQmQ4/3fEThA1L3IIXTYb9IF9ZTMcld+2aXpA409dVvAocSzkS9tYlx3F8ResEba2+zzdr ds97KbRdnnIw0gjSdrkRw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Qfh10DbuLAs=:HOP7dEwnG+I3RkDdt774Zq 36f5oLG1eFLDVCskObycD+qOZAA+64lE19HqNzYOP4btFy8doyieTfvv/Mz94U/89xqiEsjWo r7QHm29nGI764ZEfsDgNn7QtwCvbcgc8zeZn9bPayqECueqedPtp3juLtyZ69F5qCKrDPuj3W QVB8yduBd1/XYGcsDM4ZnmS7fhNR9RH/4UNSbnu82gHxJT0LO8Vefa8/Js/iHLjJ5ltxk9Iy9 XvLWt8hFvTKPvhKGyVP87CAvpFKrgSdaWsQMf0syYjSQ/dx7ORF+IAezL8545jh/DoTQn7lip 4PdPXahQwMvBCtHydB1HLt5svoHSc7FMUhczIHLRvdLFyZ6r/OchTRyZV9sVCMQn+z615Vhko n7jPYDQf883y7fmGuf5+2keXOJQKIRvqz7IB/vF7VBaEwox3Tfkh6PQ6deai5fPI+scpwNQ0C Ud1T4v10UkiEJhc9PW4qfa/ZP/2kvo1A+gUOSAM0p7FlZKN4PTlD2k/8vSNbxC8P2MNg8l6Tj W78D20BfzxhhTWZUx2TRESQvnxNGL/vizzUooP/lkJRCbR0bDFmuZSKYC6Ki1SE94W03zlYM4 dv6z8o3QMla7vrp42b/ezJViOpFH/i7CcBptpEiClJ8XkMOwskgc7xV96t77aDmrDoF7UAL+X ITljlx6eDd1GP/Szb5CWwbhnC8KxyQM/+RdWWOULd06cdVGCp96dEx5frQkivcCBBE1Kg/ohN XcPfgbCWUDXr/eUiqbz29JtPnpJwJHVObRv6ptxgyTqLBCnUBClfnBnFr6Ruo6bHr+3JlM8KE K+u0gUhdg3wKf/py6Rn86W7qF7uEmIsbvBG8IyJ3y1LgQ9JEz9J42KajrtMBkF7T1ZJdK8+lF GI1hpC/WrOaLHZy8u++2TBNG/ncVxrpM19cYWxgFwxCh8+/Jz5efeaViNmH3OEoOZHtCRVEFB BTNPdQpoGFQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -132,6 +132,7 @@ static int __init armada_8k_cpufreq_init(void) > of_node_put(node); > return -ENODEV; > } > + of_node_put(node); > > nb_cpus =3D num_possible_cpus(); > freq_tables =3D kcalloc(nb_cpus, sizeof(*freq_tables), GFP_KERNEL); Would another null pointer check be safer for this memory allocation? https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/d= rivers/cpufreq/armada-8k-cpufreq.c?id=3D05d08e2995cbe6efdb993482ee0d38a770= 40861a#n137 Regards, Markus