Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 02 Apr 2019 10:55:22 -0700 (PDT)
Message-Id: <20190402.105522.2070788862454259965.davem@davemloft.net>
To:     jmaxwell37@gmail.com
Cc:     siva.kallam@broadcom.com, prashant@broadcom.com,
        mchan@broadcom.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, jmaxwell@redhat.com
Subject: Re: [net-next] tg3: allow ethtool -p to work for NICs in down state
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190402050756.20507-1-jmaxwell37@gmail.com>
References: <20190402050756.20507-1-jmaxwell37@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Jon Maxwell <jmaxwell37@gmail.com>
Date: Tue,  2 Apr 2019 16:07:56 +1100

> Make tg3 behave like other drivers and let "ethtool -p" identify the
> NIC even when it's in the DOWN state. Before this patch it would get an 
> error as follows if the NIC was down:
> 
> # ip link set down dev em4
> # ethtool -p em4
> Cannot identify NIC: Resource temporarily unavailable
> 
> With this patch ethtool identify works regardless of whether the NIC is up
> or down as it does for other drivers.
> 
> Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com>

Applied, thanks Jon.