Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Andrey Abramov <st5pub@yandex.ru>
To:     Michael Ellerman <mpe@ellerman.id.au>
Cc:     "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
In-Reply-To: <87zhpaox14.fsf@concordia.ellerman.id.au>
References: <18626931553963861@sas1-b3ec53dbc12b.qloud-c.yandex.net> <21287961553964090@iva7-8a22bc446c12.qloud-c.yandex.net> <87zhpaox14.fsf@concordia.ellerman.id.au>
Subject: Re: [PATCH 2/5] powerpc: module_[32|64].c: replace swap function with built-in one
MIME-Version: 1.0
Date:   Tue, 02 Apr 2019 22:11:19 +0300
Message-Id: <673731554232279@sas1-633109cb7707.qloud-c.yandex.net>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

01.04.2019, 13:11, "Michael Ellerman" <mpe@ellerman.id.au>:
> This looks OK. It's a bit of a pity to replace the 8-byte-at-a-time copy
> with a byte-at-a-time copy, but I suspect it's insignificant compared to
> the overhead of calling the comparison and swap functions.
>
> And we could always add a generic 8-byte-at-a-time swap function if it's
> a bottleneck.

I am sorry, I forgot to quickly comment on your letter.
Now (after George Spelvin's patches) the generic swap is able
to use u64 or u32 if the alignment and size are divisible
by 4 or 8, so we lose nothing here.