Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1644371yba; Tue, 2 Apr 2019 12:54:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqxSUEpyxZsT5/IAcKPdZb1cuMPLx0g+UMTzsttyEToig5RtjITeu8h8iVYecoLbqgb1q5UE X-Received: by 2002:a17:902:3e5:: with SMTP id d92mr47390103pld.11.1554234888767; Tue, 02 Apr 2019 12:54:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554234888; cv=none; d=google.com; s=arc-20160816; b=s9DUKxYHA3JdkNWLluOmd9wTMaiHmzgsBiWU7KRuo+yHbi+ZIGK6bnQObG7InZ3OwW vHIuK9T4m7tq/yU/Pl1fxU5/0I79JqTDUnWa3mreXqP4Z7ZHKShRXLQo7nuhUOrkXGQk R/xPbzBCWbso2xzOKi6aSrTp/NMGMREL77+QYKrQI99ssAjJSTpbCyUg2I778NNSPeBc ed92iXIRW8YqOh089yGkpekyGPGpLYPvAGIFKU8jB3Mxi8vsR+mGB6ZH8uNo6lC4KP21 tGi3UDQuNJIw2Bu6QUB4H16gmW3GO1j/EwDyC9PZKPjLO1Ob0CZDxu9+28RN8UuSBVQi LMAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:references :in-reply-to:subject:cc:date:to:from; bh=fNWgNPqgSoKrmV0s53QPx1PpuHIj+YiLtT9HFNRk5IY=; b=zsvD69v8jpoRVbi9WbTDrjvnaNMJbzWRGW6kfhDmCxSyr7d65HPtwp6xZeYEY67eDS 6ittBBWb/PGhm+OsToukiQI6hNOz7AkTlEQFPiCKevh5nSHGKOwivQzCNd43wBIxliuf ghGsHPxnu/qORJe7h+HAopcmJsUywNIOXKQGPr84+0b0ZDy7sDG/WZ6XOunL/Uibb3yj 6/I692KoK6Nhz4CfvTIr7jT4YesR2/F8STd7y6D0b4r/NmpPljRqPkDfSd/RL7tgJxOd j/feuHHEac+AP7o9Yt7h247m0q2mXJ07Up6wHWCd6pumJ99S2dL8UoYE0hsybhwFCf/g iELw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u6si11580791pfh.265.2019.04.02.12.54.32; Tue, 02 Apr 2019 12:54:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728741AbfDBTwA (ORCPT + 99 others); Tue, 2 Apr 2019 15:52:00 -0400 Received: from mx2.suse.de ([195.135.220.15]:34366 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726167AbfDBTwA (ORCPT ); Tue, 2 Apr 2019 15:52:00 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E9B4AAD63; Tue, 2 Apr 2019 19:51:58 +0000 (UTC) From: NeilBrown To: George Hilliard , Greg Kroah-Hartman Date: Wed, 03 Apr 2019 06:51:49 +1100 Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Matthias Brugger , Christian =?utf-8?Q?L=C3=BCtke-Stetzkam?= =?utf-8?Q?p?= , Nishad Kamdar , Sergej Perschin , John Crispin Subject: Re: [PATCH 03/16] staging: m57621-mmc: delete driver from the tree. In-Reply-To: References: <20190402103203.14959-1-gregkh@linuxfoundation.org> <20190402103203.14959-4-gregkh@linuxfoundation.org> Message-ID: <87r2ak18yy.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain On Tue, Apr 02 2019, George Hilliard wrote: > On Tue, Apr 2, 2019, 5:32 AM Greg Kroah-Hartman > wrote: > >> The license text in this driver is "interesting" and not really obvious >> that it is supposed to be able to be distributed in the kernel source >> tree. Yes, the MODULE_LICENSE() text says GPL, so it's probably ok, but >> to be safe, I am deleting this driver. I will be glad to add it back if >> the license is properly sorted out, but for now, this isn't worth the >> potential risk, I should have never taken it in the first place. >> > > So, for what it's worth, this driver has an obvious heritage of having been > modified from the main Mediatek MMC driver. Now, of course it's *possible* > to distribute GPL-incompatible changes to a GPL program, but the only > *compliant* way to distribute these changes would have been the GPL. > > So there's a very good chance that it's intended to be GPL. (Which is > good, because I need this driver!) I suppose we need to reach out to the > original contributor. People keep telling me that drivers/mmc/host/mtk-sd.c should be able to handle the same hardware as this driver, with a little bit of work. Unfortunately they haven't told me what the little bit of work involves. Have you explored that possibility at all? I might try to have a look if I can make time. NeilBrown --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEG8Yp69OQ2HB7X0l6Oeye3VZigbkFAlyjvVUACgkQOeye3VZi gbnYNhAAl32AjR7b/Bpums50JkMbYkj3zKbOqrhdqORyjtBYCGIbf8LrCv7nxEOj CqkPh9vkZKmvjpMZ13fa8trRW5R1AevNuUOZML0EPOolKitjR+SM0wfjnDG24f3x 3yFX57Js509+3ii2LUmLwtTAIbfPQverqBnr1cCQbYHVICRRs6o0ZIHM4To7SQVk +XDYgm4lSVjHUvZ7QqAod8xr/xh81S5NTMqC48iH1CsItZyNxl1m2DjNeOtw7SLl hQC4yFdrC+zhlQHaMSoYVOk0kfgXTJK9rb52I2I2QAgsqnHXas23yRCbRcGxLB3g NBnK14DJxVtYsEkVoCR5PcgVwq/jCgAe9UuMEX9/Ey3Pbn+ShlI1O+ckoyqiJtZv nH/Z/XR0gnuhhiMQOFDtzP6ZUjARYwH0DLUeiQQ9rK2JzmBy4yYfRPkzpWgMFpHO J50UsmxdO6AaqCU1ttq2MtT5yQV2lv24Qn6z3jhd0OPDaNW3W7bWX+gDZBS/X31b 8VJPaAsx282AHPvxMscdD5pGZ+gXSbGBFvWYbobnsjPhH9YsMaFxbPK39zE7tbw8 JRJm1IL0m35Iz4jBqIG0+U9T/zyibxAn44QlBkmgsjwP8cBnQjxHQKPRYx/v9cRy dDJlyzSRPZSiOoM8KaOdhbswO8/BkQktdPOjFx6Py9gsI00GaKQ= =vXHR -----END PGP SIGNATURE----- --=-=-=--