Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1671755yba; Tue, 2 Apr 2019 13:25:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqxuxYzxoWovor9bW3ZZ0XdiOTBz+iGoSb613gOKXaM1uTjdWM9GGdQ+/QMcep6Wi4OIuJTv X-Received: by 2002:a17:902:6bc5:: with SMTP id m5mr15620504plt.180.1554236724192; Tue, 02 Apr 2019 13:25:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554236724; cv=none; d=google.com; s=arc-20160816; b=EacpSSJMWWgMe3yDasCAN1HwISf45zSJ5jcdFp5xL70ZyzARoWw1Px34QMFHK5oo8V F+ZXLINccsazHxPZQwmd/QgKMl2xTlny0N0ZYk2j4n5DGwZH7pO38/K4s4HjC3ZYH7c+ oZBC1ULmKe8vteJyg7/A2SWSGIGPso+BG0liJtVYna0/8KD04KKOdEvSmKVVNpixZByc cY8s7yC/k+w4zR8P/TAFNw0lkeaivsMMGcJh7jQ/elCyvljjNxZGTWDdwC4AvoirxcKI j4b2s3sRALGIlyBtmraQ5ir/I0iRVu255S1atpFKm7lU03+SklGrO5Z9GWJQ9hLWrnKk ejxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:openpgp:from:references:cc:to :subject; bh=obNngiYq1K0DiOFYBlNkxR6EjJmqF885rXbEuNOXL4E=; b=r3yFSrM7hdjUllxXR9rfCxs3xKeSSV82ihp9FNsJjx3vGdoqKPKIU0fpYQKLwcgKlE c2+rv1dc6oyjb+bBK3qbMysb0zmYEy+MA4HMltBJbvPTuqXS52P109CdCIKYp+REcnfM Gn9ZdRGqZzHDRY5IAmU9SavlytJjJZ3PYiSUXg+77OY3s1XYTFntoVBV7C4MuaD8XsQe 34moIP4JFTZwt0d+wEUe2vaiAB4/92sUx8LZIQQSndNoi6hZzYH3bNmnLZch1yddJP+1 hVdexPqWwUkQ0JUk60WW4SbI2NGAVS4SHVE2fx3+RwITeNgkk3LmCseYK3J8J4nS9ggt 3JsA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w71si3817168pgd.470.2019.04.02.13.25.08; Tue, 02 Apr 2019 13:25:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726074AbfDBUY2 (ORCPT + 99 others); Tue, 2 Apr 2019 16:24:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50872 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725825AbfDBUY2 (ORCPT ); Tue, 2 Apr 2019 16:24:28 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 88AA081F18; Tue, 2 Apr 2019 20:24:27 +0000 (UTC) Received: from llong.remote.csb (dhcp-17-19.bos.redhat.com [10.18.17.19]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5B26D60856; Tue, 2 Apr 2019 20:24:26 +0000 (UTC) Subject: Re: fs/coda oops bisected to (925b9cd1b8) "locking/rwsem: Make owner store task pointer of last owni To: Jan Harkes Cc: Ingo Molnar , Peter Zijlstra , Alexander Viro , Pedro Cuadra Chamorro , linux-kernel@vger.kernel.org References: <20190331040023.qbx52lwzufkxg3kw@cs.cmu.edu> <497db260-fb1e-4b37-319f-6806df87f270@redhat.com> <20190331191347.irnmkv6ocwsq4r5r@cs.cmu.edu> <20190402191702.akrg64fqtqrnu7tr@cs.cmu.edu> From: Waiman Long Openpgp: preference=signencrypt Autocrypt: addr=longman@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFgsZGsBEAC3l/RVYISY3M0SznCZOv8aWc/bsAgif1H8h0WPDrHnwt1jfFTB26EzhRea XQKAJiZbjnTotxXq1JVaWxJcNJL7crruYeFdv7WUJqJzFgHnNM/upZuGsDIJHyqBHWK5X9ZO jRyfqV/i3Ll7VIZobcRLbTfEJgyLTAHn2Ipcpt8mRg2cck2sC9+RMi45Epweu7pKjfrF8JUY r71uif2ThpN8vGpn+FKbERFt4hW2dV/3awVckxxHXNrQYIB3I/G6mUdEZ9yrVrAfLw5M3fVU CRnC6fbroC6/ztD40lyTQWbCqGERVEwHFYYoxrcGa8AzMXN9CN7bleHmKZrGxDFWbg4877zX 0YaLRypme4K0ULbnNVRQcSZ9UalTvAzjpyWnlnXCLnFjzhV7qsjozloLTkZjyHimSc3yllH7 VvP/lGHnqUk7xDymgRHNNn0wWPuOpR97J/r7V1mSMZlni/FVTQTRu87aQRYu3nKhcNJ47TGY evz/U0ltaZEU41t7WGBnC7RlxYtdXziEn5fC8b1JfqiP0OJVQfdIMVIbEw1turVouTovUA39 Qqa6Pd1oYTw+Bdm1tkx7di73qB3x4pJoC8ZRfEmPqSpmu42sijWSBUgYJwsziTW2SBi4hRjU h/Tm0NuU1/R1bgv/EzoXjgOM4ZlSu6Pv7ICpELdWSrvkXJIuIwARAQABzR9Mb25nbWFuIExv bmcgPGxsb25nQHJlZGhhdC5jb20+wsF/BBMBAgApBQJYLGRrAhsjBQkJZgGABwsJCAcDAgEG FQgCCQoLBBYCAwECHgECF4AACgkQbjBXZE7vHeYwBA//ZYxi4I/4KVrqc6oodVfwPnOVxvyY oKZGPXZXAa3swtPGmRFc8kGyIMZpVTqGJYGD9ZDezxpWIkVQDnKM9zw/qGarUVKzElGHcuFN ddtwX64yxDhA+3Og8MTy8+8ZucM4oNsbM9Dx171bFnHjWSka8o6qhK5siBAf9WXcPNogUk4S fMNYKxexcUayv750GK5E8RouG0DrjtIMYVJwu+p3X1bRHHDoieVfE1i380YydPd7mXa7FrRl 7unTlrxUyJSiBc83HgKCdFC8+ggmRVisbs+1clMsK++ehz08dmGlbQD8Fv2VK5KR2+QXYLU0 rRQjXk/gJ8wcMasuUcywnj8dqqO3kIS1EfshrfR/xCNSREcv2fwHvfJjprpoE9tiL1qP7Jrq 4tUYazErOEQJcE8Qm3fioh40w8YrGGYEGNA4do/jaHXm1iB9rShXE2jnmy3ttdAh3M8W2OMK 4B/Rlr+Awr2NlVdvEF7iL70kO+aZeOu20Lq6mx4Kvq/WyjZg8g+vYGCExZ7sd8xpncBSl7b3 99AIyT55HaJjrs5F3Rl8dAklaDyzXviwcxs+gSYvRCr6AMzevmfWbAILN9i1ZkfbnqVdpaag QmWlmPuKzqKhJP+OMYSgYnpd/vu5FBbc+eXpuhydKqtUVOWjtp5hAERNnSpD87i1TilshFQm TFxHDzbOwU0EWCxkawEQALAcdzzKsZbcdSi1kgjfce9AMjyxkkZxcGc6Rhwvt78d66qIFK9D Y9wfcZBpuFY/AcKEqjTo4FZ5LCa7/dXNwOXOdB1Jfp54OFUqiYUJFymFKInHQYlmoES9EJEU yy+2ipzy5yGbLh3ZqAXyZCTmUKBU7oz/waN7ynEP0S0DqdWgJnpEiFjFN4/ovf9uveUnjzB6 lzd0BDckLU4dL7aqe2ROIHyG3zaBMuPo66pN3njEr7IcyAL6aK/IyRrwLXoxLMQW7YQmFPSw drATP3WO0x8UGaXlGMVcaeUBMJlqTyN4Swr2BbqBcEGAMPjFCm6MjAPv68h5hEoB9zvIg+fq M1/Gs4D8H8kUjOEOYtmVQ5RZQschPJle95BzNwE3Y48ZH5zewgU7ByVJKSgJ9HDhwX8Ryuia 79r86qZeFjXOUXZjjWdFDKl5vaiRbNWCpuSG1R1Tm8o/rd2NZ6l8LgcK9UcpWorrPknbE/pm MUeZ2d3ss5G5Vbb0bYVFRtYQiCCfHAQHO6uNtA9IztkuMpMRQDUiDoApHwYUY5Dqasu4ZDJk bZ8lC6qc2NXauOWMDw43z9He7k6LnYm/evcD+0+YebxNsorEiWDgIW8Q/E+h6RMS9kW3Rv1N qd2nFfiC8+p9I/KLcbV33tMhF1+dOgyiL4bcYeR351pnyXBPA66ldNWvABEBAAHCwWUEGAEC AA8FAlgsZGsCGwwFCQlmAYAACgkQbjBXZE7vHeYxSQ/+PnnPrOkKHDHQew8Pq9w2RAOO8gMg 9Ty4L54CsTf21Mqc6GXj6LN3WbQta7CVA0bKeq0+WnmsZ9jkTNh8lJp0/RnZkSUsDT9Tza9r GB0svZnBJMFJgSMfmwa3cBttCh+vqDV3ZIVSG54nPmGfUQMFPlDHccjWIvTvyY3a9SLeamaR jOGye8MQAlAD40fTWK2no6L1b8abGtziTkNh68zfu3wjQkXk4kA4zHroE61PpS3oMD4AyI9L 7A4Zv0Cvs2MhYQ4Qbbmafr+NOhzuunm5CoaRi+762+c508TqgRqH8W1htZCzab0pXHRfywtv 0P+BMT7vN2uMBdhr8c0b/hoGqBTenOmFt71tAyyGcPgI3f7DUxy+cv3GzenWjrvf3uFpxYx4 yFQkUcu06wa61nCdxXU/BWFItryAGGdh2fFXnIYP8NZfdA+zmpymJXDQeMsAEHS0BLTVQ3+M 7W5Ak8p9V+bFMtteBgoM23bskH6mgOAw6Cj/USW4cAJ8b++9zE0/4Bv4iaY5bcsL+h7TqQBH Lk1eByJeVooUa/mqa2UdVJalc8B9NrAnLiyRsg72Nurwzvknv7anSgIkL+doXDaG21DgCYTD wGA5uquIgb8p3/ENgYpDPrsZ72CxVC2NEJjJwwnRBStjJOGQX4lV1uhN1XsZjBbRHdKF2W9g weim8xU= Organization: Red Hat Message-ID: <4ef79a45-3e7c-99fd-dfae-08f2e34da8b0@redhat.com> Date: Tue, 2 Apr 2019 16:24:25 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190402191702.akrg64fqtqrnu7tr@cs.cmu.edu> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 02 Apr 2019 20:24:28 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/02/2019 03:17 PM, Jan Harkes wrote: > On Sun, Mar 31, 2019 at 03:13:47PM -0400, Jan Harkes wrote: >> On Sun, Mar 31, 2019 at 02:14:13PM -0400, Waiman Long wrote: >>> One possibility is that there is a previous reference to the memory >>> currently occupied by the spinlock. If the memory location is previously >>> part of a rwsem structure and someone is still using it, you may get >>> memory corruption. >> Ah, I hadn't even thought of that possibility. Good, it will open up > First of all, I have to thank you for your original patch because > otherwise I probably would never have discovered that something was > seriously wrong. Your patch made the problem visible. > > I ended up changing 'owner' to '_RET_IP_' and dumping the value of the > clobbered coda inode spinlock and surrounding memory and found that the > 'culprit' is in ext4_filemap_fault and despite it being in ext4, it is > still a Coda specific problem. It is good news that you have found the bug. However, I don't have sufficient expertise in the filesystem and mm areas to give you recommendation of what to do next. Cheers, Longman