Received: by 2002:a17:90a:8582:0:0:0:0 with SMTP id m2csp2418008pjn; Tue, 2 Apr 2019 16:10:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqxRTcRYSBQ5UMaNa1sCWRiO95visaT+zfgPL7A/3zHepxRLiim60aGLIQU5JA4cSSu3gZ/y X-Received: by 2002:a63:5b0a:: with SMTP id p10mr15388983pgb.282.1554246601676; Tue, 02 Apr 2019 16:10:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554246601; cv=none; d=google.com; s=arc-20160816; b=0PZhiGfl4P3nWLet1XGR69X1mQWVmZVIz8bFGE+KD53cEgEln7JmU5rYtQ3ojlfG6l J3WVBLPzWTDI6DoZ5QhwtwfqG9pP11kix1CE+wA/G/zl1ne/r0luf59/EJ4cGvQ9nNZV tNrto4Ettg6nV0dgDq6W8ct49oM7eisaeukNJ7rkGkpC6PEfiUTu+CiFQTlKfQoV9/Ld 2wasXDiYm5A3Gqd/yfH3JLTGIuO4WjyVq/z0Zz/nNtxLO7GYuU0b39LpZe95pGqOW1OS /JvpxPZI8LhveXorT2fKoi97/lDzgK4lMLhboZN4HZboQ1jelMO7zumgmLAzDcDyQsrt fHlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=3K+J9BI0O7tXsFAQNVmr2SWenC0jlBcrtVQvcYHk1ek=; b=YuKHcYnLaIUl/sJbbAlW4aeVaUS7YA3Mk4NpwNbydoUkcC6Q7cIvpUg3Y14jITWBOv rI1ApY0s2XpJXAjqPLaWN5DAARTiil9UYRDsq5vxY274Rm7kvxkW3wDNlHJr6f/FJ7JJ Vp3ZXiaPX+qgldZwAVSM8en1XT6/mfWTcLzr9gQ2OCkB4ZARuPtiNdFG/uAdm30qErdI V5INRiHUqZuFaFahV+9RaqHDNypFpKQTF3S1fN66R++Oioh4RRWVqQ/86aC0KM8/rZ5Z lObkA/JnMOTjXLgejuIgngXYIcbmVGHyPSqgTp1e/zH43EaC2spNvgG2BtfWMvZcpJt3 iWsA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i6si12090540pgj.329.2019.04.02.16.09.46; Tue, 02 Apr 2019 16:10:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727149AbfDBXHG (ORCPT + 99 others); Tue, 2 Apr 2019 19:07:06 -0400 Received: from smtp-out-no.shaw.ca ([64.59.134.12]:35384 "EHLO smtp-out-no.shaw.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726083AbfDBXHG (ORCPT ); Tue, 2 Apr 2019 19:07:06 -0400 X-Greylist: delayed 303 seconds by postgrey-1.27 at vger.kernel.org; Tue, 02 Apr 2019 19:07:06 EDT Received: from tethys.mmayer.net ([70.68.144.247]) by shaw.ca with ESMTP id BSQ7hVnFUldkPBSQ8hKtfe; Tue, 02 Apr 2019 17:02:20 -0600 X-Authority-Analysis: v=2.3 cv=Ko4zJleN c=1 sm=1 tr=0 a=5Vvn7CJLxh9yo+qVPaC6cg==:117 a=5Vvn7CJLxh9yo+qVPaC6cg==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=oexKYjalfGEA:10 a=Q-fNiiVtAAAA:8 a=T1uYfcNGi3NWnhI_G7IA:9 a=Fp8MccfUoT0GBdDC_Lng:22 Received: by tethys.mmayer.net (Postfix, from userid 501) id 606923010142F4; Tue, 2 Apr 2019 16:02:19 -0700 (PDT) From: Markus Mayer To: Brian Norris , Florian Fainelli , Gregory Fong Cc: Markus Mayer , Broadcom Kernel List , ARM Kernel List , Linux Kernel Mailing List Subject: [PATCH 2/6] memory: brcmstb: dpfe: report firmware loading error Date: Tue, 2 Apr 2019 16:00:59 -0700 Message-Id: <20190402230103.25491-3-code@mmayer.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190402230103.25491-1-code@mmayer.net> References: <20190402230103.25491-1-code@mmayer.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CMAE-Envelope: MS4wfG7BBBcP6EjPFGkZJ6NnQ/UxDUhNvoY4NFmA/YPwJ4gUw/YQC4y3ON5UH6lMQZyE4Yd7hoKvPacF2dwCk1PQE/BhSxh1zG6AWatNJ/03BhzG103wTtCg /TzyInFWeJiB1dQkp72N8YByWOtKXR6niUuLPEo6cbpP3vIVzLnPTUspW2CdngkU2IvAZcdmt1PqZdGAUCtp2mxmzNXVelNFFAk8WBdBGu9MVVf3w8QIGpV8 BCVZs5IJkCzGiePsRGmFCkqlNw17EKBHDozn7zftH9WkW41St+vYT++oKlTJIYzd9ZQbPHhzFbSrzNLoN9WZcP6Tqb4wGRQGwmyoOiyCH9J2/gwfnCmvI4Hl yLG4l2UZk8QKgooDiCixEQMPfpNgYL0V0yI7Vz+tMU9OihVGvpaRwbJkZPSwXjBI94SomFCLkZjNYqowlVdCbFxNWc2EAw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Mayer Print an error message if the DCPU firmware couldn't be downloaded. Signed-off-by: Markus Mayer --- drivers/memory/brcmstb_dpfe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c index f143e40e528b..c67774a4fe8b 100644 --- a/drivers/memory/brcmstb_dpfe.c +++ b/drivers/memory/brcmstb_dpfe.c @@ -703,8 +703,10 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev) } ret = brcmstb_dpfe_download_firmware(pdev, &init); - if (ret) + if (ret) { + dev_err(dev, "Couldn't download firmware -- %d\n", ret); return ret; + } ret = sysfs_create_groups(&pdev->dev.kobj, dpfe_groups); if (!ret) -- 2.17.1