Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 3 Apr 2019 04:40:53 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Morris Ku =?utf-8?B?5Y+k5paH5L+K?= <morris_ku@sunix.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] Add support for SUNIX Multi-I/O board
Message-ID: <20190403034053.GJ4187@dell>
References: <20190319120835.3840-1-saumah@gmail.com>
 <20190402062601.GX4187@dell>
 <HK2PR03MB45295EF1E814CE40BDFB798995560@HK2PR03MB4529.apcprd03.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <HK2PR03MB45295EF1E814CE40BDFB798995560@HK2PR03MB4529.apcprd03.prod.outlook.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Please do not drop the list from your recipients.

On Tue, 02 Apr 2019, Morris Ku 古文俊 wrote:

> Hello , Lee ,
> 
> 
> Sunix multi-io card is a composite device,
> contains serial and parallel port , before we
> trying to place the driver in the /drivers/char,
> but maintainer suggests go to /driver/mfd,so we move to here.
> this driver is special,it supports more than one interface,
> so we combine to a single driver.

The MFD subsystem is designed to register child devices.  MFD drivers
do not contain any true functionality themselves.  If this device does
multiple things, you can split the functionality into their relevant
subsystems and register each of them from here.

There are 10's of examples available.  Please take a look around some
of the existing drivers to see how their functionality is split.

> On Tue, 19 Mar 2019, Morris Ku wrote:
> 
> > Driver for SUNIX Multi-I/O card.Based on parport_pc.c, ppdev.c
> > and lp.c by Linus Torvalds, Theodore Ts'o.
> 
> Parallel port drivers should live in 'drivers/parport' and
> 'drivers/char'.  LP drivers should live in 'drivers/char'.
> 
> Please them there.
> 
> > Signed-off-by: Morris Ku <saumah@gmail.com>
> > ---
> >  mfd/sunix/snx_ieee1284.c     | 144 +++++++
> >  mfd/sunix/snx_ieee1284_ops.c | 258 +++++++++++++
> >  mfd/sunix/snx_lp.c           | 717 +++++++++++++++++++++++++++++++++++
> >  mfd/sunix/snx_lp.h           | 119 ++++++
> >  mfd/sunix/snx_parallel.c     | 397 +++++++++++++++++++
> >  mfd/sunix/snx_ppdev.c        | 454 ++++++++++++++++++++++
> >  mfd/sunix/snx_ppdev.h        |  15 +
> >  mfd/sunix/snx_share.c        | 629 ++++++++++++++++++++++++++++++
> >  8 files changed, 2733 insertions(+)
> >  create mode 100644 mfd/sunix/snx_ieee1284.c
> >  create mode 100644 mfd/sunix/snx_ieee1284_ops.c
> >  create mode 100644 mfd/sunix/snx_lp.c
> >  create mode 100644 mfd/sunix/snx_lp.h
> >  create mode 100644 mfd/sunix/snx_parallel.c
> >  create mode 100644 mfd/sunix/snx_ppdev.c
> >  create mode 100644 mfd/sunix/snx_ppdev.h
> >  create mode 100644 mfd/sunix/snx_share.c
> 

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog