Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1963638yba; Tue, 2 Apr 2019 21:08:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqzmjI+7UOYZI1jok/jGYIWkMCp2MoEMrmN4ZTvuHAk8Ca1Ic7zm+sAmCs2sAYQg1CUVfpmb X-Received: by 2002:a63:3185:: with SMTP id x127mr70314876pgx.299.1554264519565; Tue, 02 Apr 2019 21:08:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554264519; cv=none; d=google.com; s=arc-20160816; b=iK8YnVz+VQ8HnaBbsDJmmyujflPzWRjZYpPChQERNrzcAvmWtpZkufqdmdJAs9WZIG Ywupsd/o531K+7esx0nClHlD4bxwV/fxGOtkN4sOQ5eb0lRO0adV0BsQd07hvUL578Zf CvKhViJCSCVNDK9QbblcU3rul8tFVdIjXd0m3fkpLg1WILH4mwy0QBmwFOpeZcqUK4F6 NlpmxHk5RxV/qS5qwhdfEVcPL47ZRk2HAgjQOv3NiRXWW/CczKL1wG3CYvQ1zRqftHzD 2RoV+SSZiKDKga9vimjeI8hgHlwzgH4EI27GuWCR9Lwz6+U8+oIgQUi7Whl6+fBazWM4 k7Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=3QNUYX/6CiPJimN19TLvqEDYljNHcDYiKAec+w9jsk0=; b=FJI/11yI+tA56zGh4peT4jfBN2TEjN+BBOHgF0PoIC8i7heKg80PAiCvBMiplCnjVW KXxcvmmtOZdLqyRkzYib4DmBjq/7XQ3D+r6S40glhgWhJtW6HxiPDOyltvAHeiEBdcHy GR0ON6oBRjGEmOHb9M46HDSwU51MroDRY5RVUNee1FiTiBlSdaA2DiubC8VvfxZX+17o rB3BK5cbftRULRG9u+PkuQnNWm0EqUkLcQEaU2HDKp/ezSvxjrTbOHjNJCCm9xAVvtXT 5CBBgGvpmqkPwoMKs7GMyv72S86VvgfIkeGjoAgWdZcaByBDemvZEVdCURy5ID7uD0Cn YvCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=sZBLv6WX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a13si13486448pfn.70.2019.04.02.21.08.23; Tue, 02 Apr 2019 21:08:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=sZBLv6WX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726048AbfDCEHt (ORCPT + 99 others); Wed, 3 Apr 2019 00:07:49 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:33676 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbfDCEHs (ORCPT ); Wed, 3 Apr 2019 00:07:48 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x332sdmD077761; Wed, 3 Apr 2019 02:57:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=3QNUYX/6CiPJimN19TLvqEDYljNHcDYiKAec+w9jsk0=; b=sZBLv6WXTh457gmNEHTd1YdlrdH/4ikmI6AJk9owGon5CXXKpb4vCGwYSeYk1nfWtvSV F1MI7WOgl1beWefYY3+lRZnObzeCkocDH513AdPyuWEVeuB35ic9xTGdsnXkqvorJcLP 1wwdm0XLoNCzMq+bVsO05qQrGBdGKSTZa8aE2wm69CK1rIIT9zGSbmCQ52atxCWABUsK HoZPLetndXT3EtcErW9znz5QOIpZLfxWOxaw4WDqrDCdxRUKhyWJ6UbjDeDfrv873XRY sU1/ej4OwkHJImQVneXrS+/qdG6PXCVB0vGlFfacMv9XaF/TfR4H9WsrbSw5EZM6BT5Z fQ== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 2rj0dnnf22-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Apr 2019 02:57:36 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x332vYVc035843; Wed, 3 Apr 2019 02:57:36 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 2rm9mht0mv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Apr 2019 02:57:35 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x332vYwF011060; Wed, 3 Apr 2019 02:57:34 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 02 Apr 2019 19:57:33 -0700 To: Kanchan Joshi Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, axboe@fb.com, prakash.v@samsung.com, anshul@samsung.com, joshiiitr@gmail.com Subject: Re: [PATCH v3 7/7] fs/ext4,jbd2: add support for passing write-hint with journal From: "Martin K. Petersen" Organization: Oracle Corporation References: <1553846032-4451-1-git-send-email-joshi.k@samsung.com> <1553846032-4451-8-git-send-email-joshi.k@samsung.com> Date: Tue, 02 Apr 2019 22:57:31 -0400 In-Reply-To: <1553846032-4451-8-git-send-email-joshi.k@samsung.com> (Kanchan Joshi's message of "Fri, 29 Mar 2019 13:23:52 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9215 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=597 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904030016 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9215 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=642 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904030016 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kanchan, > For NAND based SSDs, mixing of data with different life-time reduces > efficiency of internal garbage-collection. During FS operations, > series of journal updates will follow/precede series of data/meta > updates, causing intermixing inside SSD. By passing a write-hint with > journal, its write can be isolated from other data/meta writes, > leading to endurance/performance benefit on SSD. Why not just introduce REQ_JOURNAL and let the device driver decide how to turn that into something appropriate for the device? That's what I'll need for SCSI. Existing SCSI streams are not a good fit. -- Martin K. Petersen Oracle Linux Engineering