Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190329165201.16233-1-afd@ti.com> <24aa0897-8f23-f747-d9a4-d5272f37beea@gmail.com>
In-Reply-To: <24aa0897-8f23-f747-d9a4-d5272f37beea@gmail.com>
From:   Sumit Semwal <sumit.semwal@linaro.org>
Date:   Wed, 3 Apr 2019 13:30:55 +0700
Message-ID: <CAO_48GHOi7fbG3E9pgrs0_ymUYFaEQmPt_cmQBQ1ZAXz6O4dDA@mail.gmail.com>
Subject: Re: [PATCH] dma-buf: Make mmap callback actually optional
To:     Christian Koenig <christian.koenig@amd.com>
Cc:     "Andrew F. Davis" <afd@ti.com>,
        LKML <linux-kernel@vger.kernel.org>,
        DRI mailing list <dri-devel@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Andrew,

On Mon, 1 Apr 2019 at 20:38, Christian K=C3=B6nig
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> Am 29.03.19 um 17:52 schrieb Andrew F. Davis:
> > The docs state the callback is optional but it is not, make it optional=
.
> >
> > Signed-off-by: Andrew F. Davis <afd@ti.com>
>
> Reviewed-by: Christian K=C3=B6nig <christian.koenig@amd.com>

Thanks for the patch; I will queue it up within this week (at a
conference atm, but will squeeze out time for doing this).

>
> > ---
> >   drivers/dma-buf/dma-buf.c | 11 +++++++++--
> >   1 file changed, 9 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
> > index 7c858020d14b..4d4ae9fe9ac8 100644
> > --- a/drivers/dma-buf/dma-buf.c
> > +++ b/drivers/dma-buf/dma-buf.c
> > @@ -90,6 +90,10 @@ static int dma_buf_mmap_internal(struct file *file, =
struct vm_area_struct *vma)
> >
> >       dmabuf =3D file->private_data;
> >
> > +     /* check if buffer supports mmap */
> > +     if (!dmabuf->ops->mmap)
> > +             return -EINVAL;
> > +
> >       /* check for overflowing the buffer's size */
> >       if (vma->vm_pgoff + vma_pages(vma) >
> >           dmabuf->size >> PAGE_SHIFT)
> > @@ -404,8 +408,7 @@ struct dma_buf *dma_buf_export(const struct dma_buf=
_export_info *exp_info)
> >                         || !exp_info->ops
> >                         || !exp_info->ops->map_dma_buf
> >                         || !exp_info->ops->unmap_dma_buf
> > -                       || !exp_info->ops->release
> > -                       || !exp_info->ops->mmap)) {
> > +                       || !exp_info->ops->release)) {
> >               return ERR_PTR(-EINVAL);
> >       }
> >
> > @@ -906,6 +909,10 @@ int dma_buf_mmap(struct dma_buf *dmabuf, struct vm=
_area_struct *vma,
> >       if (WARN_ON(!dmabuf || !vma))
> >               return -EINVAL;
> >
> > +     /* check if buffer supports mmap */
> > +     if (!dmabuf->ops->mmap)
> > +             return -EINVAL;
> > +
> >       /* check for offset overflow */
> >       if (pgoff + vma_pages(vma) < pgoff)
> >               return -EOVERFLOW;
>

Best,
Sumit.