Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2080958yba; Wed, 3 Apr 2019 00:28:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqw7yTIZ3eQ1qg+LY9EGnFbKPfQXaa7dX1w7CnbRScJ124DHv0cQCQlSkYWtHFz1eg5spU5P X-Received: by 2002:a62:14c3:: with SMTP id 186mr73843589pfu.21.1554276501955; Wed, 03 Apr 2019 00:28:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554276501; cv=none; d=google.com; s=arc-20160816; b=wnawkUCeewAtEptDsBCskTTkDEcX96dzbn2zVJrQuZ+m7OZi5YIDRMi1OYh4bLlCJY ZSSeQepkm3lk2qXLsA2zQnqaknRaeN7seKCCmdUfS6fpGDqq6Db03XgnmvRbcOlVRHAo mzN37/0ek8YxdN8Z9QcYzwM3q0tIL6HjQkWIeXzJixZRK0cGjr13k3DLo60kk+0apak4 Q2MerOIIKtLEfuAaDmVTpVYj/5rj2VU0uvGY7XJmRGXOZxxqPMeHuNuJmWYe+OMWbeHg rYGcCv4XVjdjF39TU8MsAiEsEWEo8eudPcn8Q36YWY+sfPS+WenFdA7Byo1ENy4lI3zS 3U1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=zj97QIezZq1a3rNuxhvxcNyp2HhbWzu18kzcL3vIAWk=; b=yvvZMri89YWM7gQyYH5uQYo1XzjzpdaxXIDEnnoRZHrT83TH2z9EaRsf+awA1YQEUs kaqh6P3q7iYOecfgdOuOsWyEomiJ4WcCTCUUqE+O4Kup+ltYh8Cyt5CQjk3iBH1vN0XY Nb6u4hNvHCJ5DC0RtdMP/ua96gYsT78pcWz4il81gN1jTnuTXanrOR8ScRuW/ue1WhI6 3tAJCoCpITp5KW3GnV8whqpC7knPQj2GnWSf/1SMp4huYqqYwC8Dka6GBvBBvnD8xIpD V8Qt/0FHG60BJdxgbpwQ3sZ/36qg1HLp2GeZweLRs7MFWRt3AWEGBVZfsvlocLiaX5w8 xQag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=Ntt6PqCi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b74si13003338pfj.121.2019.04.03.00.28.06; Wed, 03 Apr 2019 00:28:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=Ntt6PqCi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726882AbfDCHZr (ORCPT + 99 others); Wed, 3 Apr 2019 03:25:47 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:41523 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725936AbfDCHZr (ORCPT ); Wed, 3 Apr 2019 03:25:47 -0400 Received: by mail-io1-f67.google.com with SMTP id v10so13204420iom.8 for ; Wed, 03 Apr 2019 00:25:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zj97QIezZq1a3rNuxhvxcNyp2HhbWzu18kzcL3vIAWk=; b=Ntt6PqCi2qMeVuvMm1s4qW2NsFYtx6Xz8c4Ubm/VfGgX9wVKG2qqugqqL2XQK5wzTj dEtjeXS6cuYAR1xz5Lb05eCipGWp/7yIDSEwTuBpDPdhLEBH/33Xe1Qv1mlaXhDfhIDE x41cqptbvTk02s1S1xb4CzqLjsuO1LsyejRGs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zj97QIezZq1a3rNuxhvxcNyp2HhbWzu18kzcL3vIAWk=; b=Ysf1GsQfqCOlqhare8pfsfZD+w2YmozlWN6tSw3JoHZRoqUc0iVYFSKpa7WxD+b8do o/ddGPcasr77EDs+i6+rswLVxPzl2iQA1XMmQ+cMqYeA5c141FNhe4lgTdYCUiGt4Bv5 ySFZWTB1CAoObLpxE6cEEQ78zTiiIQtgF4UbP+wWifw2CwRvJCAsYXN4dO3woSuD5uNb 9IGuzT9e2yyDYpnFbIoqkFqvOrdxEQ2xaLiWqPxcBZKKmIo7cgAdK8RH5Hr7l0YUYyau 1Fz5YhSU6HfV4YwVy7KXMpT6FH9BJ7Ajlx1WhG6lHqbsUrRLiuJ/0VXI6f+0RE9+zOTX TPYQ== X-Gm-Message-State: APjAAAXi6DmtNiPBOZATqvrF7snsqS32R5Kj1SML09lsdfsJNdTBeH7G 9MihdhYWRSrGl7Al84isnuztKz0K8JpKouatekoCxg== X-Received: by 2002:a6b:7519:: with SMTP id l25mr39357802ioh.51.1554276346499; Wed, 03 Apr 2019 00:25:46 -0700 (PDT) MIME-Version: 1.0 References: <20190314114500.8336-1-kraxel@redhat.com> <33cf37dc-8456-0316-0b48-fca7c92caa28@samsung.com> <20190402204325.cqu7fobzekd3ccls@sirius.home.kraxel.org> <20190403072238.76gwp6rfumgqiely@sirius.home.kraxel.org> In-Reply-To: <20190403072238.76gwp6rfumgqiely@sirius.home.kraxel.org> From: Daniel Vetter Date: Wed, 3 Apr 2019 09:25:35 +0200 Message-ID: Subject: Re: [PATCH] fbdev: list all pci memory bars as conflicting apertures To: Gerd Hoffmann Cc: Bartlomiej Zolnierkiewicz , dri-devel , "open list:FRAMEBUFFER LAYER" , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 3, 2019 at 9:22 AM Gerd Hoffmann wrote: > > On Wed, Apr 03, 2019 at 08:48:16AM +0200, Daniel Vetter wrote: > > On Tue, Apr 2, 2019 at 10:43 PM Gerd Hoffmann wrote: > > > > > > On Tue, Apr 02, 2019 at 02:09:45PM +0200, Daniel Vetter wrote: > > > > On Mon, Apr 1, 2019 at 4:00 PM Bartlomiej Zolnierkiewicz > > > > wrote: > > > > > > > > > > > > > > > On 03/14/2019 12:45 PM, Gerd Hoffmann wrote: > > > > > > Simply add all pci memory bars to struct apertures_struct in > > > > > > remove_conflicting_pci_framebuffers(), without depending on the > > > > > > res_id parameter. > > > > > > > > > > > > The plan is to drop the res_id parameter later on. For now keep the > > > > > > parameter, use it for sanity-checking and warn on inconsistencies. > > > > > > > > > > > > Signed-off-by: Gerd Hoffmann > > > > > > Reviewed-by: Daniel Vetter > > > > > > > > > > Patch queued for v5.2, thanks. > > > > > > > > Might be good to also stuff this into drm (double merge or topic > > > > branch, whatever you prefer), since that's where all the users are. > > > > Gerd also has some follow-up patches to apply on top of this one iirc. > > > > > > No follow-up patches yet. Plan is to wait a bit, see if the > > > sanity-checks trigger, and if all goes well go drop the res_id > > > parameter in 5.3 ... > > > > Hm I thought you had a patch to convert i915 over. Or did that land already? > > Ah, *that* one. Yep, that is still sitting in a branch here. Didn't > rebase it yet. But I suspect it will be easier to first drop res_id > and then rebase the i915 patch on top of *that*, so I don't have to > figure which i915 revision needs which res_id ... Ok, sounds like a plan for 5.3 somewhen. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch