Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp11294yba; Wed, 3 Apr 2019 03:28:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqy5NBx/6UgBjzsUr5MrG34d3GdOg3b0NVE2CD/p7o8DF9pKbfLktoD3FmmQBNvJI/BQNqDS X-Received: by 2002:a17:902:9048:: with SMTP id w8mr12216956plz.195.1554287313517; Wed, 03 Apr 2019 03:28:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554287313; cv=none; d=google.com; s=arc-20160816; b=SxDbrrS9nvDELE1d2dUGDsZ1fCIqS/7j5jsjPEfnFPr/l5xhuuW684zLC91CYDzMjB soVB82TrFGVSsc/NMGVQaYnUkMiKD8UO4/pF9sMlLkbkG9mMfsYCqEbeGg2OX+tBtgdL c6ey8uG+nonusYSdFoBCeQjTK1o6vshMKkKKE6BLhG8z9g5FSY5LrAM6q/Tj0cmpEDvf UB2r61Q/QkkGNumDOkmD5lwJNRVzGtxIta5zHXWs0MkrxMZHi7MaKCtDpvAShR1dL1us Q1Z8QuE61NtF0Xq3CchGCaHiR1HbZ1zgKq5lXSX+Ft0ifgmC5liS9lJh65xb5o9Da9bt LuqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=4Qo5E60A3XcOjveoA1Ykii6rzkapdxdhhdM2S6ugoy0=; b=XgL8TYDPCzser7RrJTw4Dn92/fvy4vAOo92Bh8tCGysCklB1GRDj5FfpSLCjDfSh8J 9icLqXXi8H62eXYQVvM7MDaYyJ5kaigV/uPkvv9tFkgL55GJ5Mt+c6i5NgbYnvpd5D5D 2A4UdqFYr83HXnyiX+/WpWAr1xMlExAYFBMl2bbTenEQgRcunFm6Ba15aZ1u+viRcKWm 5+ytMHUCUvAHqbjJ8MPdSaHB8KeytFWqBTpAXrWgNMfeXN8Cs5FlVch9kAnmph85O4GA gxWVIb+omLx+l7/s+QigpV9+2tE+OWEn/Z/gaq7V+CNpJs0J9a7TCkEhKyc39p3B6PJV PIFA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d6si13784361pfh.177.2019.04.03.03.28.18; Wed, 03 Apr 2019 03:28:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726606AbfDCK1m (ORCPT + 99 others); Wed, 3 Apr 2019 06:27:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34042 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726183AbfDCK1m (ORCPT ); Wed, 3 Apr 2019 06:27:42 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 409FB8552A; Wed, 3 Apr 2019 10:27:42 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-22.ams2.redhat.com [10.36.116.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id E0BB8100034B; Wed, 3 Apr 2019 10:27:41 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 0B93F16E30; Wed, 3 Apr 2019 12:27:41 +0200 (CEST) Date: Wed, 3 Apr 2019 12:27:40 +0200 From: Gerd Hoffmann To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= Cc: Daniel Vetter , David Airlie , Dave Airlie , open list , dri-devel , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" Subject: Re: [PATCH] drm/cirrus: rewrite and modernize driver. Message-ID: <20190403102740.qc3hlfchd7eogx44@sirius.home.kraxel.org> References: <20190403072318.31507-1-kraxel@redhat.com> <20190403085341.2cxdgxqrjlwecx3n@sirius.home.kraxel.org> <0c959f3a-15e9-8295-dc11-2f6b9a4229ac@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0c959f3a-15e9-8295-dc11-2f6b9a4229ac@tronnes.org> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 03 Apr 2019 10:27:42 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > > So I can just remove cirrus_fb_dirty() and hook up > > drm_atomic_helper_dirtyfb() instead. Easy ;) > > You can even use drm_gem_fb_create_with_dirty() instead of > drm_gem_fb_create_with_funcs(). Ah, cool. /me happily continues removing code lines. thanks, Gerd PS: incremental fixups are at https://git.kraxel.org/cgit/linux/log/?h=drm-rewrite-cirrus