Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp116336yba; Wed, 3 Apr 2019 05:41:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqxJoA6ni3xYbFCIegO2wa4zAxssx35glnOaBZEC3d/YW3KacU8C4YtZ1jHQ+yVGTZsaJ0fP X-Received: by 2002:a63:1d26:: with SMTP id d38mr41985463pgd.357.1554295305511; Wed, 03 Apr 2019 05:41:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554295305; cv=none; d=google.com; s=arc-20160816; b=oGF4XaD9jPFgkQMdewsY7ukbEpglOj6qo8KpdevIJKvRzM0LAHXtpT+jVhZV484vlC fCk++SUTNFnsu/vfgjHtZY0iOdr9osd1fedn4paovYKxU/YEjUassLnstLFV0Lxorv1C 4UlZy/6a0wGY4lsZc/1bsU7NdWrS9DER01fW90PHaKGhOITqSzX8lAGmsF/SpR0iqFwX iPuy1NEBYVRv20tClM2ZKimcgoeShXZFjBGltQBo7wj+niysd5IXFswJkxQfWuWKRON0 mff4RLTUhd+wYVXFm9I/AQ6yb6aGQVjlX6HuvUF2CL7AKWXaWhlMn3YXUUkDJqgkKRC/ NXhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=XGkK6yE9qlFkOP6mYowd5HQkB/AUi7Ds2dNy7PnDU6c=; b=0Ux5yxwVKPsu1LLWCs06qoOh5kfEviIyRIEtWuHUYocUZcbW8Q+l8QpyrtH9+yMfaC SZOjzJ8TYjQ/mDGNujZsh9xz09CQruGR5CC4T9Prrp1CTLRQ0Tvj00WTICkiyz/c/hZd ga4U/Z3hjOu/ENb4+vhBp1VZpa+iKvFfNxaJcfmx9W8giHBUBbjlEObZo5XjWppwlC/6 goGRUd77yZvDji0CeN4r0gLU7U3uj5ejN23m5/EFhoro2ZdCISbVMKS+YnhhGWSuVhg4 SdLu1ni7K6ryZ13Um/JBFDhvAGsH6NsasqRWtreE5SoVteKOOy5N5RvVqaufGaA3yafB 4uiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g10si13517236pgs.397.2019.04.03.05.41.30; Wed, 03 Apr 2019 05:41:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726827AbfDCMkp (ORCPT + 99 others); Wed, 3 Apr 2019 08:40:45 -0400 Received: from sauhun.de ([88.99.104.3]:48350 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726690AbfDCMkl (ORCPT ); Wed, 3 Apr 2019 08:40:41 -0400 Received: from localhost (p54B3311F.dip0.t-ipconnect.de [84.179.49.31]) by pokefinder.org (Postfix) with ESMTPSA id EE0B03E43D2; Wed, 3 Apr 2019 14:40:39 +0200 (CEST) From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peter Rosin , Stefan Lengfeld , linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org, Linus Walleij , Andy Shevchenko , Wolfram Sang Subject: [PATCH 10/12] i2c: stu300: use xfer_atomic callback to bail out early Date: Wed, 3 Apr 2019 14:40:17 +0200 Message-Id: <20190403124019.8947-11-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190403124019.8947-1-wsa+renesas@sang-engineering.com> References: <20190403124019.8947-1-wsa+renesas@sang-engineering.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the new callback to reject atomic transfers. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-stu300.c | 25 ++++++++++--------------- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/i2c/busses/i2c-stu300.c b/drivers/i2c/busses/i2c-stu300.c index 5503fa171df0..743c161b22c5 100644 --- a/drivers/i2c/busses/i2c-stu300.c +++ b/drivers/i2c/busses/i2c-stu300.c @@ -328,12 +328,6 @@ static int stu300_start_and_await_event(struct stu300_dev *dev, { int ret; - if (unlikely(irqs_disabled())) { - /* TODO: implement polling for this case if need be. */ - WARN(1, "irqs are disabled, cannot poll for event\n"); - return -EIO; - } - /* Lock command issue, fill in an event we wait for */ spin_lock_irq(&dev->cmd_issue_lock); init_completion(&dev->cmd_complete); @@ -380,13 +374,6 @@ static int stu300_await_event(struct stu300_dev *dev, { int ret; - if (unlikely(irqs_disabled())) { - /* TODO: implement polling for this case if need be. */ - dev_err(&dev->pdev->dev, "irqs are disabled on this " - "system!\n"); - return -EIO; - } - /* Is it already here? */ spin_lock_irq(&dev->cmd_issue_lock); dev->cmd_err = STU300_ERROR_NONE; @@ -846,6 +833,13 @@ static int stu300_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, return num; } +static int stu300_xfer_todo(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) +{ + /* TODO: implement polling for this case if need be. */ + WARN(1, "%s: atomic transfers not implemented\n", dev_name(&adap->dev)); + return -EOPNOTSUPP; +} + static u32 stu300_func(struct i2c_adapter *adap) { /* This is the simplest thing you can think of... */ @@ -853,8 +847,9 @@ static u32 stu300_func(struct i2c_adapter *adap) } static const struct i2c_algorithm stu300_algo = { - .master_xfer = stu300_xfer, - .functionality = stu300_func, + .master_xfer = stu300_xfer, + .master_xfer_atomic = stu300_xfer_todo, + .functionality = stu300_func, }; static const struct i2c_adapter_quirks stu300_quirks = { -- 2.11.0