Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp117715yba; Wed, 3 Apr 2019 05:43:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqzU82TayiKyMsVLhuL+A/y1863Iz5Kq6PJK0UYqQe+nfSEUDPG8KpsFsMlmvttAxiD+HY/t X-Received: by 2002:a65:6259:: with SMTP id q25mr44955886pgv.103.1554295407416; Wed, 03 Apr 2019 05:43:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554295407; cv=none; d=google.com; s=arc-20160816; b=TiLf3+mn6N2g0eM4AzZkfx1uCdftmfM+pF9DSVdQENiA+vAra8JgY2PKtsI8uJvJJz +QEOeMV1iBEfvjJA4D6FxNbBmeEJnseHL8c4wAO/MJXgEo+i28MZMhiU/GLPRCSO0hnC sQuMAZpj374Zx50GDGizoN79OP3hbJYDEZHlYYK0J8Aw4uVI1gBOrnNNWBbuvAaJVhlV E+1fy+rYaTBPyFFWYv9JPSGvg8ZqUBoKF1MkaGYehVWIDXFeTqj6+fE1IpsbCNs7FEiw MBPR7P5oSqnIlfkZxMOQlRqozlHE0yu/9hVsLcKBLbJgUruuSFf++PFN11UAXpWoya89 33TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=HHCQknUlk1s91rdts1RLWnDCehRa4Ui4ar5D3yntLlo=; b=axKYOjLcVRtlAmpQ2dSmrYRbjoX+MAkFmdIme8BGR9FZXDs+ZAG/Q5iGho7dnPcgO/ VC8EaeoLhIDxYWC7JErB2G1WDbVvDCFeoETVOVlqYA8+wL1AmE0RMr0Pwhn4eqSToH0D S2Ap9vJjIseeUGZo6/OBk9lXtn4Jyg4tfH++Lh23gGbr11E476wB2IIqZDFl4zHzXxpv L5fMgjkI2UjeMI+LzWRfN+f29tUWobhiaCpV2aOjfp6jKgbob2eN6/Di4qPsTQqlTZ4s bpROJvtT2kxzpfImXskY9SowE4bCd/zZL8CrVV3hkhz5hNuQBpS79RtXBef1UCbqpnii JD4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bc4si4246925plb.246.2019.04.03.05.43.11; Wed, 03 Apr 2019 05:43:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728192AbfDCMly (ORCPT + 99 others); Wed, 3 Apr 2019 08:41:54 -0400 Received: from sauhun.de ([88.99.104.3]:48300 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726155AbfDCMkh (ORCPT ); Wed, 3 Apr 2019 08:40:37 -0400 Received: from localhost (p54B3311F.dip0.t-ipconnect.de [84.179.49.31]) by pokefinder.org (Postfix) with ESMTPSA id 870A23E4246; Wed, 3 Apr 2019 14:40:35 +0200 (CEST) From: Wolfram Sang To: linux-i2c@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peter Rosin , Stefan Lengfeld , linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org, Linus Walleij , Andy Shevchenko , Wolfram Sang Subject: [PATCH 02/12] i2c: core: use I2C locking behaviour also for SMBUS Date: Wed, 3 Apr 2019 14:40:09 +0200 Message-Id: <20190403124019.8947-3-wsa+renesas@sang-engineering.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190403124019.8947-1-wsa+renesas@sang-engineering.com> References: <20190403124019.8947-1-wsa+renesas@sang-engineering.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If I2C transfers are executed in atomic contexts, trylock is used instead of lock. This behaviour was missing for SMBUS, although a lot of transfers are of SMBUS type, either emulated or direct. So, factor out the locking routine into a helper and use it for I2C and SMBUS. Signed-off-by: Wolfram Sang --- drivers/i2c/i2c-core-base.c | 11 +++-------- drivers/i2c/i2c-core-smbus.c | 7 ++++++- drivers/i2c/i2c-core.h | 12 ++++++++++++ 3 files changed, 21 insertions(+), 9 deletions(-) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index f8502064cd6b..ad14f38a67e4 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -1946,14 +1946,9 @@ int i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) * one (discarding status on the second message) or errno * (discarding status on the first one). */ - if (i2c_in_atomic_xfer_mode()) { - ret = i2c_trylock_bus(adap, I2C_LOCK_SEGMENT); - if (!ret) - /* I2C activity is ongoing. */ - return -EAGAIN; - } else { - i2c_lock_bus(adap, I2C_LOCK_SEGMENT); - } + ret = __i2c_lock_bus_helper(adap); + if (ret) + return ret; ret = __i2c_transfer(adap, msgs, num); i2c_unlock_bus(adap, I2C_LOCK_SEGMENT); diff --git a/drivers/i2c/i2c-core-smbus.c b/drivers/i2c/i2c-core-smbus.c index 132119112596..357e083e8f45 100644 --- a/drivers/i2c/i2c-core-smbus.c +++ b/drivers/i2c/i2c-core-smbus.c @@ -20,6 +20,8 @@ #include #include +#include "i2c-core.h" + #define CREATE_TRACE_POINTS #include @@ -530,7 +532,10 @@ s32 i2c_smbus_xfer(struct i2c_adapter *adapter, u16 addr, { s32 res; - i2c_lock_bus(adapter, I2C_LOCK_SEGMENT); + res = __i2c_lock_bus_helper(adapter); + if (res) + return res; + res = __i2c_smbus_xfer(adapter, addr, flags, read_write, command, protocol, data); i2c_unlock_bus(adapter, I2C_LOCK_SEGMENT); diff --git a/drivers/i2c/i2c-core.h b/drivers/i2c/i2c-core.h index 9d8526415b26..deea47c576e5 100644 --- a/drivers/i2c/i2c-core.h +++ b/drivers/i2c/i2c-core.h @@ -39,6 +39,18 @@ static inline bool i2c_in_atomic_xfer_mode(void) return system_state > SYSTEM_RUNNING && irqs_disabled(); } +static inline int __i2c_lock_bus_helper(struct i2c_adapter *adap) +{ + int ret = 0; + + if (i2c_in_atomic_xfer_mode()) + ret = i2c_trylock_bus(adap, I2C_LOCK_SEGMENT) ? 0 : -EAGAIN; + else + i2c_lock_bus(adap, I2C_LOCK_SEGMENT); + + return ret; +} + #ifdef CONFIG_ACPI const struct acpi_device_id * i2c_acpi_match_device(const struct acpi_device_id *matches, -- 2.11.0