Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 3 Apr 2019 15:12:13 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Vincent Whitchurch <vincent.whitchurch@axis.com>
Cc:     jslaby@suse.com, linux-kernel@vger.kernel.org,
        Vincent Whitchurch <rabinv@axis.com>
Subject: Re: [PATCH] tty: Add NULL TTY driver
Message-ID: <20190403131213.GA4246@kroah.com>
References: <20190403113327.3628-1-vincent.whitchurch@axis.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190403113327.3628-1-vincent.whitchurch@axis.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 03, 2019 at 01:33:27PM +0200, Vincent Whitchurch wrote:
> If no console driver is enabled (or if a non-present driver is selected
> with something like console=null in an attempt to disable the console),
> opening /dev/console errors out, and init scripts and other userspace
> code that relies on the existence of a console will fail.  Symlinking
> /dev/null to /dev/console does not solve the problem since /dev/null
> does not behave like a real TTY.
> 
> To just provide a dummy console to userspace when no console driver is
> available or desired, add a ttynull driver which simply discards all
> writes.  It can be chosen on the command line in the standard way, i.e.
> with console=ttynull.

If they have a broken system that sets "console=null", why would they
know to fix it to be "console=ttynull"?

I'm all for adding new functionality, but to provide kernel code because
userspace just isn't configured properly, that feels really wrong to me.

Now if this were to be the "default" if nothing is set up at all, that
might make a bit more sense, but as-is, this doesn't seem very useful.

thanks,

greg k-h