Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 3 Apr 2019 15:40:08 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Catalin Marinas <catalin.marinas@arm.com>
Cc:     Pavel Machek <pavel@ucw.cz>, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, James Morse <james.morse@arm.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Will Deacon <will.deacon@arm.com>,
        Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 4.4 078/131] PM / Hibernate: Call flush_icache_range() on
 pages restored in-place
Message-ID: <20190403134008.GA6963@kroah.com>
References: <20190401170051.645954551@linuxfoundation.org>
 <20190401170058.681712612@linuxfoundation.org>
 <20190401203918.GA26671@amd>
 <20190403110051.GB34351@arrakis.emea.arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190403110051.GB34351@arrakis.emea.arm.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 03, 2019 at 12:00:51PM +0100, Catalin Marinas wrote:
> On Mon, Apr 01, 2019 at 10:39:18PM +0200, Pavel Machek wrote:
> > On Mon 2019-04-01 19:02:28, Greg Kroah-Hartman wrote:
> > > 4.4-stable review patch.  If anyone has any objections, please let me know.
> > > 
> > > ------------------
> > > 
> > > [ Upstream commit f6cf0545ec697ddc278b7457b7d0c0d86a2ea88e ]
> > > 
> > > Some architectures require code written to memory as if it were data to be
> > > 'cleaned' from any data caches before the processor can fetch them as new
> > > instructions.
> > > 
> > > During resume from hibernate, the snapshot code copies some pages directly,
> > > meaning these architectures do not get a chance to perform their cache
> > > maintenance. Modify the read and decompress code to call
> > > flush_icache_range() on all pages that are restored, so that the restored
> > > in-place pages are guaranteed to be executable on these architectures.
> > > 
> > > Signed-off-by: James Morse <james.morse@arm.com>
> > > Acked-by: Pavel Machek <pavel@ucw.cz>
> > > Acked-by: Rafael J. Wysocki <rjw@rjwysocki.net>
> > > Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> > > [will: make clean_pages_on_* static and remove initialisers]
> > > Signed-off-by: Will Deacon <will.deacon@arm.com>
> > > Signed-off-by: Sasha Levin <sashal@kernel.org>
> > 
> > I don't think this is suitable for stable.
> > 
> > Catalin: Are there platforms that a) need this and b) support
> > hibernation in 4.4.X?
> 
> Good point. This commit was required for the arm64 hibernate support
> that went in the 4.7 kernel.
> 
> Greg, why was this patch selected for stable? It's harmless anyway.

It came in through Sasha's "magic patch selection AI" tools :)

If it's harmless, might as well leave it in now, and not revert it.

thanks,

greg k-h