Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp298033yba; Wed, 3 Apr 2019 08:57:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqxyA+gMYHuy3UlZDgMJUl5fKfonAf5od258XsUKxOrlzqIrEDoxFdFfmD009OJLqMoDwrNA X-Received: by 2002:a63:5f05:: with SMTP id t5mr422316pgb.176.1554307022617; Wed, 03 Apr 2019 08:57:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554307022; cv=none; d=google.com; s=arc-20160816; b=oNUgjYCDtG6gqz2mq8D06zK5K2zAdRUWygFbPKrLAN9c2j0V6QGO8vukudbJZVMjUY z2AzJn5zsDk3sG48H97qKQmtKxZQcQriSDuHd0OhyAEcV/Nup54PaLCMBEdbOGtGNWWb U/B7JgLd9zPNU6GGzbfWn++j9RXIfyQjF7vx1p14NsMDHGn3NuKjBXqP8OdzvdD1BtpS DVUVY0QLHD3dlyU72F3srifUOkjcx9hIoJx1phIZCnLW2WS2mZ/i7NizVNSJiRACH1l/ CAtNyCKFsTuBQQ9EM++qRAsH7B4cMZZYSzjT/RVYfDEVI0pYu/jfJ6o8Ws5bynxTZDu1 vVsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:cc:to:subject:from:date:dkim-signature; bh=smtmugjUengH7o/rPhG39S10hJLY2XSkPxiSSe6Erv4=; b=mUdw6SbZaBLqAehNsfVNPoV5PYAxn14yljMenRPy1SA3SRkXP7jleRDGBpe7AhmdOF lUz5Th/1geZsyfaNGsdEmsXQLuDqZ0HND9LmF96VMnGTYTpR5rROMaBwB5+kairLqmY5 drAOd2uuv9uCJOhxkQ63WTV2GkbTDt8j5atVV6eoXIR8TMbY4Dl3TR0p/VfOco/nA2Bj RMDZILf9XvLyAN8O7EQky9r7Nj6IVhRyOdmsfy4oUhz4AOxQvPVzxdSYsemzhxNHFEv0 Tk1m/tTvs+Llq98L2lyLypQaLl780daloEiqiHUHgRIrFZARbet6qygH/1myiDsz+lwJ axDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BJhEq3a9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q9si9139493pgv.542.2019.04.03.08.56.46; Wed, 03 Apr 2019 08:57:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BJhEq3a9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726468AbfDCP4E (ORCPT + 99 others); Wed, 3 Apr 2019 11:56:04 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:42898 "EHLO mail-wr1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726099AbfDCP4D (ORCPT ); Wed, 3 Apr 2019 11:56:03 -0400 Received: by mail-wr1-f50.google.com with SMTP id g3so22090024wrx.9; Wed, 03 Apr 2019 08:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=smtmugjUengH7o/rPhG39S10hJLY2XSkPxiSSe6Erv4=; b=BJhEq3a9s6peDPA8A8b7eAIlTvXiJCzn9b6pXYB54cYnhEiBXjsu3r+yUtD9ENs2qk joYTQqoM+4g4GVEjMvcHsFOLR42LxvjvmqkPY3oyREBWo+KIrqaoTm7uWhhgM6BtumQe 0Sp3hpJmATdfkMogCNy2nO1S8oKizlYltDfZrbwNssbMd1bo3P/Cmr1+ktj+RIb5g6a/ w8EHmc1ddjEEasVZuPrLP0K3D+gZmsyD6co8jw5Fvj97IUfvVJd4H/3OEpSCqK2I2aZe So/DddIfExjSIqQs0ja3/YVVxzKwAlp/aug5ANEXEFptliFgl/Zn4FK5kiJVPAuTDk0B CKow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=smtmugjUengH7o/rPhG39S10hJLY2XSkPxiSSe6Erv4=; b=XMN7BxcZMle7DNRGBy4RNqt5ZpxZA1RK6sLZtFveHA3K+PCYBW48S9840OulEi3Fka RGLUVUxkOjuSl3c8UMuK9iVVX620O9/BZhCdkjHVqh2RwozcMSHAsHZ3KdfxjY3PYO8U EdHqBNiMG2NAz+xqFVrVSH5nK9l0JT/D6b0DJJcqUtH1c8MYxUBikEF6YAnhjpE69UT9 QxzMP4uhYJc0+8cP75J2kPBvu5wMaZUIDW9PfCQiC7REncCmo+JxjXynN0T/pATM64mA byk80Xs9IVvhI0jcBTvM5jgoTixEb5eSsBgzq+zDxinvkjenOhjOmOq61GCJdkLp2yAD 7YPQ== X-Gm-Message-State: APjAAAWFKx/G4HlqonL69Noo8quDsWaZUblrZVzd5ejD8j+/5cvAUY/R IHLxsXahuXZuCET7SCGZtIM= X-Received: by 2002:adf:e4c2:: with SMTP id v2mr232683wrm.124.1554306961636; Wed, 03 Apr 2019 08:56:01 -0700 (PDT) Received: from X555LD ([2a02:85f:510:b900:d5bf:dcd8:8640:a2fe]) by smtp.gmail.com with ESMTPSA id f128sm19406994wme.28.2019.04.03.08.55.56 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 03 Apr 2019 08:56:00 -0700 (PDT) Date: Wed, 03 Apr 2019 18:55:54 +0300 From: "Leonidas P. Papadakos" Subject: RE: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices To: Jose Abreu Cc: Robin Murphy , Philipp Tomsich , Heiko =?iso-8859-1?q?St=FCbner?= , Christoph =?iso-8859-1?q?M=FCllner?= , Maxime Coquelin , Alexandre Torgue , netdev@vger.kernel.org, LKML , Linux ARM , Klaus Goger Message-Id: <1554306954.1328.1@gmail.com> In-Reply-To: <1554305721.1328.0@gmail.com> References: <20190401181840.31255-1-papadakospan@gmail.com> <9d65a22a-2288-dc53-0059-ec4a31424dd8@arm.com> <2312344.mOsv7YkeBG@diego> <9EC67532-2D43-4AAD-BFA7-8B6797067427@theobroma-systems.com> <78EB27739596EE489E55E81C33FEC33A0B421348@de02wembxa.internal.synopsys.com> <4a9839d6-3d90-4354-7b64-78d5c1126e99@arm.com> <78EB27739596EE489E55E81C33FEC33A0B423811@de02wembxa.internal.synopsys.com> <1554245296.1271.0@gmail.com> <78EB27739596EE489E55E81C33FEC33A0B4254A0@de02wembxa.internal.synopsys.com> <1554305721.1328.0@gmail.com> X-Mailer: geary/3.32.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > If snps,no-pbl-x8 does indeed have a performace hit, should the > workaround be to > a) turn tx checksumming off or > b) snps,no-pbl-x8 set? > > I'll test to see the difference Update: It really seems like snps,no-pbl-x8 is the better option. So I say, replace snps,force_thresh_dma_mode with it.