Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp311364yba; Wed, 3 Apr 2019 09:10:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqzYMsSwKe2hsNz8wi1MU1wMOhvYCE2XPyaVMjNuS9GRd0LM5ZCT+QnegCatG9Q1Iw1A82D4 X-Received: by 2002:a17:902:ec0b:: with SMTP id cy11mr775835plb.21.1554307806247; Wed, 03 Apr 2019 09:10:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554307806; cv=none; d=google.com; s=arc-20160816; b=nkOu/Ub6shjWHNWch3WyW/WVjKEsJocsGKIl1x3XPg6qd/2PgfwNn+nWFK0a2fTc5b QiaaEQvjGKGGr+o0tEOtkOl1qdjIrchPmXNviUPzwC5NWeqQin1OG81D3mycgI4hMDNW T6vocgwwMqM8sElH2Fdrse3l+yb31SAcmgS+jTjn0XXaWAVtDeRcANwFmbKdHD9yuHVD TV7DwMSerhp5Yuw++n+0EIJ270/cHA6Lhe0jz1I/+KNr85AJwJf1o3cxrf4X5rnnuhST gdGkO+FklFbfMnrEsVQ3t3GjyJK/UuWD3sCgYU35ciG8fEU46lcv/ID62HQXpvwyAkL9 I//g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6UKrouLSO9YGf202OeHJTSISbS0nfGS6XGw/sMkz2ko=; b=ENCAjjniyUvO10WRe7HJj6aE8jCn7tqPjRFo8xr6F19exyA5IE+YCSevQ4ngQmtOQ6 0/pNrDh3uDfaLIk2WPaFaSjuimzhWdp5HrzEvUPh++0herv0mU+k8f/wb3R3RYBRUKNb ViFRs20uY4y2ZGm7zHnn0+spbaqlKx1vhw+ZTMrtx5zDw59h5WSPybUVMBaehVUTbhY8 8IxPP4dk8vruxkFAm5q/q+fza5IfzpMWTTcWEFDyaBJHVRsv6PBM4/oAbjgphBeONFBw VCEZ2LUNg+FouRvnoQBIJJujxMn0GXoWKr3XsUfWIWG5QysjZYo+ITcGOM4wmkkxge3R vqTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=SK873dho; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r5si13963985pls.46.2019.04.03.09.09.51; Wed, 03 Apr 2019 09:10:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=SK873dho; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726886AbfDCQI7 (ORCPT + 99 others); Wed, 3 Apr 2019 12:08:59 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:32828 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726064AbfDCQI7 (ORCPT ); Wed, 3 Apr 2019 12:08:59 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x33G8eDa108963; Wed, 3 Apr 2019 16:08:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=corp-2018-07-02; bh=6UKrouLSO9YGf202OeHJTSISbS0nfGS6XGw/sMkz2ko=; b=SK873dhoOJ098oW9qX/LBUJG1yK+EHo0A6lM9ZNxq9LCVL4PhZTJiPZquZgVmVfDhIU6 gfc/VHWuIEJMhw1Q0bpaYcik0fQcG2RHWvuyXg4mvjIVhyQ0MFVRGjRVj2Wvr/fQ1/lW CpJo6iLUkBVC5nhl1AzOmC0zRf7j3pyofsE7DnWNSgcuQOQxL/IyoZFCUMPv4WSAmkgC FpHXzHSyHQfjeB0dA9gV+G9VB4eTpfcmZC3WEu0BVEs3RlYLcfWUee8RbaKrZwckuf07 tC2VlPnvohyw1xBi+C4k/3YJabuJRoHCOtbfXHwbg74phwl2Txu9+DnPkQOhq/hSlQG/ ZA== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2rj13q9y2k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Apr 2019 16:08:40 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x33G7ZGm024334; Wed, 3 Apr 2019 16:08:40 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 2rm8f66a6g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Apr 2019 16:08:40 +0000 Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x33G8cBU017591; Wed, 3 Apr 2019 16:08:38 GMT Received: from ca-dmjordan1.us.oracle.com (/10.211.9.48) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 03 Apr 2019 09:08:38 -0700 Date: Wed, 3 Apr 2019 12:09:03 -0400 From: Daniel Jordan To: Christophe Leroy Cc: Daniel Jordan , akpm@linux-foundation.org, Davidlohr Bueso , kvm@vger.kernel.org, Alan Tull , Alexey Kardashevskiy , linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-mm@kvack.org, Alex Williamson , Moritz Fischer , Christoph Lameter , linuxppc-dev@lists.ozlabs.org, Wu Hao Subject: Re: [PATCH 1/6] mm: change locked_vm's type from unsigned long to atomic64_t Message-ID: <20190403160903.5so4okn3ha2tvob3@ca-dmjordan1.us.oracle.com> References: <20190402204158.27582-1-daniel.m.jordan@oracle.com> <20190402204158.27582-2-daniel.m.jordan@oracle.com> <4140911c-8193-010b-e8fc-c8b24ffdf423@c-s.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4140911c-8193-010b-e8fc-c8b24ffdf423@c-s.fr> User-Agent: NeoMutt/20180323-268-5a959c X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9216 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=911 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904030109 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9216 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=949 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904030110 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 03, 2019 at 06:46:07AM +0200, Christophe Leroy wrote: > > > Le 02/04/2019 ? 22:41, Daniel Jordan a ?crit?: > > Taking and dropping mmap_sem to modify a single counter, locked_vm, is > > overkill when the counter could be synchronized separately. > > > > Make mmap_sem a little less coarse by changing locked_vm to an atomic, > > the 64-bit variety to avoid issues with overflow on 32-bit systems. > > Can you elaborate on the above ? Previously it was 'unsigned long', what > were the issues ? Sure, I responded to this in another thread from this series. > If there was such issues, shouldn't there be a first patch > moving it from unsigned long to u64 before this atomic64_t change ? Or at > least it should be clearly explain here what the issues are and how > switching to a 64 bit counter fixes them. Yes, I can explain the motivation in the next version.