Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 3 Apr 2019 13:16:54 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Tom Zanussi <tzanussi@gmail.com>
Cc:     Mario.Limonciello@dell.com, pali.rohar@gmail.com,
        linux-kernel@vger.kernel.org
Subject: Re: dell_smbios KASAN bug
Message-ID: <20190403131654.7379a991@gandalf.local.home>
In-Reply-To: <1553530847.6114.0.camel@gmail.com>
References: <1553106560.2080.5.camel@gmail.com>
        <20190320144146.08ecd5e4@gandalf.local.home>
        <1553108749.2079.1.camel@gmail.com>
        <20190320151353.1a223c0e@gandalf.local.home>
        <9541737623f942e49e9310aef963ffbf@ausx13mpc120.AMER.DELL.COM>
        <20190325101731.3558ecda@gandalf.local.home>
        <1553530847.6114.0.camel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 25 Mar 2019 11:20:47 -0500
Tom Zanussi <tzanussi@gmail.com> wrote:

> > Is it OK if I add the following tags to that patch?
> > 
> > Reported-by: Tom Zanussi <tzanussi@gmail.com>
> > Tested-by: Tom Zanussi <tzanussi@gmail.com>
> >   
> 
> Yep, fine with me.

I modified the patch slightly. Can you test this too. There should be
no reason that it wont work as this is "safer" but I don't want to put
your tested-by if you haven't tested it ;-)

-- Steve

diff --git a/drivers/platform/x86/dell-smbios-base.c b/drivers/platform/x86/dell-smbios-base.c
index 0537d44d45a6..a74c0df25b15 100644
--- a/drivers/platform/x86/dell-smbios-base.c
+++ b/drivers/platform/x86/dell-smbios-base.c
@@ -625,6 +625,8 @@ static int __init dell_smbios_init(void)
 
 fail_platform_driver:
 	kfree(da_tokens);
+	da_tokens = NULL;
+	da_num_tokens = 0;
 	return ret;
 }