Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp432754yba; Wed, 3 Apr 2019 11:32:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqzH2qYxsP0WMl4PJ8XFoRbKuW5Wi6w5lsA+5AMxY+KJTShnpFwpyjBJvxitTwcwrybwBXGb X-Received: by 2002:a65:6150:: with SMTP id o16mr1152304pgv.285.1554316362322; Wed, 03 Apr 2019 11:32:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554316362; cv=none; d=google.com; s=arc-20160816; b=eHu1FpSMFQfLFrPFuDAuEI/w7IkyGbgQDNZBWISj+GsBO35O7V70Kz0WYYG0r6Fy/w 3K+107EdyZtvHr6Vp+dJBvbB5V4xVfIUM0FrMuu5OL0ngJqPbwUL8p9iwPPSVtKNMHMN bnRcQxSbwgttOa6ZuOlmxF/cJxQ00QkjgfNjqSXgBLYs7dHvZCYdTZmg56w2O4xlNE/o 7l/h69rzxGS+c76uUFYL/eCVRR7d1YEZC2hgaN26cALEBs2yzMuum37W7S2aEpR7xzmP d8Vs/5LMmBR6YIDeik2B/x/SJYgUY1A0L4wS1ySMMOZTb7nt86k4CU9ofHI2pJ5fwJ6m jL9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=qGyOEoxy0h99gsusBdQVGr14JAL4WdfFO3oAZW2FLVs=; b=tMw2fQQdGqnv7jqSCXl16IOv7z05cvQShGHVlLGoz2dKPW+S0Djh+wyVYTxBsXMvIV It9xcIAuCkYqtTjt8Fd+wm+Ev+Q9QRzIAqq+Yx2Gq4e1lH1KbFP84o36wji+bEtYpHJu Ape52+9zrqQBynEA5cEMVvJKqvGoAITv5N4dFOYubmkT40JlSu4lkzPuuDcsGOARtSNI haVN2mzCoPaltmFsCq6yxUpTle0W+l9bM+unFweBXDzv2kGnWx2ThI5rGHdqjWHCleQB p57TNIn8Ll9BWL3aMFTshfKi6dK96vxkGQ3RveWIGSxRnkl69MQY1SIpJl3G2xnKzW8j xdDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=K82tE2mG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2si15110013pla.89.2019.04.03.11.32.27; Wed, 03 Apr 2019 11:32:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=K82tE2mG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726738AbfDCSbN (ORCPT + 99 others); Wed, 3 Apr 2019 14:31:13 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:42911 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbfDCSbN (ORCPT ); Wed, 3 Apr 2019 14:31:13 -0400 Received: by mail-oi1-f193.google.com with SMTP id w139so14410492oie.9 for ; Wed, 03 Apr 2019 11:31:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qGyOEoxy0h99gsusBdQVGr14JAL4WdfFO3oAZW2FLVs=; b=K82tE2mGbkfbDv/ZMwdn2vS34AGRa8573cH/nOfXtricK6qHk2WruUr1jEHi/JPnXV vWxTeXlW66+TJ1NbEvo1lrtb3vYU+bqXNe0Qrx5Uoq3sc4YDHNNtCOvOOf4+FqSjdFsa pOoZQ5neek+VAx7fOLXhKPMlurb9qAEtyn2RqpAVr24wGx0Fs6eFUjEk0mCydcuxhOBY EqtaZWO6vXg4UVn3DbNsTTqexizZMU2QIiAKrGzBH6wD1q8cKP6AAbpjs5TKrWrfyOa1 r4KWwti4xfuXWzoHYsHPBLF7WwXni4OkLXXBxHfwBXnkuIQ3a1+CB/Nc+Q0xbiuDymGR CLJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qGyOEoxy0h99gsusBdQVGr14JAL4WdfFO3oAZW2FLVs=; b=KYX+V6BJu844fsVBLu85aFJdKOsNshu3UTr7p0B+kU5rOB14Ta9hcqKWAjIvpRrjct eTDjIjVi1qOdZb0jDc1vVVaxMircdcAAKrYcK0/yG3JASlzXJv1tiyhBl6jRfGqm9+R+ u3e66615Z5Fr7l2EKqhoaF7zWdBDiqox7+25wAh7pNBU/8CngIC3UPhG45wJsxwue5Oi zqRsuBTRTNn24UFClIph6YVXV2Oc6UeZhUZbt7Z43rC71VDqJuCKNfSgEnz0C6WmLeSw r4GVoHS6PnhBEkJMqD3Ynun6Vrwy6+4k6e8wErEZf5L1i3JRRmgb3o08Jh0bTQ6cEytw tonQ== X-Gm-Message-State: APjAAAVwTl1ZsE3RkO42J7BTme97HzUmTQV3XkpQbsjHOh8ZVA4WbV4c UlFk3/cKYzyxC3xgevJ2sLPT2+ZOsZLrqrgZBfRvAw== X-Received: by 2002:aca:f581:: with SMTP id t123mr660054oih.0.1554316272610; Wed, 03 Apr 2019 11:31:12 -0700 (PDT) MIME-Version: 1.0 References: <20190402142816.GA13084@linux.ibm.com> <20190402142933.14547-1-paulmck@linux.ibm.com> In-Reply-To: <20190402142933.14547-1-paulmck@linux.ibm.com> From: Dan Williams Date: Wed, 3 Apr 2019 11:31:01 -0700 Message-ID: Subject: Re: [PATCH RFC tip/core/rcu 1/4] dax/super: Dynamically allocate dax_srcu To: "Paul E. McKenney" Cc: rcu@vger.kernel.org, Linux Kernel Mailing List , Ingo Molnar , jiangshanlai@gmail.com, dipankar@in.ibm.com, Andrew Morton , Mathieu Desnoyers , Josh Triplett , Thomas Gleixner , Peter Zijlstra , Steven Rostedt , David Howells , Eric Dumazet , fweisbec@gmail.com, Oleg Nesterov , joel@joelfernandes.org, Vishal Verma , Keith Busch , Dave Jiang , Tejun Heo , linux-nvdimm Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 2, 2019 at 7:29 AM Paul E. McKenney wrote: > > Having DEFINE_SRCU() or DEFINE_STATIC_SRCU() in a loadable module > requires that the size of the reserved region be increased, which is > not something we really want to be doing. This commit therefore removes > the DEFINE_STATIC_SRCU() from drivers/dax/super.c in favor of defining > dax_srcu as a simple srcu_struct, initializing it in dax_core_init(), > and cleaning it up in dax_core_exit(). > > Reported-by: kbuild test robot > Signed-off-by: Paul E. McKenney Looks good to me. Reviewed-by: Dan Williams