Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp466582yba; Wed, 3 Apr 2019 12:16:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqxhpWfgyt+ppVYO3NL+ZYaW5cUIbwtq/tFZKLMguWrqLGwSL7R1yzIJ2Ci+GJbTV/GOecKd X-Received: by 2002:a62:1197:: with SMTP id 23mr1216604pfr.210.1554319002655; Wed, 03 Apr 2019 12:16:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554319002; cv=none; d=google.com; s=arc-20160816; b=u+fyVUDY196T3HkwhHg9OxEJWl7NCLWwqHmFYYWk42sb+SWnIOVF58x9fFHYU70/H2 8HwKcT9kJbGzBoF85wM1r+DoI/dQFlJNVILz9Pp34IeDzGE7cH2l1AUAzbUFlS04dmBL YTB4MMaaev+zRJS93OibQCe4ghh3qqzPMJM+X/cnOHXTOyhe4KA5WBQLhF7Ljcm2glEm TgubpjqsDStTiPcT+uLYqp7DM1LINdAMMkCE5Uwquw1j00qbvcvDvQq7uEQNe0KO5vYZ j09AO3iFVYffJPcKCzyAw+9tEohTqfdq66ALFv1hOxNbdaEQM61mT53mLpGPVNa2qo3b TOug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from; bh=NZOn30q97vz9y5DSJgDCTYLeZ7dz3d0iJChFyEnyoIg=; b=bU+LGf6AhbkNdcrqpNWh5YHvmbER8lpPp0PhBuEhJsuIFgXs+urwlVfpGSq23CEGLB fnLFKW48n0QoLWc7y6Fa/wGibY2PS4j6YkgY1Dl1CoELNscJJ6voqNSGv6QiB57uGsc2 hFwjDUPc+3WAbVVITdZ2lugFdhk9pSRuCqQms1KftnPtsxWeDPMj4xg5kvanQ7VVnzCe r5gXJq/ULPm03H21Vdng3ibWJkNvJQ+OTYLon0gESZ2lvTvr6+lVUb5xf+y2foW91Cua SmXz9DcyAHreg2qjxymiJt3mkL9Or9XvQAlypOCukMpVL+tpCKDOUV1YkbQPR0T6n5VN wiMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 12si14646831plb.335.2019.04.03.12.16.27; Wed, 03 Apr 2019 12:16:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726585AbfDCTPc (ORCPT + 99 others); Wed, 3 Apr 2019 15:15:32 -0400 Received: from anholt.net ([50.246.234.109]:34024 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726064AbfDCTPc (ORCPT ); Wed, 3 Apr 2019 15:15:32 -0400 Received: from localhost (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 7D69710A2F03; Wed, 3 Apr 2019 12:15:31 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at anholt.net Received: from anholt.net ([127.0.0.1]) by localhost (kingsolver.anholt.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 0oU17i2LBtXg; Wed, 3 Apr 2019 12:15:30 -0700 (PDT) Received: from eliezer.anholt.net (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 292B410A2DD2; Wed, 3 Apr 2019 12:15:30 -0700 (PDT) Received: by eliezer.anholt.net (Postfix, from userid 1000) id B020F2FE3483; Wed, 3 Apr 2019 12:15:29 -0700 (PDT) From: Eric Anholt To: Paul Kocialkowski , dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Maxime Ripard Subject: Re: [PATCH v2 2/2] drm/vc4: Disable V3D interactions if the v3d component didn't probe. In-Reply-To: References: <20190401183559.3823-1-eric@anholt.net> <20190401183559.3823-2-eric@anholt.net> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Wed, 03 Apr 2019 12:15:29 -0700 Message-ID: <87bm1moq7i.fsf@anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Paul Kocialkowski writes: > Hi, > > On Mon, 2019-04-01 at 11:35 -0700, Eric Anholt wrote: >> One might want to use the VC4 display stack without using Mesa. >> Similar to the debugfs fixes for not having all of the possible >> display bits enabled, make sure you can't oops in vc4 if v3d isn't >> enabled. > > Just thought about this: perhaps we should be returning -ENODEV instead > of -EINVAL when !vc4->v3d, just so that the error is a bit more > explicit to userspace? I like it. Doing that while applying the series. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlylBlEACgkQtdYpNtH8 nugVaBAAiL1YcEpP77T4qlkmL2FNDFcSRt6dsyldUZPGcj3aqltXF4N6rjT/+xp6 l9md04QkPb15W1CNDOqtEMTBr9oq3U1m6ULITCP84Je1pzbZ5Etf5dfXeHMBnKJ5 NSX6i8u5uuqopEZS/RucilsOrxQvithN6HVtrvqU8SR/dY/Uti6VB306WGEa7RTZ QwdOUjcAL5uLMUS6AhrLr/csuNtUDnAKqdabeOQFdpCffZFudA97ik4LhFG8RaTk dB1sHqwNkasPwjI2cxm2yolLgnoI6qEP9HkJ30lcinG16F2ViW8adtGkfEDISHL7 5iXXJqmBo7qDWViqTynF77KAoxrOz9LnesxrvHmH1vBaBSmgXobPpj6rYMftJaIq CPh4di5/aiN8C3rLO+M7R3NZ0n7XYT3x+4y2PbiGwwLgsyQZTvqscaRNiZZk/Z7V WAVLmyQO2PkprLGMxjlrXh1MKOYW1roc9oJb3pyNgs+dGLC8upvyHrxqNGYbcqsz xqhBoaNz+rTIxIohvxRXIUoUbylFCdZq0RvBAl8oFyyJfI4LnldLHi9980hLpBiS e/XvtPEfW+XyS8j7MO8mpIRTivqj3yIqcrd6isHo6WzZCRnFQdEbPS+sxu0uyMiR zEWWc+h2jCWOVHY6rDHXo8n821HxtYy6esT4NTdNhdv2rK8aiV4= =WQsh -----END PGP SIGNATURE----- --=-=-=--