Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp584931yba; Wed, 3 Apr 2019 15:04:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqxiLajQFyxyW55hNUkX5Ti1dRXQ5Lcz5Wbu/0eqVyA5pNRBpj55c0z1zhYz0iDLJEPdCKWL X-Received: by 2002:a65:5acc:: with SMTP id d12mr2044675pgt.337.1554329096910; Wed, 03 Apr 2019 15:04:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554329096; cv=none; d=google.com; s=arc-20160816; b=eE/68V15CBlMH4KBNjyf0B7/YCXrDCX4QhGjUKLGFwJkgvJ2dkMOaOAvnuwdd/cvVr m7vsYwbCZJBJyhvRm6H4FFFqiBJq/0UWy39gbJkRHf4AbCP0VdzzVVVtyLyhj7ExIQns GVWFJmELFmsEocTZ1EyRR5SM7Jlc6hyrlr779b+VZe5h8VMWu3jNwyNC4x81QiY81/NE QhwgVPkX0kbBb+1rjNsPUcaGA7QDb79nTMY/wtVD0I585bRwODXiq0ZMjy8hlUXydsWf Yfym4nB4WutT4AAtkc1Y8T+VzKTdTf714xP/XAAU2rfqMiTeGdMyxfGBKYnaM+d9GHh4 i0bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=S1Z68NfE9bNYehM0kLb1gbJm3la0hffxhAqrAk/KpBs=; b=g03THQGa/fYx//ty1D9dU4DrOggYJ6T9nU3bWLnt0DaQb7x17rG135IznUXBmB9zuL wvLc9sNMsXN16fK0GCT/Btl7QG4zmSQJN4jHSQmYm6m6Kg2MLRN9S+UnWRbJleqisxy8 OnmVlBShfZYnljlZZx/jRFwz3Drd9QB7vnJNDaiFd0EGPZ+5iU0XR0Nm61PiCRaHWzrh qwYNcr9/4mXLnOSDp022kPaqAFF2GF9j3mnS20qDy8K2FEYdCj5B2nYNv6ClfXSh5IrP BeEI7gRVsiYCWS1mHAv2bKvyzUik6rMXBRAL+9G+UgKBu/bWE7TI3IWFSQmV3G7UGt4F pprA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=uNEVcBRm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q78si13204932pgq.321.2019.04.03.15.04.41; Wed, 03 Apr 2019 15:04:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=uNEVcBRm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726494AbfDCWEA (ORCPT + 99 others); Wed, 3 Apr 2019 18:04:00 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40508 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726099AbfDCWEA (ORCPT ); Wed, 3 Apr 2019 18:04:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=S1Z68NfE9bNYehM0kLb1gbJm3la0hffxhAqrAk/KpBs=; b=uNEVcBRmP/7cpAOiwdSQ+1FfJW yMm97MfI/WsBKdIH214GiHXKA++oOD1ND7RbM8YrWboBursuAdHnkAtnkiOiSJm7Cb0aUlel7oe08 1QPBfp2DV0pQLe8tAm2kOaA7WhHiJ64g2bi6UcKALPAVEC9mMImxYEW0rv18owVWhvxrrXP3pLg5i eEwfkiu7YdZYqQrVLyXYFZO4/DCz86nbR/jF6yw3qzw3Abq9G66hyqDEReDt/SwR+JPvjrLMaMbPD uUoifbiX6YmqusZrQNaBZD3TIG0JWPT0g89B9dB6j6Gz9LvsRsTv0HsUuUlOZRqJPHlqZbm8b4hQx 86QCmReg==; Received: from dvhart by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBnzD-0002hc-Ow; Wed, 03 Apr 2019 22:03:59 +0000 Date: Wed, 3 Apr 2019 15:03:58 -0700 From: Darren Hart To: Mario.Limonciello@dell.com Cc: andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH] platform/x86: dell-laptop: fix rfkill functionality Message-ID: <20190403220358.GD39081@wrath> References: <1553696734-31282-1-git-send-email-mario.limonciello@dell.com> <20190403202338.GB39081@wrath> <643bcf131bc642cb821ba57f69707fc9@ausx13mpc120.AMER.DELL.COM> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <643bcf131bc642cb821ba57f69707fc9@ausx13mpc120.AMER.DELL.COM> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 03, 2019 at 09:54:27PM +0000, Mario.Limonciello@dell.com wrote: > > -----Original Message----- > > From: Darren Hart > > Sent: Wednesday, April 3, 2019 3:24 PM > > To: Limonciello, Mario > > Cc: Andy Shevchenko; LKML; platform-driver-x86@vger.kernel.org > > Subject: Re: [PATCH] platform/x86: dell-laptop: fix rfkill functionality > > > > > > [EXTERNAL EMAIL] > > > > On Wed, Mar 27, 2019 at 09:25:34AM -0500, Mario Limonciello wrote: > > > When converting the driver two arguments were transposed leading > > > to rfkill not working. > > > > > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201427 > > > Reported-by: Pepijn de Vos > > > Fixes: 549b49 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls") > > > Signed-off-by: Mario Limonciello > > > Acked-by: Pali Roh?r > > > > Looks like this broken in 4.14? So Cc stable back to then? I'm surprised it's > > been broken that long :-( > > > > Not many "newer" platforms actually use this radio control anymore. It's been > superseded by other technologies. So I think that would be the main reason. > > Can you CC it to stable when it's committed or do I need to re-send or anything? > I will add the Cc to stable. Just wanted to confirm our expectations were aligned. -- Darren Hart VMware Open Source Technology Center