Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 3 Apr 2019 20:46:08 -0400
From:   Sasha Levin <sashal@kernel.org>
To:     Mark Brown <broonie@kernel.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Axel Lin <axel.lin@ingics.com>
Subject: Re: [PATCH AUTOSEL 5.0 209/262] regulator: mcp16502: Include
 linux/gpio/consumer.h to fix build error
Message-ID: <20190404004608.GG16241@sasha-vm>
References: <20190327180158.10245-1-sashal@kernel.org>
 <20190327180158.10245-209-sashal@kernel.org>
 <20190327193211.GC11404@sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190327193211.GC11404@sirena.org.uk>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 27, 2019 at 07:32:11PM +0000, Mark Brown wrote:
>On Wed, Mar 27, 2019 at 02:01:04PM -0400, Sasha Levin wrote:
>> From: Axel Lin <axel.lin@ingics.com>
>>
>> [ Upstream commit f3c6a1a194317f3a31ee2b2067bb0a41de64bc8b ]
>>
>> Fix below build error:
>> drivers/regulator/mcp16502.c: In function ‘mcp16502_gpio_set_mode’:
>> drivers/regulator/mcp16502.c:135:3: error: implicit declaration of function ‘gpiod_set_value’; did you mean ‘gpio_set_value’? [-Werror=implicit-function-declaration]
>>    gpiod_set_value(mcp->lpm, 0);
>
>Does this error actually manifest in v5.0?

I couldn't reproduce the error on f3c6a1a194317f^ so I assumed it
requires a specialized config.

--
Thanks,
Sasha